Remove kComputePressureBreakCalibrationMitigation flag [chromium/src : main]
0 views
Skip to first unread message
Rob Pitkin (Gerrit)
3:39 PM (5 hours ago) 3:39 PM
to Matt Reynolds, Alvin Ji, Chromium LUCI CQ, AyeAye, Arnaud Mandy, Chromium Metrics Reviews, chromium...@chromium.org, Kenneth R Christiansen, Wang, Wei4, asvitkine...@chromium.org
Attention needed from Alvin Ji and Matt Reynolds
Rob Pitkin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Alvin Ji
- Matt Reynolds
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reynolds (Gerrit)
5:10 PM (4 hours ago) 5:10 PM
to Rob Pitkin, Alvin Ji, Chromium LUCI CQ, AyeAye, Arnaud Mandy, Chromium Metrics Reviews, chromium...@chromium.org, Kenneth R Christiansen, Wang, Wei4, asvitkine...@chromium.org
Attention needed from Alvin Ji and Rob Pitkin
Matt Reynolds added 1 comment![]( "Open in Gerrit")
File tools/metrics/histograms/enums.xml
Line 15785, Patchset 1 (Parent):
<int value="527010182"Matt Reynolds . unresolved
Please restore the enums in this file. There's an easily missed comment about 7000 lines above that says we shouldn't remove enum entries for removed flags:
See also the "Flags histograms" section in the README which has instructions for how this file should be updated:
Related details
Attention is currently required from:
- Alvin Ji
- Rob Pitkin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rob Pitkin (Gerrit)
5:55 PM (3 hours ago) 5:55 PM
to Matt Reynolds, Alvin Ji, Chromium LUCI CQ, AyeAye, Arnaud Mandy, Chromium Metrics Reviews, chromium...@chromium.org, Kenneth R Christiansen, Wang, Wei4, asvitkine...@chromium.org
Attention needed from Alvin Ji and Matt Reynolds
Rob Pitkin added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File tools/metrics/histograms/enums.xml
Line 15785, Patchset 1 (Parent):
<int value="527010182"Matt Reynolds . resolved
Please restore the enums in this file. There's an easily missed comment about 7000 lines above that says we shouldn't remove enum entries for removed flags:
See also the "Flags histograms" section in the README which has instructions for how this file should be updated:
Rob Pitkin
Awesome, this is super good to know going forwards and makes total sense. Thanks for pointing it out!
Related details
Attention is currently required from:
- Alvin Ji
- Matt Reynolds
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reynolds (Gerrit)
6:04 PM (3 hours ago) 6:04 PM
to Rob Pitkin, Alvin Ji, Chromium LUCI CQ, AyeAye, Arnaud Mandy, Chromium Metrics Reviews, chromium...@chromium.org, Kenneth R Christiansen, Wang, Wei4, asvitkine...@chromium.org
Attention needed from Alvin Ji and Rob Pitkin
Matt Reynolds voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matt Reynolds
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Alvin Ji
- Rob Pitkin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alvin Ji (Gerrit)
6:21 PM (2 hours ago) 6:21 PM
to Rob Pitkin, Matt Reynolds, Chromium LUCI CQ, AyeAye, Arnaud Mandy, Chromium Metrics Reviews, chromium...@chromium.org, Kenneth R Christiansen, Wang, Wei4, asvitkine...@chromium.org
Attention needed from Rob Pitkin
Alvin Ji voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alvin Ji
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Rob Pitkin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rob Pitkin (Gerrit)
7:25 PM (1 hour ago) 7:25 PM
to Alvin Ji, Matt Reynolds, Chromium LUCI CQ, AyeAye, Arnaud Mandy, Chromium Metrics Reviews, chromium...@chromium.org, Kenneth R Christiansen, Wang, Wei4, asvitkine...@chromium.org
Rob Pitkin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
7:28 PM (1 hour ago) 7:28 PM
to Rob Pitkin, Alvin Ji, Matt Reynolds, AyeAye, Arnaud Mandy, Chromium Metrics Reviews, chromium...@chromium.org, Kenneth R Christiansen, Wang, Wei4, asvitkine...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove kComputePressureBreakCalibrationMitigation flag
This flag has been enabled by default since November 2023, so
it should be safe to remove.
Bug: 475855975
Change-Id: If37781b27504d8cb98211830f33c9f3005d04590
Reviewed-by: Matt Reynolds <mattre...@chromium.org>
Commit-Queue: Rob Pitkin <robp...@chromium.org>
Reviewed-by: Alvin Ji <alv...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1570086}
Files:
- M content/browser/compute_pressure/pressure_service_base.cc
- M services/device/public/cpp/device_features.cc
- M services/device/public/cpp/device_features.h
Change size: S
Delta: 3 files changed, 1 insertion(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alvin Ji, +1 by Matt Reynolds
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages