[BAM] Introducing OpenLink ContentContext Commands [chromium/src : main]

0 views
Skip to first unread message

Darryl James (Gerrit)

unread,
4:00 PM (3 hours ago) 4:00 PM
to Kunal Daftari, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Kunal Daftari

Darryl James voted and added 1 comment

Votes added by Darryl James

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Darryl James . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • Kunal Daftari
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6f9fa0d78cefb38c9b1e5d4c330d9b16bfa33822
Gerrit-Change-Number: 8064534
Gerrit-PatchSet: 1
Gerrit-Owner: Kunal Daftari <kunald...@google.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Kunal Daftari <kunald...@google.com>
Gerrit-Attention: Kunal Daftari <kunald...@google.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 20:00:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kunal Daftari (Gerrit)

unread,
4:01 PM (3 hours ago) 4:01 PM
to Darryl James, Chromium LUCI CQ, chromium...@chromium.org

Kunal Daftari voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6f9fa0d78cefb38c9b1e5d4c330d9b16bfa33822
Gerrit-Change-Number: 8064534
Gerrit-PatchSet: 1
Gerrit-Owner: Kunal Daftari <kunald...@google.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Kunal Daftari <kunald...@google.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 20:01:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
4:06 PM (3 hours ago) 4:06 PM
to Kunal Daftari, Darryl James, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[BAM] Introducing OpenLink ContentContext Commands

kActionContentContextOpenLinkNewTab, kActionContentContextOpenLinkNewWindow, kActionContentContextOpenLinkOffTheRecord.
Bug: 525118424
Change-Id: I6f9fa0d78cefb38c9b1e5d4c330d9b16bfa33822
Commit-Queue: Kunal Daftari <kunald...@google.com>
Reviewed-by: Darryl James <dlj...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659015}
Files:
  • M chrome/browser/ui/actions/chrome_action_properties.cc
  • M chrome/browser/ui/actions/chrome_action_properties.h
  • M chrome/browser/ui/browser_actions.cc
Change size: M
Delta: 3 files changed, 145 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Darryl James
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6f9fa0d78cefb38c9b1e5d4c330d9b16bfa33822
Gerrit-Change-Number: 8064534
Gerrit-PatchSet: 2
Gerrit-Owner: Kunal Daftari <kunald...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Kunal Daftari <kunald...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages