Revert "[iOS] Add web view resizing type enum" [chromium/src : main]
0 views
Skip to first unread message
Mike Dougherty (Gerrit)
Sep 25, 2025, 12:35:21 PM (yesterday) Sep 25
to Chromium LUCI CQ, Aliona Dangla, Gauthier Ambard, chromium...@chromium.org, Scott Yoder
Mike Dougherty has uploaded the change for review![]( "Open in Gerrit")
Mike Dougherty would like Chromium LUCI CQ, Aliona Dangla and Gauthier Ambard to review this change.
Commit message
Revert "[iOS] Add web view resizing type enum"
This reverts commit 9d6a54fd99ef40212ea0bd35792667c785228604.
Reason for revert: compile failing at https://ci.chromium.org/ui/p/chrome/builders/luci.chrome.ci/simulator-builder-arm64
Original change's description:
> [iOS] Add web view resizing type enum
>
> This change add the `WebViewResizingType` enum to define different
> resizing behaviors for the web view. This allows for more precise
> control over how the viewport adapts to UI changes, such as the
> appearance of toolbars or other elements.
>
> This enum is a necessary component for the "Bling Fullscreen
> refactoring" on iOS 26. It provides the infrastructure to handle various
> fullscreen scenarios and ensures that content is resized correctly when
> parts of the viewport are obscured.
>
> See go/bling-fullscreen-refactoring-part1 for more details
>
> This is part of multiples changes
> * https://crrev.com/c/6839620 | [iOS] Implement fullscreen with obscured inset in iOS 26
> * ➔ https://crrev.com/c/6853827 | [iOS] Add fullscreen resizing type enum (Current CL)
> * https://crrev.com/c/6973698 | [iOS] Add web view resizing enum
> * https://crrev.com/c/6827602 | [iOS] Add obscured inset property
>
> Bug: 438144976
> Change-Id: I310cc99ec1521bcd8929594a15d1e36187835911
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6853827
> Reviewed-by: Gauthier Ambard <gam...@chromium.org>
> Commit-Queue: Aliona Dangla <aliona...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1520655}
Bug: 438144976
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: If2a63d0301e582a94d15d10f5ee114f52a0a77c5
Change diff
Change information
Files:
- M ios/web/common/crw_viewport_adjustment.h
- M ios/web/common/crw_web_view_content_view.mm
- M ios/web/content/web_state/crc_web_viewport_container_view.mm
Change size: S
Delta: 3 files changed, 0 insertions(+), 16 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Dougherty (Gerrit)
Sep 25, 2025, 12:53:10 PM (yesterday) Sep 25
to Rubber Stamper, AyeAye, Chromium LUCI CQ, Aliona Dangla, Gauthier Ambard, chromium...@chromium.org, Scott Yoder, ios-r...@chromium.org, ios-rev...@chromium.org
Attention needed from Aliona Dangla, Gauthier Ambard and Mike Dougherty
Message from Mike Dougherty![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Aliona Dangla
- Gauthier Ambard
- Mike Dougherty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Sep 25, 2025, 12:53:21 PM (yesterday) Sep 25
to Mike Dougherty, AyeAye, Chromium LUCI CQ, Aliona Dangla, Gauthier Ambard, chromium...@chromium.org, Scott Yoder, ios-r...@chromium.org, ios-rev...@chromium.org
Attention needed from Aliona Dangla, Gauthier Ambard and Mike Dougherty
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Aliona Dangla
- Gauthier Ambard
- Mike Dougherty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 25, 2025, 12:53:45 PM (yesterday) Sep 25
to Mike Dougherty, Rubber Stamper, AyeAye, Aliona Dangla, Gauthier Ambard, chromium...@chromium.org, Scott Yoder, ios-r...@chromium.org, ios-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Auto-Submit: Mike Dougherty <mich...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520691}
Files:
- M ios/web/common/crw_viewport_adjustment.h
- M ios/web/common/crw_web_view_content_view.mm
- M ios/web/content/web_state/crc_web_viewport_container_view.mm
Change size: S
Delta: 3 files changed, 0 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aliona Dangla (Gerrit)
9:01 AM (6 hours ago) 9:01 AM
to Chromium LUCI CQ, Mike Dougherty, Rubber Stamper, AyeAye, Gauthier Ambard, chromium...@chromium.org, Scott Yoder, ios-r...@chromium.org, ios-rev...@chromium.org
Aliona Dangla has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages