[CrossThreadHandle] Convert third_party/blink/renderer/core/loader/image

Ari Chivukula (Gerrit)

unread,

Nov 22, 2022, 8:04:05 AM11/22/22

to blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, Yoav Weiss, chromium...@chromium.org, Nate Chapin

Attention is currently required from: Yoav Weiss.

Patch set 1:Auto-Submit +1Commit-Queue +1

View Change

To view, visit change 4048060. To unsubscribe, or for help writing mail filters, visit settings.

Yoav Weiss (Gerrit)

unread,

Nov 25, 2022, 4:06:37 AM11/25/22

to Ari Chivukula, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin

Attention is currently required from: Ari Chivukula.

Patch set 1:Code-Review +1Commit-Queue +2

View Change

To view, visit change 4048060. To unsubscribe, or for help writing mail filters, visit settings.

Ari Chivukula (Gerrit)

unread,

Nov 25, 2022, 2:13:13 PM11/25/22

to blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, Yoav Weiss, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin

Patch set 2:Commit-Queue +2

View Change

To view, visit change 4048060. To unsubscribe, or for help writing mail filters, visit settings.

Ari Chivukula (Gerrit)

unread,

Nov 25, 2022, 4:41:38 PM11/25/22

to blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, Yoav Weiss, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin

Attention is currently required from: Ari Chivukula.

Patch set 2:Commit-Queue +2

View Change

To view, visit change 4048060. To unsubscribe, or for help writing mail filters, visit settings.

Ari Chivukula (Gerrit)

unread,

Nov 25, 2022, 11:19:11 PM11/25/22

to blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, Yoav Weiss, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin

Patch set 3:Auto-Submit +1Commit-Queue +2

View Change

To view, visit change 4048060. To unsubscribe, or for help writing mail filters, visit settings.

Ari Chivukula (Gerrit)

unread,

Nov 26, 2022, 8:02:45 AM11/26/22

to blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, Yoav Weiss, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin

Attention is currently required from: Ari Chivukula.

Patch set 3:Commit-Queue +2

View Change

To view, visit change 4048060. To unsubscribe, or for help writing mail filters, visit settings.

Ari Chivukula (Gerrit)

unread,

Nov 26, 2022, 12:13:41 PM11/26/22

to blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, Yoav Weiss, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin

Attention is currently required from: Ari Chivukula.

Patch set 4:Commit-Queue +2

View Change

To view, visit change 4048060. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Nov 26, 2022, 12:13:44 PM11/26/22

to Ari Chivukula, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, Yoav Weiss, chromium...@chromium.org, Nate Chapin

Chromium LUCI CQ submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals:
  Ari Chivukula: Send CL to CQ automatically after approval; Commit
  Yoav Weiss: Looks good to me

[CrossThreadHandle] Convert third_party/blink/renderer/core/loader/image_loader.cc

This is part of a cleanup task to make memory safer when data isn't used
cross thread, but is instead merely passed to be used back again on the
originating thread. Design doc:
https://docs.google.com/document/d/1GIT0ysdQ84sGhIo1r9EscF_fFt93lmNVM_q4vvHj2FQ/edit#

Bug: 1377337
Change-Id: I5974439bfa936a2fab0cbbe7c9ba791468ed685e

fuzzer infra failure

No-Try: true
Change-Id: I5974439bfa936a2fab0cbbe7c9ba791468ed685e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4048060
Auto-Submit: Ari Chivukula <ari...@chromium.org>
Reviewed-by: Yoav Weiss <yoav...@chromium.org>
Commit-Queue: Ari Chivukula <ari...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1075896}
---
M third_party/blink/renderer/core/loader/image_loader.cc
1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/third_party/blink/renderer/core/loader/image_loader.cc b/third_party/blink/renderer/core/loader/image_loader.cc
index 897f36d..745e705 100644
--- a/third_party/blink/renderer/core/loader/image_loader.cc
+++ b/third_party/blink/renderer/core/loader/image_loader.cc
@@ -60,6 +60,7 @@
 #include "third_party/blink/renderer/platform/bindings/exception_state.h"
 #include "third_party/blink/renderer/platform/bindings/script_state.h"
 #include "third_party/blink/renderer/platform/bindings/v8_per_isolate_data.h"
+#include "third_party/blink/renderer/platform/heap/cross_thread_handle.h"
 #include "third_party/blink/renderer/platform/heap/garbage_collected.h"
 #include "third_party/blink/renderer/platform/instrumentation/use_counter.h"
 #include "third_party/blink/renderer/platform/loader/attribution_header_constants.h"
@@ -227,7 +228,8 @@
     frame->GetChromeClient().RequestDecode(
         frame, image->PaintImageForCurrentFrame(),
         WTF::BindOnce(&ImageLoader::DecodeRequestFinished,
-                      WrapCrossThreadPersistent(this), request->request_id()));
+                      MakeUnwrappingCrossThreadHandle(this),
+                      request->request_id()));
     request->NotifyDecodeDispatched();
     ++it;
   }

To view, visit change 4048060. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

[CrossThreadHandle] Convert third_party/blink/renderer/core/loader/image_loader.cc [chromium/src : main]

Ari Chivukula (Gerrit)

Yoav Weiss (Gerrit)

Ari Chivukula (Gerrit)

Ari Chivukula (Gerrit)

Ari Chivukula (Gerrit)

Ari Chivukula (Gerrit)

Ari Chivukula (Gerrit)

Chromium LUCI CQ (Gerrit)