[Android] Fix NPE crash in ViewAndroidDelegate [chromium/src : main]
0 views
Skip to first unread message
Shakti Sahu (Gerrit)
Jul 7, 2026, 9:35:18 PM (15 hours ago) Jul 7
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Calder Kitagawa
Shakti Sahu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Calder Kitagawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Calder Kitagawa (Gerrit)
8:36 AM (4 hours ago) 8:36 AM
to Shakti Sahu, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Shakti Sahu
Calder Kitagawa voted and added 1 comment![]( "Open in Gerrit")
Votes added by Calder Kitagawa
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Shakti Sahu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shakti Sahu (Gerrit)
9:44 AM (3 hours ago) 9:44 AM
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org
Shakti Sahu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:49 AM (2 hours ago) 9:49 AM
to Shakti Sahu, Calder Kitagawa, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Android] Fix NPE crash in ViewAndroidDelegate
This CL fixes a crash by handling null containerView in
ViewAndroidDelegate which might happen when a transition to/from
side panel occurs. This change is safe and doesn't have any side
effects because all the null check skips is updating the pointer
icon and no other critical logic.
Fixed: 530082774
Change-Id: I1ff10a894959d49748177642abac138420862044
Commit-Queue: Shakti Sahu <shakt...@chromium.org>
Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1658703}
Files:
- M ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java
Change size: XS
Delta: 1 file changed, 4 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Calder Kitagawa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages