Increase the bus factor for WebSQL OWNERS. [chromium/src : master]

1 view
Skip to first unread message

Victor Costan (Gerrit)

unread,
Jul 18, 2017, 7:24:30 PM7/18/17
to blink-...@chromium.org, Adam Barth, chromium...@chromium.org, Kentaro Hara

Victor Costan posted comments on this change.

View Change

Patch set 1:

Set Ready For Review

    To view, visit change 576808. To unsubscribe, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-MessageType: comment
    Gerrit-Change-Id: I3f2e1c8b292777e454b5bc641dbe684929ead2a3
    Gerrit-Change-Number: 576808
    Gerrit-PatchSet: 1
    Gerrit-Owner: Victor Costan <pwn...@chromium.org>
    Gerrit-Reviewer: Victor Costan <pwn...@chromium.org>
    Gerrit-CC: Adam Barth <aba...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Comment-Date: Tue, 18 Jul 2017 23:24:25 +0000
    Gerrit-HasComments: No
    Gerrit-HasLabels: No

    Victor Costan (Gerrit)

    unread,
    Jul 18, 2017, 7:24:32 PM7/18/17
    to blink-...@chromium.org, Michael Nordman, Joshua Bell, Adam Barth, chromium...@chromium.org, Kentaro Hara

    Victor Costan posted comments on this change.

    View Change

    Patch set 1:

    michaeln: PTAL?

    jsbell: This is per our earlier discussion today.

      To view, visit change 576808. To unsubscribe, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-MessageType: comment
      Gerrit-Change-Id: I3f2e1c8b292777e454b5bc641dbe684929ead2a3
      Gerrit-Change-Number: 576808
      Gerrit-PatchSet: 1
      Gerrit-Owner: Victor Costan <pwn...@chromium.org>
      Gerrit-Reviewer: Michael Nordman <mich...@chromium.org>
      Gerrit-Reviewer: Victor Costan <pwn...@chromium.org>
      Gerrit-CC: Adam Barth <aba...@chromium.org>
      Gerrit-CC: Joshua Bell <jsb...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-Comment-Date: Tue, 18 Jul 2017 23:24:28 +0000
      Gerrit-HasComments: No
      Gerrit-HasLabels: No

      Victor Costan (Gerrit)

      unread,
      Jul 18, 2017, 9:10:31 PM7/18/17
      to blink-...@chromium.org, Michael Nordman, Joshua Bell, Adam Barth, chromium...@chromium.org, Kentaro Hara

      Victor Costan posted comments on this change.

      View Change

      Patch set 1:Commit-Queue +1

        To view, visit change 576808. To unsubscribe, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-MessageType: comment
        Gerrit-Change-Id: I3f2e1c8b292777e454b5bc641dbe684929ead2a3
        Gerrit-Change-Number: 576808
        Gerrit-PatchSet: 1
        Gerrit-Owner: Victor Costan <pwn...@chromium.org>
        Gerrit-Reviewer: Michael Nordman <mich...@chromium.org>
        Gerrit-Reviewer: Victor Costan <pwn...@chromium.org>
        Gerrit-CC: Adam Barth <aba...@chromium.org>
        Gerrit-CC: Joshua Bell <jsb...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-Comment-Date: Wed, 19 Jul 2017 01:10:14 +0000
        Gerrit-HasComments: No
        Gerrit-HasLabels: Yes

        Michael Nordman (Gerrit)

        unread,
        Jul 20, 2017, 7:17:27 PM7/20/17
        to Victor Costan, blink-...@chromium.org, Commit Bot, Joshua Bell, Adam Barth, chromium...@chromium.org, Kentaro Hara

        Michael Nordman posted comments on this change.

        View Change

        Patch set 1:Code-Review +1

          To view, visit change 576808. To unsubscribe, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: master
          Gerrit-MessageType: comment
          Gerrit-Change-Id: I3f2e1c8b292777e454b5bc641dbe684929ead2a3
          Gerrit-Change-Number: 576808
          Gerrit-PatchSet: 1
          Gerrit-Owner: Victor Costan <pwn...@chromium.org>
          Gerrit-Reviewer: Michael Nordman <mich...@chromium.org>
          Gerrit-Reviewer: Victor Costan <pwn...@chromium.org>
          Gerrit-CC: Adam Barth <aba...@chromium.org>
          Gerrit-CC: Commit Bot <commi...@chromium.org>
          Gerrit-CC: Joshua Bell <jsb...@chromium.org>
          Gerrit-CC: Kentaro Hara <har...@chromium.org>
          Gerrit-Comment-Date: Thu, 20 Jul 2017 23:17:20 +0000
          Gerrit-HasComments: No
          Gerrit-HasLabels: Yes

          Victor Costan (Gerrit)

          unread,
          Jul 20, 2017, 7:21:38 PM7/20/17
          to blink-...@chromium.org, Michael Nordman, Commit Bot, Joshua Bell, Adam Barth, chromium...@chromium.org, Kentaro Hara

          Victor Costan posted comments on this change.

          View Change

          Patch set 1:

          Patch Set 1: Code-Review+1

          michaeln: Thank you very much for the code review!

            To view, visit change 576808. To unsubscribe, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: master
            Gerrit-MessageType: comment
            Gerrit-Change-Id: I3f2e1c8b292777e454b5bc641dbe684929ead2a3
            Gerrit-Change-Number: 576808
            Gerrit-PatchSet: 1
            Gerrit-Owner: Victor Costan <pwn...@chromium.org>
            Gerrit-Reviewer: Michael Nordman <mich...@chromium.org>
            Gerrit-Reviewer: Victor Costan <pwn...@chromium.org>
            Gerrit-CC: Adam Barth <aba...@chromium.org>
            Gerrit-CC: Commit Bot <commi...@chromium.org>
            Gerrit-CC: Joshua Bell <jsb...@chromium.org>
            Gerrit-CC: Kentaro Hara <har...@chromium.org>
            Gerrit-Comment-Date: Thu, 20 Jul 2017 23:21:34 +0000
            Gerrit-HasComments: No
            Gerrit-HasLabels: No

            Victor Costan (Gerrit)

            unread,
            Jul 20, 2017, 7:22:06 PM7/20/17
            to blink-...@chromium.org, Michael Nordman, Commit Bot, Joshua Bell, Adam Barth, chromium...@chromium.org, Kentaro Hara

            Victor Costan posted comments on this change.

            View Change

            Patch set 1:Commit-Queue +2

              To view, visit change 576808. To unsubscribe, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: master
              Gerrit-MessageType: comment
              Gerrit-Change-Id: I3f2e1c8b292777e454b5bc641dbe684929ead2a3
              Gerrit-Change-Number: 576808
              Gerrit-PatchSet: 1
              Gerrit-Owner: Victor Costan <pwn...@chromium.org>
              Gerrit-Reviewer: Michael Nordman <mich...@chromium.org>
              Gerrit-Reviewer: Victor Costan <pwn...@chromium.org>
              Gerrit-CC: Adam Barth <aba...@chromium.org>
              Gerrit-CC: Commit Bot <commi...@chromium.org>
              Gerrit-CC: Joshua Bell <jsb...@chromium.org>
              Gerrit-CC: Kentaro Hara <har...@chromium.org>
              Gerrit-Comment-Date: Thu, 20 Jul 2017 23:21:38 +0000
              Gerrit-HasComments: No
              Gerrit-HasLabels: Yes

              Commit Bot (Gerrit)

              unread,
              Jul 20, 2017, 9:01:22 PM7/20/17
              to Victor Costan, blink-...@chromium.org, Michael Nordman, Joshua Bell, Adam Barth, chromium...@chromium.org, Kentaro Hara

              Commit Bot merged this change.

              View Change

              Approvals: Michael Nordman: Looks good to me Victor Costan: Commit
              Increase the bus factor for WebSQL OWNERS.

              BUG=

              Change-Id: I3f2e1c8b292777e454b5bc641dbe684929ead2a3
              Reviewed-on: https://chromium-review.googlesource.com/576808
              Reviewed-by: Michael Nordman <mich...@chromium.org>
              Commit-Queue: Victor Costan <pwn...@chromium.org>
              Cr-Commit-Position: refs/heads/master@{#488527}
              ---
              M third_party/WebKit/Source/modules/webdatabase/OWNERS
              1 file changed, 5 insertions(+), 0 deletions(-)

              diff --git a/third_party/WebKit/Source/modules/webdatabase/OWNERS b/third_party/WebKit/Source/modules/webdatabase/OWNERS
              index a85c576..edfc0430 100644
              --- a/third_party/WebKit/Source/modules/webdatabase/OWNERS
              +++ b/third_party/WebKit/Source/modules/webdatabase/OWNERS
              @@ -1,4 +1,9 @@
              +# Primary
              mich...@chromium.org

              +# Seconday
              +pwn...@chromium.org
              +jsb...@chromium.org
              +
              # TEAM: stora...@chromium.org
              # COMPONENT: Blink>Storage

              To view, visit change 576808. To unsubscribe, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: master
              Gerrit-MessageType: merged
              Gerrit-Change-Id: I3f2e1c8b292777e454b5bc641dbe684929ead2a3
              Gerrit-Change-Number: 576808
              Gerrit-PatchSet: 2
              Gerrit-Owner: Victor Costan <pwn...@chromium.org>
              Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
              Gerrit-Reviewer: Michael Nordman <mich...@chromium.org>
              Gerrit-Reviewer: Victor Costan <pwn...@chromium.org>
              Gerrit-CC: Adam Barth <aba...@chromium.org>
              Reply all
              Reply to author
              Forward
              0 new messages