Renmae chrome_url_constants.h to chrome_webui_url_constants.h [chromium/src : main]

0 views
Skip to first unread message

Hidehiko Abe (Gerrit)

unread,
12:05 AM (4 hours ago) 12:05 AM
to Jun Ishiguro, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, ajayramamurthy...@google.com, arc-review...@google.com, ashleydp+fe...@google.com, borealis-re...@google.com, cambickel+fe...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-setti...@google.com, dtseng...@chromium.org, francisjp...@google.com, hansberry+wa...@chromium.org, hidehik...@chromium.org, jackshira+wa...@google.com, joeantonetti+...@google.com, jonmann+wat...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, longbowei+fe...@google.com, nektar...@chromium.org, pushi+watc...@google.com, rrsilva+wat...@google.com, tbarzi...@chromium.org, wangdanny+fe...@google.com, xiangdongkong+...@google.com, yhanada+...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com
Attention needed from Jun Ishiguro

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Hidehiko Abe . resolved

PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Jun Ishiguro
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id023c89fb72ce5c736f740996771319c354012a5
Gerrit-Change-Number: 7622793
Gerrit-PatchSet: 1
Gerrit-Owner: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Jun Ishiguro <ju...@google.com>
Gerrit-Comment-Date: Mon, 02 Mar 2026 05:05:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jun Ishiguro (Gerrit)

unread,
12:49 AM (3 hours ago) 12:49 AM
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, ajayramamurthy...@google.com, arc-review...@google.com, ashleydp+fe...@google.com, borealis-re...@google.com, cambickel+fe...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-setti...@google.com, dtseng...@chromium.org, francisjp...@google.com, hansberry+wa...@chromium.org, hidehik...@chromium.org, jackshira+wa...@google.com, joeantonetti+...@google.com, jonmann+wat...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, longbowei+fe...@google.com, nektar...@chromium.org, pushi+watc...@google.com, rrsilva+wat...@google.com, tbarzi...@chromium.org, wangdanny+fe...@google.com, xiangdongkong+...@google.com, yhanada+...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com
Attention needed from Hidehiko Abe

Jun Ishiguro voted and added 1 comment

Votes added by Jun Ishiguro

Code-Review+1

1 comment

Patchset-level comments
Jun Ishiguro . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id023c89fb72ce5c736f740996771319c354012a5
    Gerrit-Change-Number: 7622793
    Gerrit-PatchSet: 1
    Gerrit-Owner: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Mon, 02 Mar 2026 05:48:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hidehiko Abe (Gerrit)

    unread,
    1:24 AM (3 hours ago) 1:24 AM
    to Jun Ishiguro, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, ajayramamurthy...@google.com, arc-review...@google.com, ashleydp+fe...@google.com, borealis-re...@google.com, cambickel+fe...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-setti...@google.com, dtseng...@chromium.org, francisjp...@google.com, hansberry+wa...@chromium.org, hidehik...@chromium.org, jackshira+wa...@google.com, joeantonetti+...@google.com, jonmann+wat...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, longbowei+fe...@google.com, nektar...@chromium.org, pushi+watc...@google.com, rrsilva+wat...@google.com, tbarzi...@chromium.org, wangdanny+fe...@google.com, xiangdongkong+...@google.com, yhanada+...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com

    Hidehiko Abe voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id023c89fb72ce5c736f740996771319c354012a5
    Gerrit-Change-Number: 7622793
    Gerrit-PatchSet: 1
    Gerrit-Owner: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Comment-Date: Mon, 02 Mar 2026 06:23:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    1:26 AM (2 hours ago) 1:26 AM
    to Hidehiko Abe, Jun Ishiguro, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, ajayramamurthy...@google.com, arc-review...@google.com, ashleydp+fe...@google.com, borealis-re...@google.com, cambickel+fe...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-setti...@google.com, dtseng...@chromium.org, francisjp...@google.com, hansberry+wa...@chromium.org, hidehik...@chromium.org, jackshira+wa...@google.com, joeantonetti+...@google.com, jonmann+wat...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, longbowei+fe...@google.com, nektar...@chromium.org, pushi+watc...@google.com, rrsilva+wat...@google.com, tbarzi...@chromium.org, wangdanny+fe...@google.com, xiangdongkong+...@google.com, yhanada+...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Renmae chrome_url_constants.h to chrome_webui_url_constants.h

    To make a room to add a file containing URLs used in Chrome.
    Also, the name is more consistent with other constants files.

    BUG=485470549
    TEST=Tryjob
    Change-Id: Id023c89fb72ce5c736f740996771319c354012a5
    Reviewed-by: Jun Ishiguro <ju...@google.com>
    Commit-Queue: Hidehiko Abe <hide...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1592259}
    Files:
    • M ash/constants/BUILD.gn
    • R ash/constants/chrome_webui_url_constants.h
    • M chrome/browser/ash/login/chrome_restart_request.cc
    • M chrome/browser/ash/login/screens/error_screen.cc
    • M chrome/browser/ash/login/screens/sync_consent_screen.cc
    • M chrome/browser/ash/os_feedback/chrome_os_feedback_delegate.cc
    • M chrome/browser/ash/phonehub/browser_tabs_metadata_fetcher_impl_unittest.cc
    • M chrome/browser/ash/sync/sync_error_notifier.cc
    • M chrome/browser/ash/system_web_apps/apps/os_flags_system_web_app_info.cc
    • M chrome/browser/ash/system_web_apps/apps/os_settings_web_app_info.cc
    • M chrome/browser/ui/ash/arc/arc_open_url_delegate_impl.cc
    • M chrome/browser/ui/ash/desks/chrome_saved_desk_delegate.cc
    • M chrome/browser/ui/ash/new_window/chrome_new_window_client.cc
    • M chrome/browser/ui/views/borealis/borealis_disallowed_dialog.cc
    • M chrome/browser/ui/webui/ash/login/oobe_ui.cc
    • M chrome/browser/ui/webui/ash/settings/pages/a11y/accessibility_handler.cc
    • M chrome/browser/ui/webui/ash/settings/pages/a11y/accessibility_handler_unittest.cc
    • M chrome/browser/ui/webui/ash/settings/pages/about/about_section.cc
    • M chrome/browser/ui/webui/ash/settings/pages/main/main_section.cc
    • M chrome/browser/ui/webui/ash/settings/pages/people/os_sync_handler.cc
    • M chrome/browser/ui/webui/ash/settings/pages/people/os_sync_handler_unittest.cc
    • M chrome/browser/ui/webui/ash/settings/pages/people/people_section.cc
    • M chrome/browser/ui/webui/ash/settings/pages/search/search_engines_handler_unittest.cc
    • M chrome/browser/ui/webui/ash/settings/pages/storage/device_storage_handler.cc
    • M chrome/browser/ui/webui/ash/settings/pages/storage/device_storage_handler_unittest.cc
    • M chrome/common/DEPS
    • M chrome/common/webui_url_constants.cc
    Change size: M
    Delta: 27 files changed, 29 insertions(+), 29 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Jun Ishiguro
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id023c89fb72ce5c736f740996771319c354012a5
    Gerrit-Change-Number: 7622793
    Gerrit-PatchSet: 2
    Gerrit-Owner: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages