SideUi: Ensure thread safety in SideUiCoordinator [chromium/src : main]

0 views
Skip to first unread message

Linyu He (Gerrit)

unread,
Jun 24, 2026, 9:23:34 PM (7 days ago) Jun 24
to Neil Coronado, Moe Adel, chromium...@chromium.org, Charles Hager, Mark Schillaci, Shu Yang, Sinan Sahin, nemco...@google.com
Attention needed from Neil Coronado

Linyu He voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Neil Coronado
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8c48b21b9ab69cb9bc58cff9960e4908b91fa7fa
Gerrit-Change-Number: 7997865
Gerrit-PatchSet: 1
Gerrit-Owner: Linyu He <lin...@google.com>
Gerrit-Reviewer: Linyu He <lin...@google.com>
Gerrit-Reviewer: Neil Coronado <ne...@google.com>
Gerrit-CC: Charles Hager <clh...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Moe Adel <ad...@google.com>
Gerrit-CC: Shu Yang <shu...@google.com>
Gerrit-CC: Sinan Sahin <sinan...@google.com>
Gerrit-Attention: Neil Coronado <ne...@google.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 01:23:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Neil Coronado (Gerrit)

unread,
Jun 24, 2026, 9:30:06 PM (7 days ago) Jun 24
to Linyu He, Chromium LUCI CQ, Moe Adel, chromium...@chromium.org, Charles Hager, Mark Schillaci, Shu Yang, Sinan Sahin, nemco...@google.com
Attention needed from Linyu He

Neil Coronado voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Linyu He
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8c48b21b9ab69cb9bc58cff9960e4908b91fa7fa
    Gerrit-Change-Number: 7997865
    Gerrit-PatchSet: 1
    Gerrit-Owner: Linyu He <lin...@google.com>
    Gerrit-Reviewer: Linyu He <lin...@google.com>
    Gerrit-Reviewer: Neil Coronado <ne...@google.com>
    Gerrit-CC: Charles Hager <clh...@google.com>
    Gerrit-CC: Mark Schillaci <mschi...@google.com>
    Gerrit-CC: Moe Adel <ad...@google.com>
    Gerrit-CC: Shu Yang <shu...@google.com>
    Gerrit-CC: Sinan Sahin <sinan...@google.com>
    Gerrit-Attention: Linyu He <lin...@google.com>
    Gerrit-Comment-Date: Thu, 25 Jun 2026 01:29:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Linyu He (Gerrit)

    unread,
    Jun 24, 2026, 10:05:25 PM (7 days ago) Jun 24
    to Neil Coronado, Chromium LUCI CQ, Moe Adel, chromium...@chromium.org, Charles Hager, Mark Schillaci, Shu Yang, Sinan Sahin, nemco...@google.com

    Linyu He voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8c48b21b9ab69cb9bc58cff9960e4908b91fa7fa
    Gerrit-Change-Number: 7997865
    Gerrit-PatchSet: 1
    Gerrit-Owner: Linyu He <lin...@google.com>
    Gerrit-Reviewer: Linyu He <lin...@google.com>
    Gerrit-Reviewer: Neil Coronado <ne...@google.com>
    Gerrit-CC: Charles Hager <clh...@google.com>
    Gerrit-CC: Mark Schillaci <mschi...@google.com>
    Gerrit-CC: Moe Adel <ad...@google.com>
    Gerrit-CC: Shu Yang <shu...@google.com>
    Gerrit-CC: Sinan Sahin <sinan...@google.com>
    Gerrit-Comment-Date: Thu, 25 Jun 2026 02:05:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 24, 2026, 10:25:43 PM (7 days ago) Jun 24
    to Linyu He, Neil Coronado, Moe Adel, chromium...@chromium.org, Charles Hager, Mark Schillaci, Shu Yang, Sinan Sahin, nemco...@google.com

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    SideUi: Ensure thread safety in SideUiCoordinator

    SideUiCoordinator has mutable states, so we need to ensure thread
    safety.

    Since it's a UI compoenent, a simple and effective way is to guard all
    public methods with ThreadUtils.assertOnUiThread().

    A subsequent CL will also prevent same-thread re-entrancy bugs. For
    example, during updateUi(), a SideUiContainer shouldn't call updateUi()
    again. This requires a new mutable state (such as mIsUpdatingUi), so
    this CL makes sure all mutable states are only updated in the UI thread.
    Include-Ci-Only-Tests: true
    Bug: 478338737
    Change-Id: I8c48b21b9ab69cb9bc58cff9960e4908b91fa7fa
    Reviewed-by: Neil Coronado <ne...@google.com>
    Commit-Queue: Linyu He <lin...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1652134}
    Files:
    • M chrome/browser/ui/side_ui/internal/android/java/src/org/chromium/chrome/browser/ui/side_ui/SideUiCoordinatorImpl.java
    Change size: S
    Delta: 1 file changed, 11 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Neil Coronado
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8c48b21b9ab69cb9bc58cff9960e4908b91fa7fa
    Gerrit-Change-Number: 7997865
    Gerrit-PatchSet: 3
    Gerrit-Owner: Linyu He <lin...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Linyu He <lin...@google.com>
    Gerrit-Reviewer: Neil Coronado <ne...@google.com>
    Gerrit-CC: Charles Hager <clh...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages