Fix issue where may_throttle_if_undrawn_frames not synced in TreesInViz [chromium/src : main]

0 views
Skip to first unread message

Sky Debreuil (Gerrit)

unread,
Dec 12, 2025, 9:24:25 PM (4 days ago) Dec 12
to Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org
Attention needed from Jonathan Ross

Sky Debreuil voted and added 1 comment

Votes added by Sky Debreuil

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Sky Debreuil . resolved

The `may_throttle_if_undrawn_frames` flag was not correctly synchronizing when running in the TreesInViz configuration.

I validated this fix using YouTube in Picture-in-Picture mode, which sets `may_throttle_if_undrawn_frames` to false. I verified that the flag now syncs correctly, and I also confirmed the negative case by running without these changes applied (where the flag failed to sync).

Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5c983cef5a39d2b0c6a0992d56e1a2d57af2375d
Gerrit-Change-Number: 7251449
Gerrit-PatchSet: 8
Gerrit-Owner: Sky Debreuil <skyde...@google.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Sky Debreuil <skyde...@google.com>
Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
Gerrit-Comment-Date: Sat, 13 Dec 2025 02:24:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sky Debreuil (Gerrit)

unread,
Dec 12, 2025, 9:26:33 PM (4 days ago) Dec 12
to Chromium IPC Reviews, Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org
Attention needed from Chromium IPC Reviews and Jonathan Ross

Sky Debreuil voted and added 1 comment

Votes added by Sky Debreuil

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Sky Debreuil . resolved

For the Chromium IPC Reviewer - please review only this file:
`services/viz/public/mojom/compositing/layer_context.mojom`

Thanks! 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Chromium IPC Reviews
  • Jonathan Ross
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5c983cef5a39d2b0c6a0992d56e1a2d57af2375d
Gerrit-Change-Number: 7251449
Gerrit-PatchSet: 9
Gerrit-Owner: Sky Debreuil <skyde...@google.com>
Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Sky Debreuil <skyde...@google.com>
Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Comment-Date: Sat, 13 Dec 2025 02:26:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Dec 12, 2025, 9:31:50 PM (4 days ago) Dec 12
to Sky Debreuil, Chromium IPC Reviews, Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org
Attention needed from Joe Mason and Jonathan Ross

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: joenot...@google.com

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): joenot...@google.com


Reviewer source(s):
joenot...@google.com is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
  • Jonathan Ross
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5c983cef5a39d2b0c6a0992d56e1a2d57af2375d
Gerrit-Change-Number: 7251449
Gerrit-PatchSet: 9
Gerrit-Owner: Sky Debreuil <skyde...@google.com>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Sky Debreuil <skyde...@google.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
Gerrit-Attention: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Sat, 13 Dec 2025 02:31:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jonathan Ross (Gerrit)

unread,
Dec 15, 2025, 2:58:40 PM (19 hours ago) Dec 15
to Sky Debreuil, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org
Attention needed from Joe Mason and Sky Debreuil

Jonathan Ross voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
  • Sky Debreuil
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5c983cef5a39d2b0c6a0992d56e1a2d57af2375d
    Gerrit-Change-Number: 7251449
    Gerrit-PatchSet: 9
    Gerrit-Owner: Sky Debreuil <skyde...@google.com>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Sky Debreuil <skyde...@google.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Sky Debreuil <skyde...@google.com>
    Gerrit-Attention: Joe Mason <joenot...@google.com>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 19:58:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages