diagnostics: stop routines on blocking failure to preserve details [chromium/src : main]
0 views
Skip to first unread message
Maksim Sisov (Gerrit)
Apr 9, 2026, 10:24:20 AM (5 days ago) Apr 9
to Byron Lee, Chromium LUCI CQ, chromium...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, menghua...@google.com, oshima...@chromium.org, weiluanw...@google.com
Attention needed from Byron Lee
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Byron Lee
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Byron Lee (Gerrit)
4:44 AM (7 hours ago) 4:44 AM
to Maksim Sisov, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, menghua...@google.com, oshima...@chromium.org, weiluanw...@google.com
Attention needed from Maksim Sisov
Byron Lee voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Maksim Sisov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Sisov (Gerrit)
4:56 AM (7 hours ago) 4:56 AM
to Byron Lee, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, menghua...@google.com, oshima...@chromium.org, weiluanw...@google.com
Maksim Sisov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
5:52 AM (6 hours ago) 5:52 AM
to Maksim Sisov, Byron Lee, chromium...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, menghua...@google.com, oshima...@chromium.org, weiluanw...@google.com
chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
diagnostics: stop routines on blocking failure to preserve details
When a blocking routine fails, routine_result_list correctly marks
remaining groups as SKIPPED. However, routine_section keeps processing
subsequent routine completions from the executor, overwriting
lastRoutineDetails with null and destroying the failed routine's
error details.
Fix: have onStatusUpdate return a boolean signaling blocking failure.
When routine_section receives this signal, it sets
ignoreRoutineStatusUpdates to stop processing further updates, cancels
the executor, and breaks out of the routine group for-loop.
Bug: 463098734
Change-Id: I83f3b815f1fe51e7c531c2d9b49e459c218e020f
Commit-Queue: Maksim Sisov <msi...@igalia.com>
Reviewed-by: Byron Lee <byro...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1614343}
Files:
- M ash/webui/diagnostics_ui/resources/routine_result_list.ts
- M ash/webui/diagnostics_ui/resources/routine_section.ts
- M chrome/test/data/webui/chromeos/diagnostics/routine_result_list_test.ts
- M chrome/test/data/webui/chromeos/diagnostics/routine_section_test.ts
Change size: M
Delta: 4 files changed, 183 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Byron Lee
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages