Autofill: Add name and label fields to autocomplete search result [chromium/src : main]
0 views
Skip to first unread message
Stanislav Mikheyev (Gerrit)
Jul 20, 2026, 12:13:06 PM (21 hours ago) Jul 20
to Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, browser-comp...@chromium.org
Stanislav Mikheyev added 1 comment![]( "Open in Gerrit")
File components/autofill/core/browser/webdata/autocomplete/autocomplete_table_label_sensitive_unittest.cc
Line 544, Patchset 4:
auto field1Value = optional_field1.value().value();Jan Keitel . resolved
Stanislav MikheyevPlease don't use `auto` - it's not obvious to infer the type from the RHS.
Same comment below.
Also, consider using `optional_field1->value()`.
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stanislav Mikheyev (Gerrit)
Jul 20, 2026, 12:22:17 PM (21 hours ago) Jul 20
to Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, browser-comp...@chromium.org
Stanislav Mikheyev voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 20, 2026, 1:09:40 PM (20 hours ago) Jul 20
to Stanislav Mikheyev, Jan Keitel, chromium...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, browser-comp...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: components/autofill/core/browser/webdata/autocomplete/autocomplete_table_label_sensitive.h
Insertions: 8, Deletions: 3.
@@ -17,6 +17,7 @@
#include <type_traits>
#include <vector>
+#include "base/compiler_specific.h"
#include "base/time/time.h"
#include "components/autofill/core/browser/webdata/autocomplete/autocomplete_entry_label_sensitive.h"
#include "components/autofill/core/common/form_field_data.h"
@@ -66,10 +67,14 @@
AutocompleteSearchResultLabelSensitive&& other);
// Getters
- const std::u16string& value() const { return value_; }
+ const std::u16string& value() const LIFETIME_BOUND { return value_; }
MatchingType matching_type() const { return matching_type_; }
- const std::u16string& query_name() const { return query_name_; }
- const std::u16string& query_label() const { return query_label_; }
+ const std::u16string& query_name() const LIFETIME_BOUND {
+ return query_name_;
+ }
+ const std::u16string& query_label() const LIFETIME_BOUND {
+ return query_label_;
+ }
int count() const { return count_; }
bool operator==(const AutocompleteSearchResultLabelSensitive& other) const {
```
```
The name of the file: components/autofill/core/browser/webdata/autocomplete/autocomplete_table_label_sensitive_unittest.cc
Insertions: 10, Deletions: 15.
@@ -541,22 +541,17 @@
kDefaultName, kDefaultLabel, /*prefix=*/u"clark k", /*limit=*/10,
entries_narrowed_down));
- auto field1Value = optional_field1.value().value();
- auto field2Value = optional_field2.value().value();
-
- auto field1Name = optional_field1.value().name();
- auto field2Name = optional_field2.value().name();
-
- auto field1Label = optional_field1.value().label();
- auto field2Label = optional_field2.value().label();
-
- EXPECT_THAT(entries,
- UnorderedElementsAre(
- EqualsSearchResult(field1Value, field1Name, field1Label, 1),
- EqualsSearchResult(field2Value, field2Name, field2Label, 1)));
EXPECT_THAT(
- entries_narrowed_down,
- ElementsAre(EqualsSearchResult(field1Value, field1Name, field1Label, 1)));
+ entries,
+ UnorderedElementsAre(
+ EqualsSearchResult(optional_field1->value(), optional_field1->name(),
+ optional_field1->label(), 1),
+ EqualsSearchResult(optional_field2->value(), optional_field2->name(),
+ optional_field2->label(), 1)));
+ EXPECT_THAT(entries_narrowed_down,
+ ElementsAre(EqualsSearchResult(optional_field1->value(),
+ optional_field1->name(),
+ optional_field1->label(), 1)));
}
// GetFormValuesForElementNameAndLabel normalizes the label before querying the
```
Change information
Commit message:
Autofill: Add name and label fields to autocomplete search result
These fields will be needed to call OnRemoveCurrentSingleFieldSuggestion
in AutofillExternalDelegate::RemoveSuggestion.
Bug: b:346507576
Change-Id: I2dd9af348f50f3826856d3ad9560c06ea6a9c985
Reviewed-by: Jan Keitel <jke...@google.com>
Commit-Queue: Stanislav Mikheyev <mi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1664773}
Files:
- M components/autofill/core/browser/webdata/autocomplete/autocomplete_table_label_sensitive.cc
- M components/autofill/core/browser/webdata/autocomplete/autocomplete_table_label_sensitive.h
- M components/autofill/core/browser/webdata/autocomplete/autocomplete_table_label_sensitive_unittest.cc
Change size: M
Delta: 3 files changed, 83 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jan Keitel
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages