Add scaffold for DataType::CONTEXTUAL_TASK [chromium/src : main]
0 views
Skip to first unread message
Maksim Moskvitin (Gerrit)
Sep 23, 2025, 7:12:40 AM (3 days ago) Sep 23
to Min Qin, Tommy Nyquist, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Min Qin and Tommy Nyquist
Maksim Moskvitin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Maksim Moskvitin . unresolved
This is going to conflict with your another CL (https://chromium-review.googlesource.com/c/chromium/src/+/6969137)
Related details
Attention is currently required from:
- Min Qin
- Tommy Nyquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Min Qin (Gerrit)
Sep 23, 2025, 7:10:30 PM (3 days ago) Sep 23
to Ankush Singh, Tommy Nyquist, Maksim Moskvitin, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ankush Singh, Maksim Moskvitin and Tommy Nyquist
Min Qin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
This is going to conflict with your another CL (https://chromium-review.googlesource.com/c/chromium/src/+/6969137)
Min Qin
This CL has been updated so it can be patched after https://chromium-review.googlesource.com/c/chromium/src/+/6969137.
however, that CL just got reverted, so I need to also reland it first.
Related details
Attention is currently required from:
- Ankush Singh
- Maksim Moskvitin
- Tommy Nyquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ankush Singh (Gerrit)
Sep 25, 2025, 12:30:31 PM (yesterday) Sep 25
to Min Qin, Tommy Nyquist, Maksim Moskvitin, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Maksim Moskvitin, Min Qin and Tommy Nyquist
Ankush Singh voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ankush Singh
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Maksim Moskvitin
- Min Qin
- Tommy Nyquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Min Qin (Gerrit)
Sep 25, 2025, 3:39:10 PM (yesterday) Sep 25
to Chromium LUCI CQ, Ankush Singh, Tommy Nyquist, Maksim Moskvitin, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Maksim Moskvitin and Tommy Nyquist
Min Qin added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Maksim Moskvitin
- Tommy Nyquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Nyquist (Gerrit)
Sep 25, 2025, 5:38:42 PM (yesterday) Sep 25
to Min Qin, Chromium LUCI CQ, Ankush Singh, Maksim Moskvitin, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Maksim Moskvitin and Min Qin
Tommy Nyquist voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tommy Nyquist
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tommy Nyquist . resolved
lgtm.
Please remember to look into transport mode for this data type as well.
Related details
Attention is currently required from:
- Maksim Moskvitin
- Min Qin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Moskvitin (Gerrit)
8:00 AM (11 hours ago) 8:00 AM
to Min Qin, Tommy Nyquist, Chromium LUCI CQ, Ankush Singh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Min Qin
Maksim Moskvitin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maksim Moskvitin
| Code-Review | +1 |
1 comment
Patchset-level comments
Maksim Moskvitin . resolved
histograms lgtm, relying on Ankush's review for the rest
Related details
Attention is currently required from:
- Min Qin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Min Qin (Gerrit)
11:52 AM (7 hours ago) 11:52 AM
to Maksim Moskvitin, Tommy Nyquist, Chromium LUCI CQ, Ankush Singh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Min Qin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:56 AM (7 hours ago) 11:56 AM
to Min Qin, Maksim Moskvitin, Tommy Nyquist, Ankush Singh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add scaffold for DataType::CONTEXTUAL_TASK
Adds the new DataType enum value and an empty specifics proto.
Generated from components/sync/bootstrap_new_data_type.sh.
Note to sync reviewer: please verify for every touched static_assert(),
the change is fitting or has a corresponding TODO.
Bug: 445840788
Change-Id: Ic08c3274022941f2d169adb0c0bf3dbf6e99246f
Reviewed-by: Ankush Singh <ankus...@google.com>
Reviewed-by: Tommy Nyquist <nyq...@chromium.org>
Reviewed-by: Maksim Moskvitin <mmosk...@google.com>
Commit-Queue: Min Qin <qin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1521329}
Files:
- M chrome/browser/sync/sync_service_factory_unittest.cc
- M chrome/browser/sync/test/integration/BUILD.gn
- M chrome/browser/sync/test/integration/sync_test.cc
- M components/browser_sync/common_controller_builder.cc
- M components/sync/base/data_type.cc
- M components/sync/base/data_type.h
- M components/sync/base/features.cc
- M components/sync/base/features.h
- M components/sync/base/user_selectable_type.cc
- M components/sync/base/user_selectable_type_unittest.cc
- M components/sync/engine/cycle/data_type_tracker.cc
- A components/sync/protocol/contextual_task_specifics.proto
- M components/sync/protocol/entity_specifics.proto
- M components/sync/protocol/proto_value_conversions_unittest.cc
- M components/sync/protocol/proto_visitors.h
- M components/sync/protocol/protocol_sources.gni
- M components/sync/service/sync_user_settings_impl.cc
- M components/sync/service/sync_user_settings_impl_unittest.cc
- M ios/chrome/browser/sync/model/sync_service_factory_unittest.mm
- M tools/metrics/histograms/metadata/sync/enums.xml
- M tools/metrics/histograms/metadata/sync/histograms.xml
Change size: M
Delta: 21 files changed, 119 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tommy Nyquist, +1 by Ankush Singh, +1 by Maksim Moskvitin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages