flyout: Fix state inconsistency on flyout dismissal [chromium/src : main]
0 views
Skip to first unread message
Masa Fujita (Gerrit)
4:14 AM (10 hours ago) 4:14 AM
to chromium...@chromium.org, peilinwa...@google.com, chromium-a...@chromium.org, hanxi...@chromium.org, extension...@chromium.org
Masa Fujita has uploaded the change for review![]( "Open in Gerrit")
Commit message
flyout: Fix state inconsistency on flyout dismissal
Previously, when a flyout popup was dismissed by an external action
(e.g., pressing Escape), the component's internal list of popups
(`mPopupMenus`) was not updated. This led to state inconsistencies.
This CL introduces an `OnDismissListener` to correctly remove the
popup's entry from the list upon dismissal.
To prevent this new listener from causing a recursive loop during
programmatic dismissals (where `removeFlyoutWindows` calls `dismiss`), a
state guard (`mRemovingPopups`) has been added to the
dismissal logic.
Bug: 447103380
Change-Id: I7f0e3212a0228cdd512055d051e0a033006ada5c
Change diff
Change information
Files:
- M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinator.java
- M components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/ContextMenuDialog.java
- M ui/android/java/src/org/chromium/ui/listmenu/ListMenuFlyoutController.java
- M ui/android/java/src/org/chromium/ui/listmenu/ListMenuHost.java
Change size: M
Delta: 4 files changed, 56 insertions(+), 19 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Masa Fujita (Gerrit)
5:43 AM (8 hours ago) 5:43 AM
to AJITH KUMAR V, AJITH KUMAR V, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
Masa Fujita voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Masa Fujita (Gerrit)
7:22 AM (7 hours ago) 7:22 AM
to Chromium LUCI CQ, AJITH KUMAR V, AJITH KUMAR V, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
Masa Fujita voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Masa Fujita (Gerrit)
8:07 AM (6 hours ago) 8:07 AM
to Chromium LUCI CQ, AJITH KUMAR V, AJITH KUMAR V, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
Masa Fujita voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Masa Fujita (Gerrit)
12:05 PM (2 hours ago) 12:05 PM
to Sinan Sahin, Chromium LUCI CQ, AJITH KUMAR V, AJITH KUMAR V, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
Attention needed from Sinan Sahin
Masa Fujita voted and added 1 comment![]( "Open in Gerrit")
Votes added by Masa Fujita
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Sinan Sahin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages