Roll clang+rust llvmorg-23-init-5669-g8a0be0bc-4 : llvmorg-23-init-10931-g20b6ec66-1 / 6f54d591c3116ee7f8ce9321ddeca286810cc142-7 : 4c4205163abcbd08948b3efab796c543ba1ea687-1 [chromium/src : main]

0 views
Skip to first unread message

Hans Wennborg (Gerrit)

unread,
6:39 AM (2 hours ago) 6:39 AM
to Hans Wennborg, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Ilya Biryukov, Peter Collingbourne, Reid Kleckner, Lei Zhang, chromium-...@engflow.com, eugeni...@chromium.org, glider...@chromium.org, ukai+...@chromium.org
Attention needed from Nico Weber

Hans Wennborg voted and added 1 comment

Votes added by Hans Wennborg

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Hans Wennborg . resolved

I think this is looking pretty good.

Failures:

android-arm32-pgo - green on PS2
android-arm64-rel - red on whitespace
linux-pgo - different benchmark failing on differen patchsets - flaky
win64-pgo - green on PS2
win-swangle-try-x86 - green on PS2


Still running:

linux-chromeos-dbg - green on PS2
win-arm64-rel - green on PS2
win-asan - red on whitespace
android-16-x64-dbg - too slow? whitespace: https://ci.chromium.org/ui/p/chromium/builders/try/android-16-x64-dbg/1209/overview
win-official - green on PS2
win32-official - green on PS2

(whitespace CL: https://crrev.com/c/7747884)

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4ebc98b0b062afc65a5a6e026e6fcc8a0f6225f6
Gerrit-Change-Number: 7743050
Gerrit-PatchSet: 4
Gerrit-Owner: Hans Wennborg <ha...@chromium.org>
Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Ilya Biryukov <ibir...@google.com>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Peter Collingbourne <p...@chromium.org>
Gerrit-CC: Reid Kleckner <r...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Apr 2026 10:39:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nico Weber (Gerrit)

unread,
7:14 AM (1 hour ago) 7:14 AM
to Hans Wennborg, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Ilya Biryukov, Peter Collingbourne, Reid Kleckner, Lei Zhang, chromium-...@engflow.com, eugeni...@chromium.org, glider...@chromium.org, ukai+...@chromium.org
Attention needed from Hans Wennborg

Nico Weber voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Hans Wennborg
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4ebc98b0b062afc65a5a6e026e6fcc8a0f6225f6
    Gerrit-Change-Number: 7743050
    Gerrit-PatchSet: 4
    Gerrit-Owner: Hans Wennborg <ha...@chromium.org>
    Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Ilya Biryukov <ibir...@google.com>
    Gerrit-CC: Lei Zhang <the...@chromium.org>
    Gerrit-CC: Peter Collingbourne <p...@chromium.org>
    Gerrit-CC: Reid Kleckner <r...@chromium.org>
    Gerrit-Attention: Hans Wennborg <ha...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 11:14:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hans Wennborg (Gerrit)

    unread,
    7:47 AM (1 hour ago) 7:47 AM
    to Hans Wennborg, Nico Weber, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Ilya Biryukov, Peter Collingbourne, Reid Kleckner, Lei Zhang, chromium-...@engflow.com, eugeni...@chromium.org, glider...@chromium.org, ukai+...@chromium.org
    Attention needed from Nico Weber

    Hans Wennborg voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nico Weber
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4ebc98b0b062afc65a5a6e026e6fcc8a0f6225f6
    Gerrit-Change-Number: 7743050
    Gerrit-PatchSet: 4
    Gerrit-Owner: Hans Wennborg <ha...@chromium.org>
    Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Ilya Biryukov <ibir...@google.com>
    Gerrit-CC: Lei Zhang <the...@chromium.org>
    Gerrit-CC: Peter Collingbourne <p...@chromium.org>
    Gerrit-CC: Reid Kleckner <r...@chromium.org>
    Gerrit-Attention: Nico Weber <tha...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 11:46:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hans Wennborg (Gerrit)

    unread,
    8:11 AM (10 minutes ago) 8:11 AM
    to Hans Wennborg, Nico Weber, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Ilya Biryukov, Peter Collingbourne, Reid Kleckner, Lei Zhang, chromium-...@engflow.com, eugeni...@chromium.org, glider...@chromium.org, ukai+...@chromium.org
    Attention needed from Nico Weber

    Hans Wennborg added 1 comment

    Patchset-level comments
    Hans Wennborg . resolved

    I believe all the cq failures are accounted for (see above), so I think it's time for the Submit button.

    Gerrit-Comment-Date: Mon, 13 Apr 2026 12:11:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Hans Wennborg (Gerrit)

    unread,
    8:12 AM (9 minutes ago) 8:12 AM
    to Hans Wennborg, Nico Weber, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, Ilya Biryukov, Peter Collingbourne, Reid Kleckner, Lei Zhang, chromium-...@engflow.com, eugeni...@chromium.org, glider...@chromium.org, ukai+...@chromium.org

    Hans Wennborg submitted the change

    Change information

    Commit message:
    Roll clang+rust llvmorg-23-init-5669-g8a0be0bc-4 : llvmorg-23-init-10931-g20b6ec66-1 / 6f54d591c3116ee7f8ce9321ddeca286810cc142-7 : 4c4205163abcbd08948b3efab796c543ba1ea687-1

    https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8a0be0bc..20b6ec66

    https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/6f54d591c311..4c4205163abc

    Ran: ./tools/clang/scripts/upload_revision.py 20b6ec66967ac2a8f932863c1abf251e5b17a843
    Bug: 489437895
    Change-Id: I4ebc98b0b062afc65a5a6e026e6fcc8a0f6225f6
    Disable-Rts: True
    Include-Ci-Only-Tests: true
    Binary-Size: Compiler change to be investigated
    Cq-Include-Trybots: chromium/try:android-16-x64-dbg
    Cq-Include-Trybots: chromium/try:android-cronet-riscv64-dbg
    Cq-Include-Trybots: chromium/try:android-cronet-riscv64-rel
    Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
    Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
    Cq-Include-Trybots: chromium/try:fuchsia-arm64-cast-receiver-rel
    Cq-Include-Trybots: chromium/try:gpu-fyi-try-mac-intel-asan
    Cq-Include-Trybots: chromium/try:ios-catalyst,win-asan,android-official
    Cq-Include-Trybots: chromium/try:linux-cast-x64-rel
    Cq-Include-Trybots: chromium/try:linux-chromeos-dbg
    Cq-Include-Trybots: chromium/try:linux-swangle-try-x64,win-swangle-try-x86
    Cq-Include-Trybots: chromium/try:linux-v4l2-codec-rel
    Cq-Include-Trybots: chromium/try:linux-wayland-mutter-rel
    Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
    Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
    Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
    Cq-Include-Trybots: chromium/try:mac-official,linux-official
    Cq-Include-Trybots: chromium/try:mac12-arm64-rel,mac_chromium_asan_rel_ng
    Cq-Include-Trybots: chromium/try:win-arm64-rel
    Cq-Include-Trybots: chromium/try:win-official,win32-official
    Cq-Include-Trybots: chrome/try:android-arm32-pgo,android-arm64-pgo
    Cq-Include-Trybots: chrome/try:android-x64-rel-ready
    Cq-Include-Trybots: chrome/try:chromeos-brya-chrome,chromeos-eve-chrome
    Cq-Include-Trybots: chrome/try:chromeos-volteer-chrome
    Cq-Include-Trybots: chrome/try:iphone-device,ipad-device
    Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
    Cq-Include-Trybots: chrome/try:linux-pgo,mac-pgo,win32-pgo,win64-pgo
    Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,linux-chrome,mac-chrome
    Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
    Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
    Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
    Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
    Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
    Cq-Include-Trybots: chromium/try:mac-rust-x64-dbg
    Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
    Cq-Include-Trybots: chromium/try:win-rust-x64-rel
    Reviewed-by: Nico Weber <tha...@chromium.org>
    Commit-Queue: Hans Wennborg <ha...@chromium.org>
    Auto-Submit: Hans Wennborg <ha...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1613635}
    Files:
    • M DEPS
    • M build/config/compiler/BUILD.gn
    • M build/rust/std/rules/BUILD.gn
    • M tools/clang/plugins/UnsafeBuffersPlugin.cpp
    • M tools/clang/scripts/update.py
    • M tools/rust/build_rust.py
    • M tools/rust/update_rust.py
    Change size: XL
    Delta: 7 files changed, 521 insertions(+), 486 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Nico Weber
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4ebc98b0b062afc65a5a6e026e6fcc8a0f6225f6
    Gerrit-Change-Number: 7743050
    Gerrit-PatchSet: 5
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages