Add view animation restart function [chromium/src : main]
0 views
Skip to first unread message
gwsq (Gerrit)
Jan 8, 2026, 2:03:10 AM (3 days ago) Jan 8
to Bingo li, Chromium UI Views Reviews, Allen Bauer, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Allen Bauer
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
kyl...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ui/views/config.gwsq)
Related details
Attention is currently required from:
- Allen Bauer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Allen Bauer (Gerrit)
Jan 8, 2026, 1:32:31 PM (2 days ago) Jan 8
to Bingo li, Chromium LUCI CQ, Chromium UI Views Reviews, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Bingo li
Allen Bauer added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File ui/views/examples/animation_example.cc
Line 189, Patchset 3 (Latest):
squares_container_ = squares_container;Allen Bauer . unresolved
Just use this field directly above. No need for the local temp now that the field is on the class instance.
Related details
Attention is currently required from:
- Bingo li
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bingo li (Gerrit)
Jan 8, 2026, 9:16:44 PM (2 days ago) Jan 8
to Chromium LUCI CQ, Chromium UI Views Reviews, Allen Bauer, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Allen Bauer
Bingo li added 1 comment![]( "Open in Gerrit")
File ui/views/examples/animation_example.cc
Just use this field directly above. No need for the local temp now that the field is on the class instance.
Attention is currently required from:
- Allen Bauer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Allen Bauer (Gerrit)
Jan 9, 2026, 12:57:23 PM (yesterday) Jan 9
to Bingo li, Chromium LUCI CQ, Chromium UI Views Reviews, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Bingo li
Allen Bauer voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Bingo li
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
hewro (Gerrit)
Jan 9, 2026, 9:06:04 PM (19 hours ago) Jan 9
to Bingo li, Allen Bauer, Chromium LUCI CQ, Chromium UI Views Reviews, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Bingo li
hewro voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Bingo li
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 10:04:52 PM (18 hours ago) Jan 9
to Bingo li, hewro, Allen Bauer, Chromium UI Views Reviews, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add view animation restart function
Existing view animation examples only check the abort function, not the
restart one. I need to test this feature, so I added this test case.
This is also a use case for the following fix：
https://chromium-review.googlesource.com/c/chromium/src/+/7362208
Fixed: 474204744
Change-Id: I448fe020520f0027a092aaa6963acded9825891e
Reviewed-by: Allen Bauer <kyl...@chromium.org>
Reviewed-by: hewro <ihe...@chromium.org>
Commit-Queue: Bingo li <bingol...@gmail.com>
Commit-Queue: hewro <ihe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567336}
Files:
- M ui/views/examples/animation_example.cc
- M ui/views/examples/animation_example.h
- M ui/views/examples/views_examples_resources.grd
Change size: M
Delta: 3 files changed, 59 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Allen Bauer, +1 by hewro
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages