Sky Malice (Gerrit)

unread,

12:51 PM (9 hours ago) 12:51 PM

to Patrick Noland, Chromium LUCI CQ, chromium...@chromium.org, ender...@chromium.org

Attention needed from Patrick Noland

Sky Malice voted and added 1 comment

Votes added by Sky Malice

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Sky Malice . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Patrick Noland

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Patrick Noland (Gerrit)

unread,

6:26 PM (3 hours ago) 6:26 PM

to Sky Malice, Chromium LUCI CQ, chromium...@chromium.org, ender...@chromium.org

Attention needed from Sky Malice

Patrick Noland voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Sky Malice

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

6:38 PM (3 hours ago) 6:38 PM

to Sky Malice, Patrick Noland, chromium...@chromium.org, ender...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[AIM] Preserve AutocompleteState through tab switch.

AutocompleteState is set to ENABLED in the constructor and reset of
AutocompleteInput. This is convenient for creating new objects to pass
to beginInput(), but is the opposite of what we want to do when
deactivated (unfocus). Now that this is manually overriding the state,
we can trust the state when switching back to a tab. Some location bar
mediator logic needed to be updated to account for not getting ENABLED
states automatically now.

The functional difference is when you tab tab to an existing NTP, it's
correctly tracking the difference between STANDBY and DISABLED.

Bug: 522911537, 529854485, 526655008

Change-Id: I67e8e473271faab56d8cd7fe88d5324922648bf5

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8065607

Reviewed-by: Patrick Noland <pno...@chromium.org>

Commit-Queue: Sky Malice <sk...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1659102}

Files:

M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/FuseboxSessionState.java
M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/FuseboxSessionStateUnitTest.java
M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediator.java
M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediatorTest.java

Change size: M

Delta: 4 files changed, 67 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Patrick Noland

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[AIM] Preserve AutocompleteState through tab switch. [chromium/src : main]

Sky Malice (Gerrit)

Sky Malice voted and added 1 comment

Votes added by Sky Malice

1 comment

Related details

Patrick Noland (Gerrit)

Patrick Noland voted Code-Review+1

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information