Revert "Creates unit test for NativePageNavigationDelegateImpl" [chromium/src : main]

0 views
Skip to first unread message

Peilin Wang (Gerrit)

unread,
Jan 9, 2026, 6:21:38 PM (22 hours ago) Jan 9
to Joel Tan-Aristy, Shu Yang, Chromium LUCI CQ, Wenyu Fu, chromium...@chromium.org

Peilin Wang has uploaded the change for review

Peilin Wang would like Joel Tan-Aristy, Shu Yang, Chromium LUCI CQ and Wenyu Fu to review this change.

Commit message

Revert "Creates unit test for NativePageNavigationDelegateImpl"

This reverts commit d843cc2bc7af0b26b61a2291c3bca41bbc767733.

Reason for revert: multiple bots are failing because of testOpenUrl_newWindow_incognitoWindowingEnabled

Original change's description:
> Creates unit test for NativePageNavigationDelegateImpl
>
> Bug: 474131693
> Change-Id: Ida9e75e23ee48bd0a85af778a6dfdacff0c602c1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7411420
> Reviewed-by: Shu Yang <shu...@google.com>
> Commit-Queue: Joel Tan-Aristy <jtana...@google.com>
> Reviewed-by: Wenyu Fu <wen...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1567112}
Bug: 474131693
Change-Id: Ia64f407fe80eb232303ab8d503929043be484bb6

Change diff


Change information

Files:
  • M chrome/android/javatests/BUILD.gn
  • D chrome/android/javatests/src/org/chromium/chrome/browser/native_page/NativePageNavigationDelegateImplUnitTest.java
Change size: M
Delta: 2 files changed, 0 insertions(+), 154 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia64f407fe80eb232303ab8d503929043be484bb6
Gerrit-Change-Number: 7426087
Gerrit-PatchSet: 1
Gerrit-Owner: Peilin Wang <peili...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Joel Tan-Aristy <jtana...@google.com>
Gerrit-Reviewer: Shu Yang <shu...@google.com>
Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Peilin Wang (Gerrit)

unread,
Jan 9, 2026, 6:29:51 PM (22 hours ago) Jan 9
to Rubber Stamper, Joel Tan-Aristy, Shu Yang, Chromium LUCI CQ, Wenyu Fu, chromium...@chromium.org
Attention needed from Joel Tan-Aristy, Peilin Wang, Shu Yang and Wenyu Fu

Peilin Wang voted

Auto-Submit+1
Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joel Tan-Aristy
  • Peilin Wang
  • Shu Yang
  • Wenyu Fu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia64f407fe80eb232303ab8d503929043be484bb6
Gerrit-Change-Number: 7426087
Gerrit-PatchSet: 1
Gerrit-Owner: Peilin Wang <peili...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Joel Tan-Aristy <jtana...@google.com>
Gerrit-Reviewer: Peilin Wang <peili...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Shu Yang <shu...@google.com>
Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
Gerrit-Attention: Joel Tan-Aristy <jtana...@google.com>
Gerrit-Attention: Shu Yang <shu...@google.com>
Gerrit-Attention: Peilin Wang <peili...@google.com>
Gerrit-Attention: Wenyu Fu <wen...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 23:29:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Jan 9, 2026, 6:30:26 PM (22 hours ago) Jan 9
to Peilin Wang, Joel Tan-Aristy, Shu Yang, Chromium LUCI CQ, Wenyu Fu, chromium...@chromium.org
Attention needed from Joel Tan-Aristy, Peilin Wang, Shu Yang and Wenyu Fu

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Joel Tan-Aristy
  • Peilin Wang
  • Shu Yang
  • Wenyu Fu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia64f407fe80eb232303ab8d503929043be484bb6
    Gerrit-Change-Number: 7426087
    Gerrit-PatchSet: 1
    Gerrit-Owner: Peilin Wang <peili...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joel Tan-Aristy <jtana...@google.com>
    Gerrit-Reviewer: Peilin Wang <peili...@google.com>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Shu Yang <shu...@google.com>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    Gerrit-Attention: Joel Tan-Aristy <jtana...@google.com>
    Gerrit-Attention: Shu Yang <shu...@google.com>
    Gerrit-Attention: Peilin Wang <peili...@google.com>
    Gerrit-Attention: Wenyu Fu <wen...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 23:30:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Wenyu Fu (Gerrit)

    unread,
    Jan 9, 2026, 7:57:04 PM (20 hours ago) Jan 9
    to Peilin Wang, Rubber Stamper, Joel Tan-Aristy, Shu Yang, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Joel Tan-Aristy, Peilin Wang and Shu Yang

    Wenyu Fu voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Joel Tan-Aristy
    • Peilin Wang
    • Shu Yang
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia64f407fe80eb232303ab8d503929043be484bb6
    Gerrit-Change-Number: 7426087
    Gerrit-PatchSet: 1
    Gerrit-Owner: Peilin Wang <peili...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Joel Tan-Aristy <jtana...@google.com>
    Gerrit-Reviewer: Peilin Wang <peili...@google.com>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Shu Yang <shu...@google.com>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    Gerrit-Attention: Joel Tan-Aristy <jtana...@google.com>
    Gerrit-Attention: Shu Yang <shu...@google.com>
    Gerrit-Attention: Peilin Wang <peili...@google.com>
    Gerrit-Comment-Date: Sat, 10 Jan 2026 00:56:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 9, 2026, 9:14:50 PM (19 hours ago) Jan 9
    to Peilin Wang, Wenyu Fu, Rubber Stamper, Joel Tan-Aristy, Shu Yang, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Creates unit test for NativePageNavigationDelegateImpl"

    This reverts commit d843cc2bc7af0b26b61a2291c3bca41bbc767733.

    Reason for revert: multiple bots are failing because of testOpenUrl_newWindow_incognitoWindowingEnabled

    Original change's description:
    > Creates unit test for NativePageNavigationDelegateImpl
    >
    > Bug: 474131693
    > Change-Id: Ida9e75e23ee48bd0a85af778a6dfdacff0c602c1
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7411420
    > Reviewed-by: Shu Yang <shu...@google.com>
    > Commit-Queue: Joel Tan-Aristy <jtana...@google.com>
    > Reviewed-by: Wenyu Fu <wen...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1567112}
    Bug: 474131693
    Change-Id: Ia64f407fe80eb232303ab8d503929043be484bb6
    Owners-Override: Peilin Wang <peili...@google.com>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Reviewed-by: Peilin Wang <peili...@google.com>
    Reviewed-by: Wenyu Fu <wen...@chromium.org>
    Auto-Submit: Peilin Wang <peili...@google.com>
    Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#1567325}
    Files:
    • M chrome/android/javatests/BUILD.gn
    • D chrome/android/javatests/src/org/chromium/chrome/browser/native_page/NativePageNavigationDelegateImplUnitTest.java
    Change size: M
    Delta: 2 files changed, 0 insertions(+), 154 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Wenyu Fu, +1 by Peilin Wang, Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia64f407fe80eb232303ab8d503929043be484bb6
    Gerrit-Change-Number: 7426087
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages