Revert "[Mac Window Occlusion] Hide native view for empty visible bounds" [chromium/src : main]
0 views
Skip to first unread message
Peng Zhou (Gerrit)
Aug 1, 2026, 5:12:14 AM (yesterday) Aug 1
to Chromium LUCI CQ, Keren Zhu, Avi Drissman, chromium...@chromium.org
Peng Zhou has uploaded the change for review![]( "Open in Gerrit")
Peng Zhou would like Chromium LUCI CQ, Keren Zhu and Avi Drissman to review this change.
Commit message
Revert "[Mac Window Occlusion] Hide native view for empty visible bounds"
This reverts commit d6e93f444e82820e0e4f8c5d9d7447f89ae06a5c.
Reason for revert: Caused performance regression.
Failure Link: 541312491
Original change's description:
> [Mac Window Occlusion] Hide native view for empty visible bounds
>
> `NativeViewHostMac::AttachNativeView` runs before
> `NativeViewHost::Layout`. As a result, a WebContents attached to a host
> with empty visible bounds may be visible when its native view is added
> to the new hierarchy. The native view is then hidden by `Layout`,
> causing a visible-to-hidden transition that the page can observe.
>
> Hide the native view before attaching it when the host has empty visible
> bounds. Also pass the initial visibility to `ViewsHostableAttach` so
> that a remote `WebContentsNSView` applies it before `SetParentNSView`.
>
> Bug: 540648468
> Change-Id: I3c449cd84c553ea898c82a1353e4c66731bc9f6d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8175843
> Reviewed-by: Keren Zhu <kere...@chromium.org>
> Reviewed-by: Avi Drissman <a...@chromium.org>
> Commit-Queue: Peng Zhou <peng...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1671951}
Bug: 540648468
Change-Id: Iae2c0b2b86bc24c555a3a0aec1903487667b32ae
Change diff
Change information
Files:
- M content/browser/web_contents/web_contents_view_mac.h
- M content/browser/web_contents/web_contents_view_mac.mm
- M ui/base/cocoa/views_hostable.h
- M ui/views/controls/native/native_view_host_mac.mm
- M ui/views/controls/native/native_view_host_mac_unittest.mm
Change size: M
Delta: 5 files changed, 7 insertions(+), 56 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Aug 1, 2026, 7:22:24 AM (24 hours ago) Aug 1
to Peng Zhou, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Keren Zhu, Avi Drissman, chromium...@chromium.org, sky+...@chromium.org, roblia...@chromium.org, mac-r...@chromium.org
Attention needed from Avi Drissman and Keren Zhu
rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Avi Drissman
- Keren Zhu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peng Zhou (Gerrit)
Aug 1, 2026, 7:22:32 AM (24 hours ago) Aug 1
to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Keren Zhu, Avi Drissman, chromium...@chromium.org, sky+...@chromium.org, roblia...@chromium.org, mac-r...@chromium.org
Attention needed from Avi Drissman and Keren Zhu
New activity on the change![]( "Open in Gerrit")
Avi Drissman (Gerrit)
Aug 1, 2026, 8:47:17 PM (11 hours ago) Aug 1
to Peng Zhou, Avi Drissman, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Keren Zhu, chromium...@chromium.org, sky+...@chromium.org, roblia...@chromium.org, mac-r...@chromium.org
Attention needed from Keren Zhu and Peng Zhou
Avi Drissman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Keren Zhu
- Peng Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Aug 1, 2026, 8:47:34 PM (11 hours ago) Aug 1
to Peng Zhou, Avi Drissman, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Keren Zhu, chromium...@chromium.org, sky+...@chromium.org, roblia...@chromium.org, mac-r...@chromium.org
Attention needed from Keren Zhu and Peng Zhou
Avi Drissman voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Reply all
Reply to author
Forward
0 new messages