[TurboCI] Adapt to stage args being ValueRefs. [infra/luci/luci-go : main]

0 views
Skip to first unread message

Robbie Iannucci (Gerrit)

unread,
12:37 AM (3 hours ago) 12:37 AM
to Vadim Shtayura, Tim Bain, chromium...@chromium.org, infra-revi...@chromium.org
Attention needed from Tim Bain and Vadim Shtayura

Robbie Iannucci has uploaded the change for review

Robbie Iannucci would like Vadim Shtayura and Tim Bain to review this change.

Commit message

[TurboCI] Adapt to stage args being ValueRefs.

R=tbain, vadimsh
Bug: 484102587
Change-Id: Icf651f89a703ad0916ed1de2a530acbb41c5f4e6

Change diff


Change information

Files:
  • M buildbucket/appengine/internal/turboci/client.go
  • M buildbucket/appengine/rpc/turbo_ci_stage_executor.go
  • M buildbucket/appengine/rpc/turbo_ci_stage_executor_run_stage_test.go
  • M buildbucket/appengine/rpc/turbo_ci_stage_executor_test.go
  • M buildbucket/appengine/rpc/turbo_ci_stage_executor_validate_stage_test.go
  • M buildbucket/appengine/rpc/turbo_ci_test.go
  • M turboci/rpc/write/example_test.go
  • M turboci/rpc/write/stages.go
  • M turboci/rpc/write/stages_test.go
  • A turboci/value/write.go
Change size: M
Delta: 10 files changed, 127 insertions(+), 78 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Tim Bain
  • Vadim Shtayura
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: infra/luci/luci-go
Gerrit-Branch: main
Gerrit-Change-Id: Icf651f89a703ad0916ed1de2a530acbb41c5f4e6
Gerrit-Change-Number: 7619887
Gerrit-PatchSet: 1
Gerrit-Owner: Robbie Iannucci <iann...@google.com>
Gerrit-Reviewer: Tim Bain <tb...@google.com>
Gerrit-Reviewer: Vadim Shtayura <vad...@chromium.org>
Gerrit-Attention: Vadim Shtayura <vad...@chromium.org>
Gerrit-Attention: Tim Bain <tb...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages