[Full WebUI Omnibox] Fix selection bugs [chromium/src : main]

0 views
Skip to first unread message

Marlon Facey (Gerrit)

unread,
Jul 1, 2026, 5:00:21 PM (8 days ago) Jul 1
to Paul Adedeji, Aviv Kiss, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Aviv Kiss and Paul Adedeji

Marlon Facey voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aviv Kiss
  • Paul Adedeji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2265aa7ed62313fd5f643d3fcb2b7fe5cbf1300c
Gerrit-Change-Number: 8032860
Gerrit-PatchSet: 4
Gerrit-Owner: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
Gerrit-Reviewer: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Paul Adedeji <paula...@google.com>
Gerrit-Attention: Aviv Kiss <aviv...@google.com>
Gerrit-Attention: Paul Adedeji <paula...@google.com>
Gerrit-Comment-Date: Wed, 01 Jul 2026 21:00:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Paul Adedeji (Gerrit)

unread,
Jul 7, 2026, 3:19:51 PM (2 days ago) Jul 7
to Marlon Facey, Code Review Nudger, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Marlon Facey

Paul Adedeji added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Paul Adedeji . resolved

I know we paused review here because of [my CL](https://chromium-review.git.corp.google.com/c/chromium/src/+/8045923). Are these changes still needed with those new changes?

Open in Gerrit

Related details

Attention is currently required from:
  • Marlon Facey
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2265aa7ed62313fd5f643d3fcb2b7fe5cbf1300c
Gerrit-Change-Number: 8032860
Gerrit-PatchSet: 4
Gerrit-Owner: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Paul Adedeji <paula...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Marlon Facey <mfa...@chromium.org>
Gerrit-Comment-Date: Tue, 07 Jul 2026 19:19:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Marlon Facey (Gerrit)

unread,
Jul 7, 2026, 4:23:04 PM (2 days ago) Jul 7
to Code Review Nudger, Chromium LUCI CQ, Paul Adedeji, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Paul Adedeji

Marlon Facey added 1 comment

Patchset-level comments
Paul Adedeji . resolved

I know we paused review here because of [my CL](https://chromium-review.git.corp.google.com/c/chromium/src/+/8045923). Are these changes still needed with those new changes?

Marlon Facey

Some of it is still needed but I am testing now.

Open in Gerrit

Related details

Attention is currently required from:
  • Paul Adedeji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2265aa7ed62313fd5f643d3fcb2b7fe5cbf1300c
Gerrit-Change-Number: 8032860
Gerrit-PatchSet: 4
Gerrit-Owner: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Paul Adedeji <paula...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Paul Adedeji <paula...@google.com>
Gerrit-Comment-Date: Tue, 07 Jul 2026 20:22:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Adedeji <paula...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Paul Adedeji (Gerrit)

unread,
Jul 7, 2026, 4:28:08 PM (2 days ago) Jul 7
to Marlon Facey, Code Review Nudger, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org

Paul Adedeji added 1 comment

Patchset-level comments
Paul Adedeji . resolved

Removing myself from the attn set till my review is needed.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2265aa7ed62313fd5f643d3fcb2b7fe5cbf1300c
Gerrit-Change-Number: 8032860
Gerrit-PatchSet: 4
Gerrit-Owner: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Paul Adedeji <paula...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Comment-Date: Tue, 07 Jul 2026 20:27:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Marlon Facey (Gerrit)

unread,
12:06 PM (5 hours ago) 12:06 PM
to Code Review Nudger, Chromium LUCI CQ, Paul Adedeji, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, niharm...@google.com, oshima...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org

Marlon Facey voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2265aa7ed62313fd5f643d3fcb2b7fe5cbf1300c
Gerrit-Change-Number: 8032860
Gerrit-PatchSet: 13
Gerrit-Owner: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Paul Adedeji <paula...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 16:06:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Marlon Facey (Gerrit)

unread,
3:04 PM (2 hours ago) 3:04 PM
to Code Review Nudger, Chromium LUCI CQ, Paul Adedeji, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, niharm...@google.com, oshima...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org

Marlon Facey voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2265aa7ed62313fd5f643d3fcb2b7fe5cbf1300c
Gerrit-Change-Number: 8032860
Gerrit-PatchSet: 16
Gerrit-Owner: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Marlon Facey <mfa...@chromium.org>
Gerrit-Reviewer: Paul Adedeji <paula...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 19:04:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages