Prolong some password manager histograms until M155. [chromium/src : main]

0 views
Skip to first unread message

Viktor Semeniuk (Gerrit)

unread,
6:33 AM (2 hours ago) 6:33 AM
to Anna Tsvirchkova, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Anna Tsvirchkova

Viktor Semeniuk voted and added 1 comment

Votes added by Viktor Semeniuk

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Viktor Semeniuk . resolved

Hi Anna, PTAL
Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Anna Tsvirchkova
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I99b3a0c3ca9485feaed1b1a0165162cd7d0ad8b7
Gerrit-Change-Number: 7748475
Gerrit-PatchSet: 2
Gerrit-Owner: Viktor Semeniuk <vsem...@google.com>
Gerrit-Reviewer: Anna Tsvirchkova <atsvir...@google.com>
Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Anna Tsvirchkova <atsvir...@google.com>
Gerrit-Comment-Date: Mon, 13 Apr 2026 10:33:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Anna Tsvirchkova (Gerrit)

unread,
7:37 AM (1 hour ago) 7:37 AM
to Viktor Semeniuk, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Viktor Semeniuk

Anna Tsvirchkova voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Viktor Semeniuk
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I99b3a0c3ca9485feaed1b1a0165162cd7d0ad8b7
    Gerrit-Change-Number: 7748475
    Gerrit-PatchSet: 2
    Gerrit-Owner: Viktor Semeniuk <vsem...@google.com>
    Gerrit-Reviewer: Anna Tsvirchkova <atsvir...@google.com>
    Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Viktor Semeniuk <vsem...@google.com>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 11:37:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Viktor Semeniuk (Gerrit)

    unread,
    7:43 AM (1 hour ago) 7:43 AM
    to Anna Tsvirchkova, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

    Viktor Semeniuk voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I99b3a0c3ca9485feaed1b1a0165162cd7d0ad8b7
    Gerrit-Change-Number: 7748475
    Gerrit-PatchSet: 2
    Gerrit-Owner: Viktor Semeniuk <vsem...@google.com>
    Gerrit-Reviewer: Anna Tsvirchkova <atsvir...@google.com>
    Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 11:43:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    7:47 AM (1 hour ago) 7:47 AM
    to Viktor Semeniuk, Anna Tsvirchkova, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

    chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Change information

    Commit message:
    Prolong some password manager histograms until M155.
    Fixed: 493222335, 495423895, 495424117, 497834701
    Change-Id: I99b3a0c3ca9485feaed1b1a0165162cd7d0ad8b7
    Reviewed-by: Anna Tsvirchkova <atsvir...@google.com>
    Commit-Queue: Viktor Semeniuk <vsem...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1613627}
    Files:
    • M tools/metrics/histograms/metadata/password/histograms.xml
    Change size: S
    Delta: 1 file changed, 8 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Anna Tsvirchkova
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I99b3a0c3ca9485feaed1b1a0165162cd7d0ad8b7
    Gerrit-Change-Number: 7748475
    Gerrit-PatchSet: 3
    Gerrit-Owner: Viktor Semeniuk <vsem...@google.com>
    Gerrit-Reviewer: Anna Tsvirchkova <atsvir...@google.com>
    Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages