Cleanup now redundant UNSAFE_TODO() media [chromium/src : main]

0 views
Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,
Jan 13, 2026, 11:31:30 AMJan 13
to Mark Foltz, chromium...@chromium.org, feature-me...@chromium.org, vaapi-...@chromium.org, chromeos-gfx-...@google.com, media-cro...@chromium.org, eme-r...@chromium.org
Attention needed from Mark Foltz

Arthur Sonzogni has uploaded the change for review

Arthur Sonzogni would like Mark Foltz to review this change.

Commit message

Cleanup now redundant UNSAFE_TODO() media

As part of the spanification effort, the codebase contains now many
UNSAFE_TODO() macros used to suppress -Wunsafe-buffer-usage errors. As
code evolves and is modernized, these macros sometimes become redundant
but are difficult to identify exhaustively.

This is an automated patch generated using:
tools/clang/unsafe_todo_remover
from:
https://chromium-review.googlesource.com/c/chromium/src/+/7462506

This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).

R=mfo...@chromium.org
Cleanup: This is a #cleanup
Bug: 475236716
Change-Id: Iac22dc5a3698f28ab6546f7b5c96cac016303aff

Change diff


Change information

Files:
  • M media/base/audio_bus_unittest.cc
  • M media/cdm/aes_decryptor_unittest.cc
  • M media/gpu/vaapi/test/vp8_decoder.cc
  • M media/gpu/vaapi/test/vp9_decoder.cc
  • M media/gpu/vaapi/vp9_vaapi_video_encoder_delegate.cc
  • M media/parsers/vp9_uncompressed_header_parser.cc
Change size: M
Delta: 6 files changed, 34 insertions(+), 39 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Foltz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iac22dc5a3698f28ab6546f7b5c96cac016303aff
Gerrit-Change-Number: 7459693
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>
Gerrit-Attention: Mark Foltz <mfo...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Foltz (Gerrit)

unread,
Jan 13, 2026, 2:42:58 PMJan 13
to Arthur Sonzogni, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, eme-r...@chromium.org, feature-me...@chromium.org, media-cro...@chromium.org, vaapi-...@chromium.org
Attention needed from Arthur Sonzogni

Mark Foltz voted and added 1 comment

Votes added by Mark Foltz

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mark Foltz . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iac22dc5a3698f28ab6546f7b5c96cac016303aff
Gerrit-Change-Number: 7459693
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 19:42:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Jan 14, 2026, 5:07:22 AMJan 14
to Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, eme-r...@chromium.org, feature-me...@chromium.org, media-cro...@chromium.org, vaapi-...@chromium.org

Arthur Sonzogni voted and added 1 comment

Votes added by Arthur Sonzogni

Commit-Queue+2

1 comment

Patchset-level comments
Arthur Sonzogni . resolved

Thanks Mark for the review!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iac22dc5a3698f28ab6546f7b5c96cac016303aff
Gerrit-Change-Number: 7459693
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Jan 2026 10:07:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 14, 2026, 5:10:39 AMJan 14
to Arthur Sonzogni, Mark Foltz, chromium...@chromium.org, chromeos-gfx-...@google.com, eme-r...@chromium.org, feature-me...@chromium.org, media-cro...@chromium.org, vaapi-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Cleanup now redundant UNSAFE_TODO() media

As part of the spanification effort, the codebase contains now many
UNSAFE_TODO() macros used to suppress -Wunsafe-buffer-usage errors. As
code evolves and is modernized, these macros sometimes become redundant
but are difficult to identify exhaustively.

This is an automated patch generated using:
tools/clang/unsafe_todo_remover
from:
https://chromium-review.googlesource.com/c/chromium/src/+/7462506

This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).

R=mfo...@chromium.org
Cleanup: This is a #cleanup
Bug: 475236716
Change-Id: Iac22dc5a3698f28ab6546f7b5c96cac016303aff
Reviewed-by: Mark Foltz <mfo...@chromium.org>
Auto-Submit: Arthur Sonzogni <arthurs...@chromium.org>
Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568991}
Files:
  • M media/base/audio_bus_unittest.cc
  • M media/cdm/aes_decryptor_unittest.cc
  • M media/gpu/vaapi/test/vp8_decoder.cc
  • M media/gpu/vaapi/test/vp9_decoder.cc
  • M media/gpu/vaapi/vp9_vaapi_video_encoder_delegate.cc
  • M media/parsers/vp9_uncompressed_header_parser.cc
Change size: M
Delta: 6 files changed, 34 insertions(+), 39 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Foltz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iac22dc5a3698f28ab6546f7b5c96cac016303aff
Gerrit-Change-Number: 7459693
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages