Don't handle kInvalidDOMNodeId in OffscreenCanvasPlaceholder::Client [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
Jun 26, 2026, 9:59:42 AM (13 days ago) Jun 26
to Colin Blundell, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jun 26, 2026, 11:31:58 AM (13 days ago) Jun 26
to Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Vasiliy Telezhnikov
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
10:46 AM (4 hours ago) 10:46 AM
to Colin Blundell, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:02 PM (3 hours ago) 12:02 PM
to Vasiliy Telezhnikov, Colin Blundell, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Don't handle kInvalidDOMNodeId in OffscreenCanvasPlaceholder::Client
It's not possible, as we create client only if we have placeholder.
Change-Id: I7c5203e1f3c4c906aa8b122ef07c18bba08e1d57
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659599}
Files:
- M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages