Add a new owner for //ui/display/mac [chromium/src : main]
Maggie Chen (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- ccameron chromium
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maggie Chen (Gerrit)
Maggie Chen added 1 comment![]( "Open in Gerrit")
per-file *display_link*=mag...@chromium.orgThis does NOT seem to work. Please see https://chromium-review.googlesource.com/c/chromium/src/+/7279120 where display_link_mac.mm is included but it shows no owner.
Related details
- ccameron chromium
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Avi Drissman added 1 comment![]( "Open in Gerrit")
per-file *display_link*=mag...@chromium.orgThis does NOT seem to work. Please see https://chromium-review.googlesource.com/c/chromium/src/+/7279120 where display_link_mac.mm is included but it shows no owner.
- Maggie Chen
- ccameron chromium
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maggie Chen (Gerrit)
Maggie Chen added 1 comment![]( "Open in Gerrit")
per-file *display_link*=mag...@chromium.orgAvi DrissmanThis does NOT seem to work. Please see https://chromium-review.googlesource.com/c/chromium/src/+/7279120 where display_link_mac.mm is included but it shows no owner.
I don’t know what’s up with that; can you ask?
Who can I ask? Thanks.
One thing I notice is that BUILD.gn and OWNER are located in `//ui/display/`, while the displaylink files are in `//ui/display/mac`. So the displaylink source files are added like this "mac/display_link_mac.h". Is it possible that `*display_link*` refers to the files in `//ui/display/` only and not in the sub directory `/mac`.
Related details
- Avi Drissman
- ccameron chromium
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Avi Drissman added 1 comment![]( "Open in Gerrit")
per-file *display_link*=mag...@chromium.orgAvi DrissmanThis does NOT seem to work. Please see https://chromium-review.googlesource.com/c/chromium/src/+/7279120 where display_link_mac.mm is included but it shows no owner.
Maggie ChenI don’t know what’s up with that; can you ask?
Who can I ask? Thanks.
One thing I notice is that BUILD.gn and OWNER are located in `//ui/display/`, while the displaylink files are in `//ui/display/mac`. So the displaylink source files are added like this "mac/display_link_mac.h". Is it possible that `*display_link*` refers to the files in `//ui/display/` only and not in the sub directory `/mac`.
There’s a `#gn` channel on Slack.
Docs are at https://chromium.googlesource.com/chromium/src/+/main/docs/code_reviews.md#owners-file-details with full details at https://github.com/GerritCodeReview/plugins_code-owners/blob/master/resources/Documentation/backend-find-owners.md.
Related details
- Maggie Chen
- ccameron chromium
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |