[AtMemory] Add PersonalContextService error handling [chromium/src : main]

0 views
Skip to first unread message

Karol Sygiet (Gerrit)

unread,
Jun 18, 2026, 2:02:36 AM (14 days ago) Jun 18
to chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, accessibility-a...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Karol Sygiet added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Karol Sygiet . resolved

Hi Irek, could you take a look?

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic389f43e332ea80cf7bdfe5e617481264a38c081
Gerrit-Change-Number: 7957499
Gerrit-PatchSet: 2
Gerrit-Owner: Karol Sygiet <syg...@google.com>
Gerrit-Reviewer: Karol Sygiet <syg...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Jun 2026 06:02:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ireneusz Szulc (Gerrit)

unread,
Jun 18, 2026, 6:50:24 AM (14 days ago) Jun 18
to Karol Sygiet, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, accessibility-a...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Karol Sygiet

Ireneusz Szulc voted and added 1 comment

Votes added by Ireneusz Szulc

Code-Review+1

1 comment

File components/accessibility_annotator/core/accessibility_query_service.cc
Line 128, Patchset 2 (Latest): case personal_context::ContextMemoryError::ExecutionError::kCancelled:
NOTREACHED();
Ireneusz Szulc . unresolved

Why it's set to NOTREACHED()? It's the case when The request was cancelled by the client. I think it's better to return MemorySearchStatus::kDataFetchFailure, than to risk a random crash.

Open in Gerrit

Related details

Attention is currently required from:
  • Karol Sygiet
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic389f43e332ea80cf7bdfe5e617481264a38c081
Gerrit-Change-Number: 7957499
Gerrit-PatchSet: 2
Gerrit-Owner: Karol Sygiet <syg...@google.com>
Gerrit-Reviewer: Ireneusz Szulc <ireneu...@google.com>
Gerrit-Reviewer: Karol Sygiet <syg...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Karol Sygiet <syg...@google.com>
Gerrit-Comment-Date: Thu, 18 Jun 2026 10:49:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Karol Sygiet (Gerrit)

unread,
Jun 18, 2026, 6:58:07 AM (14 days ago) Jun 18
to Ireneusz Szulc, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, accessibility-a...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Karol Sygiet added 1 comment

File components/accessibility_annotator/core/accessibility_query_service.cc
Line 128, Patchset 2: case personal_context::ContextMemoryError::ExecutionError::kCancelled:
NOTREACHED();
Ireneusz Szulc . resolved

Why it's set to NOTREACHED()? It's the case when The request was cancelled by the client. I think it's better to return MemorySearchStatus::kDataFetchFailure, than to risk a random crash.

Karol Sygiet

Good point, I guess right now I added it since it is not possible, but given that this helper may be used by others your suggestion is better. Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic389f43e332ea80cf7bdfe5e617481264a38c081
    Gerrit-Change-Number: 7957499
    Gerrit-PatchSet: 3
    Gerrit-Owner: Karol Sygiet <syg...@google.com>
    Gerrit-Reviewer: Ireneusz Szulc <ireneu...@google.com>
    Gerrit-Reviewer: Karol Sygiet <syg...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Jun 2026 10:57:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Ireneusz Szulc <ireneu...@google.com>
    satisfied_requirement
    open
    diffy

    Karol Sygiet (Gerrit)

    unread,
    Jun 18, 2026, 6:58:12 AM (14 days ago) Jun 18
    to Ireneusz Szulc, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, accessibility-a...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

    Karol Sygiet voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic389f43e332ea80cf7bdfe5e617481264a38c081
    Gerrit-Change-Number: 7957499
    Gerrit-PatchSet: 3
    Gerrit-Owner: Karol Sygiet <syg...@google.com>
    Gerrit-Reviewer: Ireneusz Szulc <ireneu...@google.com>
    Gerrit-Reviewer: Karol Sygiet <syg...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Jun 2026 10:57:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 18, 2026, 8:12:14 AM (14 days ago) Jun 18
    to Karol Sygiet, Ireneusz Szulc, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, accessibility-a...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    2 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: components/accessibility_annotator/core/accessibility_query_service.cc
    Insertions: 1, Deletions: 3.

    @@ -17,7 +17,6 @@
     #include "base/functional/bind.h"
     #include "base/i18n/break_iterator.h"
     #include "base/metrics/histogram_functions.h"
    -#include "base/notreached.h"
     #include "base/strings/strcat.h"
     #include "base/strings/string_util.h"
     #include "components/accessibility_annotator/core/annotation_reducer/memory_data_provider.h"
    @@ -118,6 +117,7 @@
         case personal_context::ContextMemoryError::ExecutionError::kRetryableError:
         case personal_context::ContextMemoryError::ExecutionError::
             kNonRetryableError:
    +    case personal_context::ContextMemoryError::ExecutionError::kCancelled:
           return MemorySearchStatus::kDataFetchFailure;
         case personal_context::ContextMemoryError::ExecutionError::
             kResponseParseError:
    @@ -125,8 +125,6 @@
         case personal_context::ContextMemoryError::ExecutionError::kGenericFailure:
         case personal_context::ContextMemoryError::ExecutionError::kUnknown:
           return MemorySearchStatus::kInternalFailure;
    -    case personal_context::ContextMemoryError::ExecutionError::kCancelled:
    -      NOTREACHED();
       }
     }
     
    ```

    Change information

    Commit message:
    [AtMemory] Add PersonalContextService error handling

    This CL causes relevant UI elements to appear when
    PersonalContextService request failed.
    Bug: 524937997
    Change-Id: Ic389f43e332ea80cf7bdfe5e617481264a38c081
    Reviewed-by: Ireneusz Szulc <ireneu...@google.com>
    Commit-Queue: Karol Sygiet <syg...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1648954}
    Files:
    • M components/accessibility_annotator/core/accessibility_query_service.cc
    • M components/accessibility_annotator/core/accessibility_query_service_unittest.cc
    Change size: M
    Delta: 2 files changed, 97 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Ireneusz Szulc
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic389f43e332ea80cf7bdfe5e617481264a38c081
    Gerrit-Change-Number: 7957499
    Gerrit-PatchSet: 4
    Gerrit-Owner: Karol Sygiet <syg...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ireneusz Szulc <ireneu...@google.com>
    Gerrit-Reviewer: Karol Sygiet <syg...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages