Chris Lu (Gerrit)

unread,

Jul 7, 2026, 11:30:43 AM (2 days ago) Jul 7

to Radu Nitescu, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Radu Nitescu

Chris Lu voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Radu Nitescu (Gerrit)

unread,

4:44 AM (9 hours ago) 4:44 AM

to Chris Lu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Chris Lu

Radu Nitescu voted and added 2 comments

Votes added by Radu Nitescu

Code-Review

+1

2 comments

File ios/chrome/browser/composebox/ui/composebox_input_item_cell.mm

Line 183, Patchset 3 (Latest): __strong __typeof(weakSelf) strongSelf = weakSelf;

Radu Nitescu . unresolved

This isn't explicitly required

Line 183, Patchset 3 (Latest):

        __strong __typeof(weakSelf) strongSelf = weakSelf;
        if (!strongSelf) {
          return NO;
        }
        return [strongSelf closeButtonTapped];

Radu Nitescu . unresolved

A method call on nil will return `NO`, so no need to strongify and check for nil. You can just call the method

```suggestion
        return [weakSelf closeButtonTapped];
```

Open in Gerrit

Related details

Attention is currently required from:

Chris Lu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Chris Lu (Gerrit)

unread,

11:03 AM (3 hours ago) 11:03 AM

to Radu Nitescu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chris Lu voted and added 2 comments

Votes added by Chris Lu

Auto-Submit	+1
Commit-Queue	+2

2 comments

File ios/chrome/browser/composebox/ui/composebox_input_item_cell.mm

Line 183, Patchset 3: __strong __typeof(weakSelf) strongSelf = weakSelf;

Radu Nitescu . resolved

This isn't explicitly required

Chris Lu

Acknowledged

Line 183, Patchset 3: __strong __typeof(weakSelf) strongSelf = weakSelf;


        if (!strongSelf) {
          return NO;
        }
        return [strongSelf closeButtonTapped];

Radu Nitescu . resolved

A method call on nil will return `NO`, so no need to strongify and check for nil. You can just call the method
```suggestion
        return [weakSelf closeButtonTapped];
```

Chris Lu

Fix applied.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

12:04 PM (1 hour ago) 12:04 PM

to Chris Lu, Radu Nitescu, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: ios/chrome/browser/composebox/ui/composebox_input_item_cell.mm
Insertions: 1, Deletions: 5.

@@ -180,11 +180,7 @@
                IDS_IOS_COMPOSEBOX_DELETE_ATTACHMENT_ACCESSIBILITY_CUSTOM_ACTION)
               image:image
       actionHandler:^BOOL(UIAccessibilityCustomAction* action) {
-        __strong __typeof(weakSelf) strongSelf = weakSelf;
-        if (!strongSelf) {
-          return NO;
-        }
-        return [strongSelf closeButtonTapped];
+        return [weakSelf closeButtonTapped];
       }] ];
 }
 
```

Change information

Commit message:

[ios] Fix VoiceOver delete action and add iPad pointer hover effect

- Migrate custom accessibility actions on ComposeboxInputItemCell to the block-based actionHandler API, and change the signature of closeButtonTapped to return BOOL. This ensures VoiceOver correctly discovers and exposes the 'Delete attachment' custom action.
- Add UIPointerInteraction to ComposeboxInputItemCell via ViewPointerInteraction to support hover effects when iPad pointer is hovering over attachment elements in the carousel.

Fixed: 490056644

Change-Id: Ice3ae03e6f5c0ed6a4446bf5f8358682f3540e38

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8052429

Auto-Submit: Chris Lu <thegre...@chromium.org>

Commit-Queue: Chris Lu <thegre...@chromium.org>

Reviewed-by: Radu Nitescu <radun...@google.com>

Cr-Commit-Position: refs/heads/main@{#1659600}

Files:

M ios/chrome/browser/composebox/ui/composebox_input_item_cell.mm

Change size: S

Delta: 1 file changed, 13 insertions(+), 7 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Radu Nitescu

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[ios] Fix VoiceOver delete action and add iPad pointer hover effect [chromium/src : main]

Chris Lu (Gerrit)

Chris Lu voted

Related details

Radu Nitescu (Gerrit)

Radu Nitescu voted and added 2 comments

Votes added by Radu Nitescu

2 comments

Related details

Chris Lu (Gerrit)

Chris Lu voted and added 2 comments

Votes added by Chris Lu

2 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information