[iOS] Update Ask Gemini Chip Text and Prefilled Prompt for Floaty [chromium/src : main]

0 views
Skip to first unread message

Joemer Ramos (Gerrit)

unread,
Dec 5, 2025, 3:34:12 PM (12 hours ago) Dec 5
to Joemer Ramos, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro

Joemer Ramos voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Arcaro
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I080427a4cd10cd3e58eae7145273aba94ad0561f
Gerrit-Change-Number: 7232431
Gerrit-PatchSet: 1
Gerrit-Owner: Joemer Ramos <joeme...@google.com>
Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
Gerrit-Attention: Adam Arcaro <ada...@google.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 20:34:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Adam Arcaro (Gerrit)

unread,
Dec 5, 2025, 4:02:54 PM (12 hours ago) Dec 5
to Joemer Ramos, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Joemer Ramos

Adam Arcaro added 1 comment

File ios/chrome/browser/location_bar/badge/coordinator/location_bar_badge_mediator.mm
Line 39, Patchset 1 (Latest): @"page. Use a concise, casual tone. Limit to 100 words.";
Adam Arcaro . unresolved

We should still submit official strings for these, so they can eventually be translated

Open in Gerrit

Related details

Attention is currently required from:
  • Joemer Ramos
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I080427a4cd10cd3e58eae7145273aba94ad0561f
    Gerrit-Change-Number: 7232431
    Gerrit-PatchSet: 1
    Gerrit-Owner: Joemer Ramos <joeme...@google.com>
    Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
    Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
    Gerrit-Attention: Joemer Ramos <joeme...@google.com>
    Gerrit-Comment-Date: Fri, 05 Dec 2025 21:02:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joemer Ramos (Gerrit)

    unread,
    Dec 5, 2025, 11:19:39 PM (4 hours ago) Dec 5
    to Joemer Ramos, AyeAye, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Adam Arcaro

    Joemer Ramos voted and added 1 comment

    Votes added by Joemer Ramos

    Auto-Submit+1

    1 comment

    File ios/chrome/browser/location_bar/badge/coordinator/location_bar_badge_mediator.mm
    Line 39, Patchset 1: @"page. Use a concise, casual tone. Limit to 100 words.";
    Adam Arcaro . resolved

    We should still submit official strings for these, so they can eventually be translated

    Joemer Ramos

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Arcaro
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I080427a4cd10cd3e58eae7145273aba94ad0561f
      Gerrit-Change-Number: 7232431
      Gerrit-PatchSet: 2
      Gerrit-Owner: Joemer Ramos <joeme...@google.com>
      Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
      Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
      Gerrit-Attention: Adam Arcaro <ada...@google.com>
      Gerrit-Comment-Date: Sat, 06 Dec 2025 04:19:33 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Adam Arcaro <ada...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages