connectivity_tool: Wire up GoogleServicesConnectivity routine in ... [chromium/src : main]

0 views

Skip to first unread message

Maksim Sisov (Gerrit)

unread,

Jan 12, 2026, 8:28:38 AM (2 days ago) Jan 12

to Andreea Costinas, Aashay Shringarpure, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, weiluanw...@google.com, menghua...@google.com, byronle...@chromium.org, chungshe...@google.com, oshima...@chromium.org, dennyh...@google.com

Attention needed from Aashay Shringarpure, Andreea Costinas and Hidehiko Abe

Maksim Sisov added 1 comment

Patchset-level comments

File-level comment, Patchset 18 (Latest):

Maksim Sisov . resolved

Aashay, you suggested to use handle as cros_healthd is simply a proxy that forwards the stuff here. Is that something that would work using json? I'm not sure that works well or what else I can pass through that handle

hidehiko@, FYI as well

Open in Gerrit

Related details

Attention is currently required from:

Aashay Shringarpure
Andreea Costinas
Hidehiko Abe

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hidehiko Abe (Gerrit)

unread,

12:35 AM (4 hours ago) 12:35 AM

to Maksim Sisov, Andreea Costinas, Aashay Shringarpure, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, weiluanw...@google.com, menghua...@google.com, byronle...@chromium.org, chungshe...@google.com, oshima...@chromium.org, dennyh...@google.com

Attention needed from Aashay Shringarpure, Andreea Costinas and Maksim Sisov

Hidehiko Abe added 2 comments

File ash/webui/diagnostics_ui/backend/system/system_routine_controller.cc

Line 780, Patchset 19 (Latest):

  // Use same parser options as PowerRoutine for consistency.
  std::optional<base::Value> parsed = base::JSONReader::Read(
      file_contents, base::JSON_PARSE_CHROMIUM_EXTENSIONS);
  if (!parsed || !parsed->is_dict()) {
    DVLOG(2) << "GoogleServicesConnectivity routine: failed to parse JSON";
    OnGoogleServicesConnectivityRoutineResult(routine_type, result,
                                              std::move(problems));
    return;
  }

  const base::Value::List* problems_list =
      parsed->GetDict().FindList(kProblemsKey);
  if (!problems_list) {
    DVLOG(2) << "GoogleServicesConnectivity routine: missing 'problems' key";
    OnGoogleServicesConnectivityRoutineResult(routine_type, result,
                                              std::move(problems));
    return;
  }

  for (const base::Value& problem_value : *problems_list) {
    if (problem_value.is_dict()) {
      auto problem =
          ParseGoogleServicesConnectivityProblem(problem_value.GetDict());
      if (problem) {
        problems.push_back(std::move(problem));
      }
    }
  }

Hidehiko Abe . unresolved

optional: can parsing be done in the background thread for better throughput of the main sequence, as you already read the file descriptor there?

Line 966, Patchset 19 (Latest): inflight_routine_runner_->OnRoutineResult(std::move(result_info));

Hidehiko Abe . unresolved

May I ask you to confirm where this is going to be called?