Re: Ensure that OCSPIOLoop is associated with right thread if restarted. (issue 11347039)
19 views
Skip to first unread message
blun...@chromium.org
Nov 8, 2012, 9:13:11 AM11/8/12
to rsl...@chromium.org, chromium...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
rsl...@chromium.org
Nov 8, 2012, 9:20:11 AM11/8/12
to blun...@chromium.org, chromium...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
lgtm
https://chromiumcodereview.appspot.com/11347039/diff/7001/net/ocsp/nss_ocsp.h
File net/ocsp/nss_ocsp.h (right):
https://chromiumcodereview.appspot.com/11347039/diff/7001/net/ocsp/nss_ocsp.h#newcode30
net/ocsp/nss_ocsp.h:30: // and associate it with the current IO thread,
on which this function must be
s/current IO thread/current thread/ ("IO thread" is a content/ concept,
not a net/ concept)
https://chromiumcodereview.appspot.com/11347039/diff/7001/net/ocsp/nss_ocsp.h#newcode32
net/ocsp/nss_ocsp.h:32: // sequentially created and destroyed throughout
the lifetime of the app.
Delete the sentence "Should be used only..."
https://chromiumcodereview.appspot.com/11347039/
https://chromiumcodereview.appspot.com/11347039/diff/7001/net/ocsp/nss_ocsp.h
File net/ocsp/nss_ocsp.h (right):
https://chromiumcodereview.appspot.com/11347039/diff/7001/net/ocsp/nss_ocsp.h#newcode30
net/ocsp/nss_ocsp.h:30: // and associate it with the current IO thread,
on which this function must be
s/current IO thread/current thread/ ("IO thread" is a content/ concept,
not a net/ concept)
https://chromiumcodereview.appspot.com/11347039/diff/7001/net/ocsp/nss_ocsp.h#newcode32
net/ocsp/nss_ocsp.h:32: // sequentially created and destroyed throughout
the lifetime of the app.
Delete the sentence "Should be used only..."
https://chromiumcodereview.appspot.com/11347039/
blun...@chromium.org
Nov 8, 2012, 10:59:08 AM11/8/12
to rsl...@chromium.org, chromium...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
https://chromiumcodereview.appspot.com/11347039/diff/7001/net/ocsp/nss_ocsp.h
File net/ocsp/nss_ocsp.h (right):
https://chromiumcodereview.appspot.com/11347039/diff/7001/net/ocsp/nss_ocsp.h#newcode30
net/ocsp/nss_ocsp.h:30: // and associate it with the current IO thread,
on which this function must be
On 2012/11/08 14:20:11, Ryan Sleevi wrote:
> s/current IO thread/current thread/ ("IO thread" is a content/
concept, not a
> net/ concept)
Done.
> s/current IO thread/current thread/ ("IO thread" is a content/
concept, not a
> net/ concept)
https://chromiumcodereview.appspot.com/11347039/diff/7001/net/ocsp/nss_ocsp.h#newcode32
net/ocsp/nss_ocsp.h:32: // sequentially created and destroyed throughout
the lifetime of the app.
On 2012/11/08 14:20:11, Ryan Sleevi wrote:
> Delete the sentence "Should be used only..."
Done.
> Delete the sentence "Should be used only..."
https://chromiumcodereview.appspot.com/11347039/
commi...@chromium.org
Nov 8, 2012, 10:59:24 AM11/8/12
to blun...@chromium.org, rsl...@chromium.org, chromium...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blun...@chromium.org/11347039/11001
https://chromiumcodereview.appspot.com/11347039/
https://chromium-status.appspot.com/cq/blun...@chromium.org/11347039/11001
https://chromiumcodereview.appspot.com/11347039/
commi...@chromium.org
Nov 8, 2012, 2:02:36 PM11/8/12
to blun...@chromium.org, rsl...@chromium.org, chromium...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
Retried try job too often for step(s) content_browsertests
https://chromiumcodereview.appspot.com/11347039/
https://chromiumcodereview.appspot.com/11347039/
commi...@chromium.org
Nov 9, 2012, 1:45:17 AM11/9/12
to blun...@chromium.org, rsl...@chromium.org, chromium...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
commi...@chromium.org
Nov 9, 2012, 2:31:51 AM11/9/12
to blun...@chromium.org, rsl...@chromium.org, chromium...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
Reply all
Reply to author
Forward
0 new messages