Darryl James (Gerrit)

unread,

Dec 15, 2025, 2:50:17 PM (17 hours ago) Dec 15

to David Pennington, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Attention needed from David Pennington

Darryl James voted and added 2 comments

Votes added by Darryl James

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Darryl James . resolved

lgtm!

File tools/metrics/histograms/metadata/tab/histograms.xml

Line 1053, Patchset 2 (Latest): expires_after="2026-12-15">

Darryl James . unresolved

I believe the general guidance is that metrics should not be extended more than 6 months at a time. That said, I don't personally have a problem extending these metrics longer due to the feature it is associated with.

Something to keep in mind 👍

Open in Gerrit

Related details

Attention is currently required from:

David Pennington

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Pennington (Gerrit)

unread,

Dec 15, 2025, 5:15:29 PM (14 hours ago) Dec 15

to Darryl James, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

David Pennington voted and added 1 comment

Votes added by David Pennington

Commit-Queue

+2

1 comment

File tools/metrics/histograms/metadata/tab/histograms.xml

Line 1053, Patchset 2 (Latest): expires_after="2026-12-15">

Darryl James . resolved

I believe the general guidance is that metrics should not be extended more than 6 months at a time. That said, I don't personally have a problem extending these metrics longer due to the feature it is associated with.
Something to keep in mind 👍

David Pennington

Acknowledged

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Dec 15, 2025, 6:22:38 PM (13 hours ago) Dec 15

to David Pennington, Darryl James, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[TabGroups] update a bunch of tab groups timeseries

extending these CLs out to end of 2026

Fixed: 457442553

Fixed: 457442320

Fixed: 461502143

Fixed: 457442066

Fixed: 457442454

Fixed: 445169324

Fixed: 442400565

Fixed: 407543719

Fixed: 402121424

Fixed: 398847714

Fixed: 398846864

Fixed: 439592545

Fixed: 374764071

Fixed: 374763685

Fixed: 407543230

Change-Id: I9ada930470a4a71085e65b27c1729c562ee32321

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262862

Commit-Queue: David Pennington <dpen...@chromium.org>

Reviewed-by: Darryl James <dlj...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1559031}

Files:

M tools/metrics/histograms/metadata/tab/histograms.xml

Change size: S

Delta: 1 file changed, 15 insertions(+), 15 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Darryl James

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[TabGroups] update a bunch of tab groups timeseries [chromium/src : main]

Darryl James (Gerrit)

Darryl James voted and added 2 comments

Votes added by Darryl James

2 comments

Related details

David Pennington (Gerrit)

David Pennington voted and added 1 comment

Votes added by David Pennington

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information