[DownloadBubble] Update icon color when the toolbar button disabled [chromium/src : main]
0 views
Skip to first unread message
Xinghui Lu (Gerrit)
Aug 5, 2022, 8:43:21 PM8/5/22
to bhatiaro...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org, Rohit Bhatia, Chromium LUCI CQ, chromium...@chromium.org
Attention is currently required from: Rohit Bhatia.
To view, visit change 3813960. To unsubscribe, or for help writing mail filters, visit settings.
Rohit Bhatia (Gerrit)
Aug 9, 2022, 1:11:30 AM8/9/22
to Xinghui Lu, bhatiaro...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org
Attention is currently required from: Xinghui Lu.
Patch set 2:Code-Review +1
Xinghui Lu (Gerrit)
Aug 9, 2022, 3:20:16 PM8/9/22
to bhatiaro...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org, Rohit Bhatia, Chromium LUCI CQ, chromium...@chromium.org
Attention is currently required from: Xinghui Lu.
Patch set 2:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Aug 9, 2022, 4:11:19 PM8/9/22
to Xinghui Lu, bhatiaro...@chromium.org, dtraino...@chromium.org, xinghui...@chromium.org, Rohit Bhatia, chromium...@chromium.org
Chromium LUCI CQ submitted this change.
Approvals:
Xinghui Lu: Commit
Rohit Bhatia: Looks good to me
[DownloadBubble] Update icon color when the toolbar button disabled
The download icon is not going to disable state when control is on
another window. Fix by setting a different color when the button is
in STATE_DISABLED.
before: http://shortn/_yoDjic6Xhj
after: http://shortn/_u2h8QoMgHb
Bug: 1348147
Change-Id: Ie12aade13fd9150476687c72c52decc7c1e27268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3813960
Commit-Queue: Xinghui Lu <xing...@chromium.org>
Reviewed-by: Rohit Bhatia <bhati...@google.com>
Cr-Commit-Position: refs/heads/main@{#1033170}
---
M chrome/browser/ui/views/download/bubble/download_toolbar_button_view.cc
1 file changed, 47 insertions(+), 16 deletions(-)
Reply all
Reply to author
Forward
0 new messages