Make resolve_dotdot consistent between checkdeps.py and PRESUBMIT.py [chromium/src : main]
0 views
Skip to first unread message
Daniel Rubery (Gerrit)
Sep 25, 2025, 12:28:43 PM (18 hours ago) Sep 25
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Thomas Anderson
Daniel Rubery added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Daniel Rubery . resolved
Relative includes are fairly rare, but we have a few Rust crates that trip over this (see the bug). I do think we should be consistent, but could be convinced to be consistent in either direction.
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Sep 25, 2025, 12:32:39 PM (18 hours ago) Sep 25
to Daniel Rubery, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Daniel Rubery
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Rubery
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Rubery (Gerrit)
Sep 25, 2025, 12:34:04 PM (18 hours ago) Sep 25
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org
Daniel Rubery voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 25, 2025, 12:38:30 PM (18 hours ago) Sep 25
to Daniel Rubery, Thomas Anderson, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Make resolve_dotdot consistent between checkdeps.py and PRESUBMIT.py
Currently, manually running checkdeps.py resolves relative includes. But
the API used by PRESUBMIT.py does not. This means that presubmits can
fail but manual reproduction doesn't work. Since we already can support
relative includes, this CL supports it everywhere.
Bug: 443275577
Change-Id: I415a9a841fadfe36a89a233c21b19761ec7dab54
Commit-Queue: Daniel Rubery <dru...@chromium.org>
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520684}
Files:
- M buildtools/checkdeps/checkdeps.py
Change size: XS
Delta: 1 file changed, 3 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Anderson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages