Roll abseil_revision 8a6b6ae902..892f513289 [chromium/src : main]

0 views
Skip to first unread message

Mirko Bonadei (Gerrit)

unread,
Apr 28, 2026, 9:06:12 AM (7 days ago) Apr 28
to Danil Chapovalov, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Danil Chapovalov

Mirko Bonadei voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Danil Chapovalov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8c8cc9e7d471437f26af3575dcd44389b92ae96b
Gerrit-Change-Number: 7797711
Gerrit-PatchSet: 4
Gerrit-Owner: Mirko Bonadei <mbon...@chromium.org>
Gerrit-Reviewer: Danil Chapovalov <dani...@chromium.org>
Gerrit-Reviewer: Mirko Bonadei <mbon...@chromium.org>
Gerrit-Attention: Danil Chapovalov <dani...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 13:05:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Danil Chapovalov (Gerrit)

unread,
Apr 28, 2026, 9:15:19 AM (7 days ago) Apr 28
to Mirko Bonadei, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Mirko Bonadei

Danil Chapovalov added 2 comments

File third_party/abseil-cpp/BUILD.gn
Line 83, Patchset 4 (Latest): "//third_party/abseil-cpp/absl/functional:bind_front",
Danil Chapovalov . unresolved

bind_back is public, can you please add it to this component.

File third_party/abseil-cpp/absl/functional/bind_back.h
Line 1, Patchset 4 (Latest):// Copyright 2026 The Abseil Authors
Danil Chapovalov . unresolved

disallow inclusion of this file by the 1st party code in the chromium's root DEPS

(might also in a separate change add it to the `styleguide/c++/c++-features.md` as a new api, or, due to similarity to bind_front, update c++-features to mention it next to the bind_front)

Open in Gerrit

Related details

Attention is currently required from:
  • Mirko Bonadei
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8c8cc9e7d471437f26af3575dcd44389b92ae96b
    Gerrit-Change-Number: 7797711
    Gerrit-PatchSet: 4
    Gerrit-Owner: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Reviewer: Danil Chapovalov <dani...@chromium.org>
    Gerrit-Reviewer: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Attention: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Apr 2026 13:14:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mirko Bonadei (Gerrit)

    unread,
    Apr 29, 2026, 8:21:00 AM (6 days ago) Apr 29
    to android-bu...@system.gserviceaccount.com, Danil Chapovalov, Chromium LUCI CQ, chromium...@chromium.org, wfh+...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org
    Attention needed from Danil Chapovalov

    Mirko Bonadei voted and added 2 comments

    Votes added by Mirko Bonadei

    Auto-Submit+1

    2 comments

    File third_party/abseil-cpp/BUILD.gn
    Line 83, Patchset 4: "//third_party/abseil-cpp/absl/functional:bind_front",
    Danil Chapovalov . resolved

    bind_back is public, can you please add it to this component.

    Mirko Bonadei

    Thanks for catching this!

    File third_party/abseil-cpp/absl/functional/bind_back.h
    Line 1, Patchset 4:// Copyright 2026 The Abseil Authors
    Danil Chapovalov . resolved

    disallow inclusion of this file by the 1st party code in the chromium's root DEPS

    (might also in a separate change add it to the `styleguide/c++/c++-features.md` as a new api, or, due to similarity to bind_front, update c++-features to mention it next to the bind_front)

    Mirko Bonadei

    And thanks here as well. I always forget this!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danil Chapovalov
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8c8cc9e7d471437f26af3575dcd44389b92ae96b
    Gerrit-Change-Number: 7797711
    Gerrit-PatchSet: 5
    Gerrit-Owner: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Reviewer: Danil Chapovalov <dani...@chromium.org>
    Gerrit-Reviewer: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Attention: Danil Chapovalov <dani...@chromium.org>
    Gerrit-Comment-Date: Wed, 29 Apr 2026 12:20:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Danil Chapovalov <dani...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Danil Chapovalov (Gerrit)

    unread,
    Apr 29, 2026, 8:22:18 AM (6 days ago) Apr 29
    to Mirko Bonadei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, wfh+...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org
    Attention needed from Mirko Bonadei

    Danil Chapovalov voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mirko Bonadei
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8c8cc9e7d471437f26af3575dcd44389b92ae96b
      Gerrit-Change-Number: 7797711
      Gerrit-PatchSet: 5
      Gerrit-Owner: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Reviewer: Danil Chapovalov <dani...@chromium.org>
      Gerrit-Reviewer: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Attention: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Comment-Date: Wed, 29 Apr 2026 12:22:03 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Mirko Bonadei (Gerrit)

      unread,
      7:40 AM (1 hour ago) 7:40 AM
      to Nico Weber, Danil Chapovalov, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, wfh+...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org
      Attention needed from Nico Weber

      Mirko Bonadei added 1 comment

      Patchset-level comments
      File-level comment, Patchset 5 (Latest):
      Mirko Bonadei . resolved

      Adding Nico for the style guide change.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Nico Weber
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8c8cc9e7d471437f26af3575dcd44389b92ae96b
      Gerrit-Change-Number: 7797711
      Gerrit-PatchSet: 5
      Gerrit-Owner: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Reviewer: Danil Chapovalov <dani...@chromium.org>
      Gerrit-Reviewer: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-Attention: Nico Weber <tha...@chromium.org>
      Gerrit-Comment-Date: Tue, 05 May 2026 11:40:24 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nico Weber (Gerrit)

      unread,
      8:15 AM (27 minutes ago) 8:15 AM
      to Mirko Bonadei, Nico Weber, Danil Chapovalov, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, wfh+...@chromium.org, danakj...@chromium.org, jbrom...@chromium.org
      Attention needed from Mirko Bonadei

      Nico Weber voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Mirko Bonadei
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8c8cc9e7d471437f26af3575dcd44389b92ae96b
      Gerrit-Change-Number: 7797711
      Gerrit-PatchSet: 5
      Gerrit-Owner: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Reviewer: Danil Chapovalov <dani...@chromium.org>
      Gerrit-Reviewer: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-Attention: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Comment-Date: Tue, 05 May 2026 12:15:16 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages