Masa Fujita (Gerrit)

unread,

Jun 6, 2025, 12:51:10 AM6/6/25

to chromium...@chromium.org, chromium-a...@chromium.org, srahim...@chromium.org, extension...@chromium.org

Masa Fujita has uploaded the change for review

Commit message

extensions: Add "Extensions" entry point to three dot menu

This commit adds the "Extensiosn" entry point to the three dot menu on
Desktop Android. The button takes the user to the extensions page
(`chrome://extensions`).

Bug: 422021075

Cq-Include-Trybots: luci.chromium.try:android-desktop-15-x64-rel

Change-Id: Ia5b9bc83256656723c37e4f2e56a0dbc70f5ed05

Change diff

Change information

Files:

M chrome/android/java/res/values/ids.xml
M chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
M chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegateUnitTest.java
M chrome/browser/ui/android/strings/android_chrome_strings.grd
A chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_MENU_EXTENSIONS.png.sha1
M components/browser_ui/styles/android/BUILD.gn
A components/browser_ui/styles/android/java/res/drawable/ic_extension.xml

Change size: M

Delta: 8 files changed, 142 insertions(+), 56 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 6, 2025, 12:52:10 AM6/6/25

to Shuhei Takahashi, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Shuhei Takahashi

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Masa Fujita . resolved

ptal desu!

Open in Gerrit

Related details

Attention is currently required from:

Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 6, 2025, 1:05:55 AM6/6/25

to Chromium LUCI CQ, Shuhei Takahashi, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Shuhei Takahashi

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 6, 2025, 1:09:27 AM6/6/25

to Chromium LUCI CQ, Shuhei Takahashi, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Shuhei Takahashi

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shuhei Takahashi (Gerrit)

unread,

Jun 6, 2025, 1:16:03 AM6/6/25

to Masa Fujita, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Masa Fujita

Shuhei Takahashi voted and added 2 comments

Votes added by Shuhei Takahashi

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Shuhei Takahashi . resolved

Thanks for this patch! LGTM with a non-blocker comment.

File chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java

Line 529, Patchset 3 (Latest): ChromeFeatureList.BLOCK_INSTALLING_EXTENSIONS_ON_DESKTOP_ANDROID);

Shuhei Takahashi . unresolved

[Non-blocker] In crrev.com/c/6622732 we're moving from a feature flag to a hard-coded condition. Let's update this check and the puzzle piece icon to use the new condition soon.

Open in Gerrit

Related details

Attention is currently required from:

Masa Fujita

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 6, 2025, 2:22:11 AM6/6/25

to Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

Commit-Queue

+1

1 comment

File chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java

Line 529, Patchset 3: ChromeFeatureList.BLOCK_INSTALLING_EXTENSIONS_ON_DESKTOP_ANDROID);

Shuhei Takahashi . resolved

[Non-blocker] In crrev.com/c/6622732 we're moving from a feature flag to a hard-coded condition. Let's update this check and the puzzle piece icon to use the new condition soon.

Masa Fujita

Acknowledged

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 6, 2025, 4:13:20 AM6/6/25

to Boris Sazonov, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Shuhei Takahashi

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4:

Masa Fujita . resolved

Hi Boris :) this is a change for desktop android, ptal!

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shuhei Takahashi (Gerrit)

unread,

Jun 8, 2025, 8:01:43 PM6/8/25

to Masa Fujita, Boris Sazonov, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Masa Fujita

Shuhei Takahashi added 1 comment

File chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java

Line 529, Patchset 3: ChromeFeatureList.BLOCK_INSTALLING_EXTENSIONS_ON_DESKTOP_ANDROID);

Shuhei Takahashi . resolved

[Non-blocker] In crrev.com/c/6622732 we're moving from a feature flag to a hard-coded condition. Let's update this check and the puzzle piece icon to use the new condition soon.

Masa Fujita

Acknowledged

Shuhei Takahashi

Filed crbug.com/422934338 to track this issue. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Masa Fujita

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 10, 2025, 7:48:53 AM6/10/25

to Boris Sazonov, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 10, 2025, 8:27:15 AM6/10/25

to Boris Sazonov, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 10, 2025, 8:46:16 AM6/10/25

to Boris Sazonov, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Boris Sazonov (Gerrit)

unread,

Jun 10, 2025, 10:31:19 AM6/10/25

to Masa Fujita, Boris Sazonov, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Masa Fujita and Shuhei Takahashi

Boris Sazonov added 3 comments

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Boris Sazonov . resolved

Overall looks good some minor comments below.

Commit Message

Line 13, Patchset 14 (Latest):Bug: 422021075

Boris Sazonov . unresolved

Can you please add a screenshot of the newly added UI to the bug?

File chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java

Line 2479, Patchset 14 (Latest):

        if (id == R.id.extensions_menu_id) {
            openChromeExtensionsPage();
            return true;
        }

Boris Sazonov . unresolved

Should this be in `ChromeTabbedActivity` instead? In `ChromeTabbedActivity`, you could achieve behavior that is consistent with other similar actions (like Recent tabs), where the URL is opened in the current tab if possible.

Open in Gerrit

Related details

Attention is currently required from:

Masa Fujita
Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 10, 2025, 11:59:23 PM6/10/25

to Boris Sazonov, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Shuhei Takahashi

Masa Fujita added 2 comments

Commit Message

Line 13, Patchset 14:Bug: 422021075

Boris Sazonov . resolved

Can you please add a screenshot of the newly added UI to the bug?

Masa Fujita

Done

File chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java

Line 2479, Patchset 14:

        if (id == R.id.extensions_menu_id) {
            openChromeExtensionsPage();
            return true;
        }

Boris Sazonov . resolved

Should this be in `ChromeTabbedActivity` instead? In `ChromeTabbedActivity`, you could achieve behavior that is consistent with other similar actions (like Recent tabs), where the URL is opened in the current tab if possible.

Masa Fujita

Agreed! done

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 10, 2025, 11:59:30 PM6/10/25

to Boris Sazonov, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Shuhei Takahashi

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 11, 2025, 12:16:29 AM6/11/25

to Chromium Metrics Reviews, AyeAye, Boris Sazonov, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Shuhei Takahashi

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shuhei Takahashi (Gerrit)

unread,

Jun 11, 2025, 12:24:30 AM6/11/25

to Masa Fujita, Shuhei Takahashi, Chromium Metrics Reviews, AyeAye, Boris Sazonov, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Masa Fujita

Shuhei Takahashi voted and added 2 comments

Votes added by Shuhei Takahashi

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 16 (Latest):

Shuhei Takahashi . resolved

Just one minor comment. Thanks!

File chrome/android/junit/BUILD.gn

Line 1049, Patchset 16 (Latest): "//chrome/browser/ui/android/extensions:java",

Shuhei Takahashi . unresolved

I think we should add this dep to `public_deps` of `:chrome_junit_tests_helper`.

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Masa Fujita

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 11, 2025, 1:05:48 AM6/11/25

to Shuhei Takahashi, Chromium Metrics Reviews, AyeAye, Boris Sazonov, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Shuhei Takahashi

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

Commit-Queue

+1

1 comment

File chrome/android/junit/BUILD.gn

Line 1049, Patchset 16: "//chrome/browser/ui/android/extensions:java",

Shuhei Takahashi . resolved

I think we should add this dep to `public_deps` of `:chrome_junit_tests_helper`.

Masa Fujita

Done

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shuhei Takahashi (Gerrit)

unread,

Jun 11, 2025, 1:15:18 AM6/11/25

to Masa Fujita, Shuhei Takahashi, Chromium Metrics Reviews, AyeAye, Boris Sazonov, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Masa Fujita

Shuhei Takahashi voted and added 1 comment

Votes added by Shuhei Takahashi

Code-Review

+1

1 comment

File chrome/android/junit/BUILD.gn

Line 1048, Patchset 17 (Latest): deps = [

Shuhei Takahashi . unresolved

nit: Can you revert the style change here to minimize the diff?

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Masa Fujita

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 11, 2025, 1:20:31 AM6/11/25

to Shuhei Takahashi, Chromium Metrics Reviews, AyeAye, Boris Sazonov, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Shuhei Takahashi

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 11, 2025, 1:20:33 AM6/11/25

to Shuhei Takahashi, Chromium Metrics Reviews, AyeAye, Boris Sazonov, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Shuhei Takahashi

Masa Fujita added 1 comment

File chrome/android/junit/BUILD.gn

Line 1048, Patchset 17: deps = [

Shuhei Takahashi . resolved

nit: Can you revert the style change here to minimize the diff?

Masa Fujita

Done - so sorry for so many oversights :(

satisfied_requirement

unsatisfied_requirement

open

diffy

Shuhei Takahashi (Gerrit)

unread,

Jun 11, 2025, 2:00:33 AM6/11/25

to Masa Fujita, Shuhei Takahashi, Chromium Metrics Reviews, AyeAye, Boris Sazonov, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Masa Fujita

Shuhei Takahashi voted and added 1 comment

Votes added by Shuhei Takahashi

Code-Review

+1

1 comment

File chrome/android/junit/BUILD.gn

Line 1048, Patchset 17: deps = [

Shuhei Takahashi . resolved

nit: Can you revert the style change here to minimize the diff?

Masa Fujita

Done - so sorry for so many oversights :(

Shuhei Takahashi

No problem!

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Masa Fujita

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Boris Sazonov (Gerrit)

unread,

Jun 11, 2025, 10:46:30 AM6/11/25

to Masa Fujita, Shuhei Takahashi, Chromium Metrics Reviews, AyeAye, Boris Sazonov, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Masa Fujita

Boris Sazonov added 2 comments

File components/browser_ui/styles/android/BUILD.gn

Line 193, Patchset 18 (Latest): "java/res/drawable/ic_extension.xml",

Boris Sazonov . unresolved

For consistency with other drawables please consider adding a size suffix (`s/ic_extension/ic_extension_24/`).

File tools/metrics/actions/actions.xml

Line 24430, Patchset 18 (Latest): <owner>mas...@google.com</owner>

Boris Sazonov . unresolved

Please consider adding a second owner for this metric.

From https://chromium.googlesource.com/chromium/src/+/main/tools/metrics/actions/README.md#owners:

The primary owner must be an individual, who is ultimately responsible for the metric. It‘s a best practice to list multiple owners, which makes it less likely that maintenance tasks will slip through the cracks. This is important because the metrics team may file bugs related to user actions, and such bugs need to be triaged by someone familiar with the metric. If an appropriate mailing list or team email is available, it’s a good idea to list it as a secondary owner.

Open in Gerrit

Related details

Attention is currently required from:

Masa Fujita

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 12, 2025, 5:34:32 AM6/12/25

to Shuhei Takahashi, Chromium Metrics Reviews, AyeAye, Boris Sazonov, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Shuhei Takahashi

Masa Fujita voted and added 2 comments

Votes added by Masa Fujita

Commit-Queue

+1

2 comments

File components/browser_ui/styles/android/BUILD.gn

Line 193, Patchset 18: "java/res/drawable/ic_extension.xml",

Boris Sazonov . resolved

For consistency with other drawables please consider adding a size suffix (`s/ic_extension/ic_extension_24/`).

Masa Fujita

Done

File tools/metrics/actions/actions.xml

Line 24430, Patchset 18: <owner>mas...@google.com</owner>

Boris Sazonov . resolved

Please consider adding a second owner for this metric.
From https://chromium.googlesource.com/chromium/src/+/main/tools/metrics/actions/README.md#owners:
The primary owner must be an individual, who is ultimately responsible for the metric. It‘s a best practice to list multiple owners, which makes it less likely that maintenance tasks will slip through the cracks. This is important because the metrics team may file bugs related to user actions, and such bugs need to be triaged by someone familiar with the metric. If an appropriate mailing list or team email is available, it’s a good idea to list it as a secondary owner.

Masa Fujita

Done

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 12, 2025, 8:58:29 AM6/12/25

to Shuhei Takahashi, Chromium Metrics Reviews, AyeAye, Boris Sazonov, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Boris Sazonov and Shuhei Takahashi

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Boris Sazonov
Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Boris Sazonov (Gerrit)

unread,

Jun 13, 2025, 6:11:02 AM6/13/25

to Masa Fujita, Boris Sazonov, Shuhei Takahashi, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Masa Fujita and Shuhei Takahashi

Boris Sazonov voted and added 1 comment

Votes added by Boris Sazonov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 22 (Latest):

Boris Sazonov . resolved

LGTM, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Masa Fujita
Shuhei Takahashi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shuhei Takahashi (Gerrit)

unread,

Jun 16, 2025, 12:28:43 AM6/16/25

to Masa Fujita, Shuhei Takahashi, Boris Sazonov, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Attention needed from Masa Fujita

Shuhei Takahashi voted and added 1 comment

Votes added by Shuhei Takahashi

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 22 (Latest):

Shuhei Takahashi . resolved

Sorry for the delay!

Open in Gerrit

Related details

Attention is currently required from:

Masa Fujita

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

Jun 16, 2025, 1:54:15 AM6/16/25

to Shuhei Takahashi, Boris Sazonov, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

Auto-Submit	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 23 (Latest):

Masa Fujita . resolved

Thank you for the review!

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 16, 2025, 3:12:04 AM6/16/25

to Masa Fujita, Shuhei Takahashi, Boris Sazonov, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, srahim...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

22 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

extensions: Add "Extensions" entry point to three dot menu

This commit adds the "Extensiosn" entry point to the three dot menu on
Desktop Android. The button takes the user to the extensions page
(`chrome://extensions`).

Bug: 422021075

Cq-Include-Trybots: luci.chromium.try:android-desktop-15-x64-rel

Change-Id: Ia5b9bc83256656723c37e4f2e56a0dbc70f5ed05

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6627013

Reviewed-by: Boris Sazonov <bsaz...@chromium.org>

Reviewed-by: Shuhei Takahashi <n...@chromium.org>

Auto-Submit: Masa Fujita <mas...@google.com>

Commit-Queue: Masa Fujita <mas...@google.com>

Cr-Commit-Position: refs/heads/main@{#1474173}

Files:

M chrome/android/java/res/values/ids.xml
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
M chrome/android/junit/BUILD.gn
M chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegateUnitTest.java
M chrome/browser/ui/android/strings/android_chrome_strings.grd
A chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_MENU_EXTENSIONS.png.sha1
M components/browser_ui/styles/android/BUILD.gn
A components/browser_ui/styles/android/java/res/drawable/ic_extension_24dp.xml
M tools/metrics/actions/actions.xml

Change size: L

Delta: 10 files changed, 172 insertions(+), 78 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Boris Sazonov, +1 by Shuhei Takahashi

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

extensions: Add "Extensions" entry point to three dot menu [chromium/src : main]

Masa Fujita (Gerrit)

Masa Fujita has uploaded the change for review

Commit message

Change diff

Change information

Related details

Masa Fujita (Gerrit)

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

1 comment

Related details

Masa Fujita (Gerrit)

Masa Fujita voted Commit-Queue+1

Related details

Masa Fujita (Gerrit)

Masa Fujita voted Commit-Queue+1

Related details

Shuhei Takahashi (Gerrit)

Shuhei Takahashi voted and added 2 comments

Votes added by Shuhei Takahashi

2 comments

Related details

Masa Fujita (Gerrit)

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

1 comment

Related details

Masa Fujita (Gerrit)

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

1 comment

Related details

Shuhei Takahashi (Gerrit)

Shuhei Takahashi added 1 comment

Related details

Masa Fujita (Gerrit)

Masa Fujita voted Commit-Queue+1

Related details

Masa Fujita (Gerrit)

Masa Fujita voted Commit-Queue+1

Related details

Masa Fujita (Gerrit)

Masa Fujita voted Commit-Queue+1

Related details

Boris Sazonov (Gerrit)

Boris Sazonov added 3 comments

Related details

Masa Fujita (Gerrit)

Masa Fujita added 2 comments

Related details

Masa Fujita (Gerrit)

Masa Fujita voted Commit-Queue+1

Related details

Masa Fujita (Gerrit)

Masa Fujita voted Commit-Queue+1

Related details

Shuhei Takahashi (Gerrit)

Shuhei Takahashi voted and added 2 comments

Votes added by Shuhei Takahashi

2 comments

Related details

Masa Fujita (Gerrit)

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

1 comment

Related details

Shuhei Takahashi (Gerrit)

Shuhei Takahashi voted and added 1 comment

Votes added by Shuhei Takahashi

1 comment

Related details

Masa Fujita (Gerrit)

Masa Fujita voted Commit-Queue+1

Related details

Masa Fujita (Gerrit)

Masa Fujita added 1 comment

Shuhei Takahashi (Gerrit)

Shuhei Takahashi voted and added 1 comment

Votes added by Shuhei Takahashi