[iOS] Move fieldWasEditedByUser out of gCrWeb [chromium/src : main]

0 views
Skip to first unread message

Alexandra Pereira (Gerrit)

unread,
9:47 AM (14 hours ago) 9:47 AM
to Vincent Boisselle, Mike Dougherty, Daniel White, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Vincent Boisselle

Alexandra Pereira voted and added 1 comment

Votes added by Alexandra Pereira

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Alexandra Pereira . resolved

Hi, PTAL. Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Vincent Boisselle
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I51a59064c4071fef04f007e07d7cbc1874b4606e
Gerrit-Change-Number: 7254115
Gerrit-PatchSet: 5
Gerrit-Owner: Alexandra Pereira <alexa...@google.com>
Gerrit-Reviewer: Alexandra Pereira <alexa...@google.com>
Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
Gerrit-CC: Daniel White <daniel...@google.com>
Gerrit-CC: Mike Dougherty <mich...@chromium.org>
Gerrit-Attention: Vincent Boisselle <vi...@google.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 14:47:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Vincent Boisselle (Gerrit)

unread,
1:51 PM (10 hours ago) 1:51 PM
to Alexandra Pereira, Mike Dougherty, Daniel White, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Alexandra Pereira

Vincent Boisselle added 1 comment

File components/autofill/ios/form_util/resources/fill_web_form.ts
Line 16, Patchset 5 (Latest): document.__gCrWasEditedByUserMap = new WeakMap();
Vincent Boisselle . unresolved

Can we make this a property?

Open in Gerrit

Related details

Attention is currently required from:
  • Alexandra Pereira
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I51a59064c4071fef04f007e07d7cbc1874b4606e
    Gerrit-Change-Number: 7254115
    Gerrit-PatchSet: 5
    Gerrit-Owner: Alexandra Pereira <alexa...@google.com>
    Gerrit-Reviewer: Alexandra Pereira <alexa...@google.com>
    Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
    Gerrit-CC: Daniel White <daniel...@google.com>
    Gerrit-CC: Mike Dougherty <mich...@chromium.org>
    Gerrit-Attention: Alexandra Pereira <alexa...@google.com>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 18:51:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alexandra Pereira (Gerrit)

    unread,
    2:53 PM (9 hours ago) 2:53 PM
    to Vincent Boisselle, Mike Dougherty, Daniel White, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Vincent Boisselle

    Alexandra Pereira added 1 comment

    File components/autofill/ios/form_util/resources/fill_web_form.ts
    Line 16, Patchset 5 (Latest): document.__gCrWasEditedByUserMap = new WeakMap();
    Vincent Boisselle . unresolved

    Can we make this a property?

    Alexandra Pereira

    We could do that, but is there a specific reason to make this a property? I removed it from the gCrWeb object to follow the same logic as other variables and functions. Since we aren't using this property on the native side, I defined it as a global in the document.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vincent Boisselle
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I51a59064c4071fef04f007e07d7cbc1874b4606e
    Gerrit-Change-Number: 7254115
    Gerrit-PatchSet: 5
    Gerrit-Owner: Alexandra Pereira <alexa...@google.com>
    Gerrit-Reviewer: Alexandra Pereira <alexa...@google.com>
    Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
    Gerrit-CC: Daniel White <daniel...@google.com>
    Gerrit-CC: Mike Dougherty <mich...@chromium.org>
    Gerrit-Attention: Vincent Boisselle <vi...@google.com>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 19:53:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Vincent Boisselle <vi...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vincent Boisselle (Gerrit)

    unread,
    5:11 PM (7 hours ago) 5:11 PM
    to Alexandra Pereira, Mike Dougherty, Daniel White, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Alexandra Pereira

    Vincent Boisselle voted and added 1 comment

    Votes added by Vincent Boisselle

    Code-Review+1

    1 comment

    File components/autofill/ios/form_util/resources/fill_web_form.ts
    Line 16, Patchset 5 (Latest): document.__gCrWasEditedByUserMap = new WeakMap();
    Vincent Boisselle . resolved

    Can we make this a property?

    Alexandra Pereira

    We could do that, but is there a specific reason to make this a property? I removed it from the gCrWeb object to follow the same logic as other variables and functions. Since we aren't using this property on the native side, I defined it as a global in the document.

    Vincent Boisselle

    ah, you mean, since this is "a local" (not shared across JS featureS) global ?

    idk what are the best practices regarding that :) , I was just wondering

    up to you, we are in the isolated world, so adding internal properties to the document looks fine

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexandra Pereira
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I51a59064c4071fef04f007e07d7cbc1874b4606e
    Gerrit-Change-Number: 7254115
    Gerrit-PatchSet: 5
    Gerrit-Owner: Alexandra Pereira <alexa...@google.com>
    Gerrit-Reviewer: Alexandra Pereira <alexa...@google.com>
    Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
    Gerrit-CC: Daniel White <daniel...@google.com>
    Gerrit-CC: Mike Dougherty <mich...@chromium.org>
    Gerrit-Attention: Alexandra Pereira <alexa...@google.com>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 22:10:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Alexandra Pereira <alexa...@google.com>
    Comment-In-Reply-To: Vincent Boisselle <vi...@google.com>
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages