Clean up UserPrefs DCHECKs and destroy Java PrefChangeRegistrars [chromium/src : main]

0 views
Skip to first unread message

Xinyi Ji (Gerrit)

unread,
7:22 PM (2 hours ago) 7:22 PM
to Jenna Himawan, Dominic Battré, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, hanxi...@chromium.org
Attention needed from Dominic Battré and Jenna Himawan

Xinyi Ji added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Xinyi Ji . unresolved

Hi Jenna, I was looking at your CL and started to investigate this bug this afternoon. I have a question—NtpCustomizationPolicyManager.java has been around for a while (since January 2026), so I'm not sure why this crash is starting surface now in M151 or how it connects to my recent refactor CLs. Do you know what's triggering it in this milestone? I want to make sure I fully understand what's happening so we don't miss anything in the fix. 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Battré
  • Jenna Himawan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7b2a9119d991db61377f1deb21993e21207a2fa0
Gerrit-Change-Number: 8127213
Gerrit-PatchSet: 1
Gerrit-Owner: Jenna Himawan <jhim...@google.com>
Gerrit-Reviewer: Dominic Battré <bat...@chromium.org>
Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
Gerrit-Reviewer: Xinyi Ji <xin...@chromium.org>
Gerrit-Attention: Dominic Battré <bat...@chromium.org>
Gerrit-Attention: Jenna Himawan <jhim...@google.com>
Gerrit-Comment-Date: Wed, 22 Jul 2026 23:22:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jenna Himawan (Gerrit)

unread,
8:05 PM (1 hour ago) 8:05 PM
to Xinyi Ji, Dominic Battré, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, hanxi...@chromium.org
Attention needed from Dominic Battré and Xinyi Ji

Jenna Himawan added 1 comment

Patchset-level comments
Xinyi Ji . unresolved

Hi Jenna, I was looking at your CL and started to investigate this bug this afternoon. I have a question—NtpCustomizationPolicyManager.java has been around for a while (since January 2026), so I'm not sure why this crash is starting surface now in M151 or how it connects to my recent refactor CLs. Do you know what's triggering it in this milestone? I want to make sure I fully understand what's happening so we don't miss anything in the fix. 😊

Jenna Himawan

Responded in the bug.

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Battré
  • Xinyi Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7b2a9119d991db61377f1deb21993e21207a2fa0
Gerrit-Change-Number: 8127213
Gerrit-PatchSet: 1
Gerrit-Owner: Jenna Himawan <jhim...@google.com>
Gerrit-Reviewer: Dominic Battré <bat...@chromium.org>
Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
Gerrit-Reviewer: Xinyi Ji <xin...@chromium.org>
Gerrit-Attention: Dominic Battré <bat...@chromium.org>
Gerrit-Attention: Xinyi Ji <xin...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Jul 2026 00:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xinyi Ji <xin...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages