Implement TabListInterface::GetTabGroupTabIndices() for desktop Android [chromium/src : main]

[James Cook (Gerrit)]

Attention needed from Calder Kitagawa

James Cook voted and added 2 comments

Votes added by James Cook

Commit-Queue

+1

2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

James Cook . resolved

Calder, can you take a look? This is part of the project to bring extensions to desktop Android. Thanks.

File chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCollectionTabModelImpl.java

Line 869, Patchset 2 (Latest): return new int[] {firstIndex, lastIndex + 1};

James Cook . unresolved

The `lastIndex + 1` is a little odd, but apparently we use non-inclusive tab index ranges for tab groups.

https://source.chromium.org/chromium/chromium/src/+/main:components/tabs/impl/tab_group.cc;drc=fcc336e81a365fd858cae859059b29be8f995427;l=124

Open in Gerrit

Related details

Attention is currently required from:

• Calder Kitagawa

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I7a74e1923efbdd67cbb60aff55ab1f6d2d97d3b0

Gerrit-Change-Number: 7427975

Gerrit-PatchSet: 2

Gerrit-Owner: James Cook <jame...@chromium.org>

Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>

Gerrit-Reviewer: James Cook <jame...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>

Gerrit-Comment-Date: Sat, 10 Jan 2026 02:13:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes