[SxS] Redirect to regular NTP if split NTP is empty [chromium/src : main]

0 views
Skip to first unread message

Alison Gale (Gerrit)

unread,
Sep 24, 2025, 7:14:45 PM (2 days ago) Sep 24
to Yuheng Huang, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Yuheng Huang

Alison Gale voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yuheng Huang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia757b8618cf2594a20b36fe644276f648004e086
Gerrit-Change-Number: 6981711
Gerrit-PatchSet: 1
Gerrit-Owner: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
Gerrit-Attention: Yuheng Huang <yuh...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Sep 2025 23:14:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuheng Huang (Gerrit)

unread,
Sep 25, 2025, 11:49:25 AM (13 hours ago) Sep 25
to Alison Gale, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Alison Gale

Yuheng Huang voted and added 1 comment

Votes added by Yuheng Huang

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Yuheng Huang . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Gale
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia757b8618cf2594a20b36fe644276f648004e086
    Gerrit-Change-Number: 6981711
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
    Gerrit-Attention: Alison Gale <ag...@chromium.org>
    Gerrit-Comment-Date: Thu, 25 Sep 2025 15:49:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Alison Gale (Gerrit)

    unread,
    Sep 25, 2025, 12:04:59 PM (13 hours ago) Sep 25
    to Yuheng Huang, Chromium LUCI CQ, chromium...@chromium.org

    Alison Gale voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia757b8618cf2594a20b36fe644276f648004e086
    Gerrit-Change-Number: 6981711
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
    Gerrit-Comment-Date: Thu, 25 Sep 2025 16:04:48 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 25, 2025, 12:13:13 PM (13 hours ago) Sep 25
    to Alison Gale, Yuheng Huang, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [SxS] Redirect to regular NTP if split NTP is empty
    Bug: 439627836
    Change-Id: Ia757b8618cf2594a20b36fe644276f648004e086
    Reviewed-by: Yuheng Huang <yuh...@chromium.org>
    Commit-Queue: Alison Gale <ag...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1520663}
    Files:
    • M chrome/browser/resources/tab_search/split_view/app.ts
    Change size: XS
    Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yuheng Huang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia757b8618cf2594a20b36fe644276f648004e086
    Gerrit-Change-Number: 6981711
    Gerrit-PatchSet: 2
    Gerrit-Owner: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages