Add flag --use-skia-deferred-display-list [chromium/src : master]

Peng Huang (Gerrit)

unread,

Mar 21, 2018, 3:19:15 PM3/21/18

to Sadrul Chowdhury, Robert Kroeger, Daniel Cheng, cc-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Darin Fisher, chromium...@chromium.org, Commit Bot, Aaron Boodman

Peng Huang uploaded patch set #5 to this change.

View Change

Add flag --use-skia-deferred-display-list

Also pass the flag to viz via RendererSettings.

This CL is part of CL https://crrev.com/c/947047 which makes
SkiaRenderer use Skia DDL to render frames.

Bug: 824382
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I1d9487afd4fd15925acad234916ebedf6292e7bb
---
M components/viz/common/display/renderer_settings.h
M components/viz/host/renderer_settings_creation.cc
M services/viz/privileged/interfaces/compositing/renderer_settings.mojom
M services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.cc
M services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.h
M ui/base/ui_base_switches.cc
M ui/base/ui_base_switches.h
7 files changed, 15 insertions(+), 0 deletions(-)

To view, visit change 973802. To unsubscribe, or for help writing mail filters, visit settings.

Peng Huang (Gerrit)

unread,

Mar 21, 2018, 3:19:28 PM3/21/18

to cc-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Daniel Cheng, Sadrul Chowdhury, Robert Kroeger, Commit Bot, Aaron Boodman, chromium...@chromium.org, Darin Fisher

View Change

1 comment:

File services/viz/privileged/interfaces/compositing/renderer_settings.mojom:
- Patch Set #3, Line 21: bool use_skia_deferred_display_list;
  Well, I'm just going off what the C++ style guide says: https://google.github. […]
  Done

To view, visit change 973802. To unsubscribe, or for help writing mail filters, visit settings.

Sadrul Chowdhury (Gerrit)

unread,

Mar 21, 2018, 4:25:19 PM3/21/18

to Peng Huang, cc-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Daniel Cheng, Robert Kroeger, Commit Bot, Aaron Boodman, chromium...@chromium.org, Darin Fisher

Patch set 5:Code-Review +1

View Change

1 comment:

File ui/base/ui_base_switches.cc:
- Patch Set #5, Line 101: // frames to Skia DDLs and play them back on the GPU thread
  Does this imply --use-skia-renderer? Or does that have to be explicitly included in the command-line? Can you update the comment to mention that?

To view, visit change 973802. To unsubscribe, or for help writing mail filters, visit settings.

Peng Huang (Gerrit)

unread,

Mar 21, 2018, 5:36:39 PM3/21/18

to cc-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Sadrul Chowdhury, Daniel Cheng, Robert Kroeger, Commit Bot, Aaron Boodman, chromium...@chromium.org, Darin Fisher

Patch set 6:Commit-Queue +2

View Change

To view, visit change 973802. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Mar 21, 2018, 5:36:44 PM3/21/18

to Peng Huang, cc-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Sadrul Chowdhury, Daniel Cheng, Robert Kroeger, Aaron Boodman, chromium...@chromium.org, Darin Fisher

CQ is trying the patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"Address a review issue." https://chromium-review.googlesource.com/c/973802/6

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/973802/6

Bot data: {"action": "start", "triggered_at": "2018-03-21T21:36:36.0Z", "cq_cfg_revision": "5b6c43e4d6b0297aa92e118e785d640c42297271", "revision": "15f84336d64b7b8a6a91854acd0d25dfcea8fd7e"}

View Change

To view, visit change 973802. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Mar 21, 2018, 6:49:27 PM3/21/18

to Peng Huang, cc-...@chromium.org, ipc-securi...@chromium.org, qsr+...@chromium.org, viettrung...@chromium.org, Sadrul Chowdhury, Daniel Cheng, Robert Kroeger, Aaron Boodman, chromium...@chromium.org, Darin Fisher

Commit Bot merged this change.

View Change

Approvals:
  Sadrul Chowdhury: Looks good to me
  Robert Kroeger: Looks good to me
  Daniel Cheng: Looks good to me
  Peng Huang: Commit

Add flag --use-skia-deferred-display-list

Also pass the flag to viz via RendererSettings.

This CL is part of CL https://crrev.com/c/947047 which makes
SkiaRenderer use Skia DDL to render frames.

Bug: 824382
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I1d9487afd4fd15925acad234916ebedf6292e7bb

Reviewed-on: https://chromium-review.googlesource.com/973802
Commit-Queue: Peng Huang <peng...@chromium.org>
Reviewed-by: Sadrul Chowdhury <sad...@chromium.org>
Reviewed-by: Robert Kroeger <rjkr...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544887}


---
M components/viz/common/display/renderer_settings.h
M components/viz/host/renderer_settings_creation.cc
M services/viz/privileged/interfaces/compositing/renderer_settings.mojom
M services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.cc
M services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.h
M ui/base/ui_base_switches.cc
M ui/base/ui_base_switches.h

7 files changed, 16 insertions(+), 0 deletions(-)

To view, visit change 973802. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward