Enable deep scanning for ESB users by default [chromium/src : main]

1 view
Skip to first unread message

Daniel Rubery (Gerrit)

unread,
Jun 24, 2021, 2:02:41 PM6/24/21
to druber...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Xinghui Lu, chromium...@chromium.org, Tim Volodine

Attention is currently required from: Xinghui Lu.

Patch set 1:Auto-Submit +1Commit-Queue +1

View Change

    To view, visit change 2983244. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie8075f5ab726cadeda269a27b8aada2d87ec0ed8
    Gerrit-Change-Number: 2983244
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
    Gerrit-CC: Tim Volodine <timvo...@chromium.org>
    Gerrit-Attention: Xinghui Lu <xing...@chromium.org>
    Gerrit-Comment-Date: Thu, 24 Jun 2021 18:02:31 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Xinghui Lu (Gerrit)

    unread,
    Jun 24, 2021, 6:29:11 PM6/24/21
    to Daniel Rubery, druber...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Tim Volodine

    Attention is currently required from: Daniel Rubery.

    View Change

    1 comment:

    • Patchset:

      • Patch Set #1:

        Looks like some tests failed. You may want to disable the feature flag explicitly in some tests.

    To view, visit change 2983244. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie8075f5ab726cadeda269a27b8aada2d87ec0ed8
    Gerrit-Change-Number: 2983244
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
    Gerrit-CC: Tim Volodine <timvo...@chromium.org>
    Gerrit-Attention: Daniel Rubery <dru...@chromium.org>
    Gerrit-Comment-Date: Thu, 24 Jun 2021 22:29:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Daniel Rubery (Gerrit)

    unread,
    Jun 25, 2021, 4:04:57 PM6/25/21
    to druber...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Chromium LUCI CQ, Xinghui Lu, chromium...@chromium.org, Tim Volodine

    View Change

    1 comment:

    • Patchset:

      • Patch Set #4:

        Alright, looks like tests are passing now. Can you take another look?

    To view, visit change 2983244. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie8075f5ab726cadeda269a27b8aada2d87ec0ed8
    Gerrit-Change-Number: 2983244
    Gerrit-PatchSet: 4
    Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
    Gerrit-CC: Tim Volodine <timvo...@chromium.org>
    Gerrit-Comment-Date: Fri, 25 Jun 2021 20:04:48 +0000

    Xinghui Lu (Gerrit)

    unread,
    Jun 25, 2021, 9:33:16 PM6/25/21
    to Daniel Rubery, druber...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Tim Volodine

    Attention is currently required from: Daniel Rubery.

    Patch set 4:Code-Review +1Commit-Queue +2

    View Change

      To view, visit change 2983244. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie8075f5ab726cadeda269a27b8aada2d87ec0ed8
      Gerrit-Change-Number: 2983244
      Gerrit-PatchSet: 4
      Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
      Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
      Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
      Gerrit-CC: Tim Volodine <timvo...@chromium.org>
      Gerrit-Attention: Daniel Rubery <dru...@chromium.org>
      Gerrit-Comment-Date: Sat, 26 Jun 2021 01:33:08 +0000

      Chromium LUCI CQ (Gerrit)

      unread,
      Jun 25, 2021, 9:37:18 PM6/25/21
      to Daniel Rubery, druber...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Xinghui Lu, chromium...@chromium.org, Tim Volodine

      Chromium LUCI CQ submitted this change.

      View Change

      Approvals: Xinghui Lu: Looks good to me; Commit Daniel Rubery: Send CL to CQ automatically after approval
      Enable deep scanning for ESB users by default

      This experiment is ready to launch to 100% Stable, so enable it by
      default at HEAD. This CL also removes some tests that verified the
      proper functioning of the feature flag by enforcing the old behavior.

      Bug: 1186736
      Change-Id: Ie8075f5ab726cadeda269a27b8aada2d87ec0ed8
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2983244
      Auto-Submit: Daniel Rubery <dru...@chromium.org>
      Commit-Queue: Xinghui Lu <xing...@chromium.org>
      Reviewed-by: Xinghui Lu <xing...@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#896293}
      ---
      M chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service_unittest.cc
      M chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
      M components/safe_browsing/core/features.cc
      3 files changed, 5 insertions(+), 134 deletions(-)


      To view, visit change 2983244. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie8075f5ab726cadeda269a27b8aada2d87ec0ed8
      Gerrit-Change-Number: 2983244
      Gerrit-PatchSet: 5
      Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
      Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
      Gerrit-CC: Tim Volodine <timvo...@chromium.org>
      Gerrit-MessageType: merged
      Reply all
      Reply to author
      Forward
      0 new messages