Revert "Cap max framebuffer scale on low memory devices" [chromium/src : main]
0 views
Skip to first unread message
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jul 17, 2026, 10:39:29 PM (2 days ago) Jul 17
to Chromium LUCI CQ, Brandon Jones, Alexander Cooper, Alex Gough, android-bu...@system.gserviceaccount.com, chromium...@chromium.org
Attention needed from Alex Gough, Alexander Cooper and Brandon Jones
luci-bi...@appspot.gserviceaccount.com has uploaded the change for review![]( "Open in Gerrit")
luci-bi...@appspot.gserviceaccount.com would like Chromium LUCI CQ, Brandon Jones, Alexander Cooper and Alex Gough to review this change.
Commit message
Revert "Cap max framebuffer scale on low memory devices"
This reverts commit 697ff29e454aa1f6e5b9f72843b28f0bd87972ed.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5742158435844096
Sample build with failed test: https://ci.chromium.org/b/8675986733143023537
Affected test(s):
[://chrome/test\:android_browsertests!gtest::WebXrVrOpenXrBrowserTest#TestControllerPositionTracking](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:android_browsertests%21gtest::WebXrVrOpenXrBrowserTest%23TestControllerPositionTracking?q=VHash%3A42efea5f2f5f129e)
[://chrome/test\:android_browsertests!gtest::WebXrVrOpenXrBrowserTest#TestLayers](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:android_browsertests%21gtest::WebXrVrOpenXrBrowserTest%23TestLayers?q=VHash%3A42efea5f2f5f129e)
[://chrome/test\:android_browsertests!gtest::WebXrVrOpenXrBrowserTest#TestLocationIndicatorWhenUserAskedToPrompt](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:android_browsertests%21gtest::WebXrVrOpenXrBrowserTest%23TestLocationIndicatorWhenUserAskedToPrompt?q=VHash%3A42efea5f2f5f129e)
[://chrome/test\:android_browsertests!gtest::WebXrVrOpenXrBrowserTest#TestProfilesFixedHand](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:android_browsertests%21gtest::WebXrVrOpenXrBrowserTest%23TestProfilesFixedHand?q=VHash%3A42efea5f2f5f129e)
[://chrome/test\:android_browsertests!gtest::WebXrVrOpenXrBrowserTest#TestSessionExited](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:android_browsertests%21gtest::WebXrVrOpenXrBrowserTest%23TestSessionExited?q=VHash%3A42efea5f2f5f129e)
and 2 more ...
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5742158435844096&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8102711&type=BUG
Original change's description:
> Cap max framebuffer scale on low memory devices
>
> When calculating maximum view dimensions in OpenXrViewProperties,
> scale recommended dimensions by a uniform scale factor to ensure the
> per-view optical aspect ratio is preserved.
>
> Additionally:
> - Limit maximum framebuffer scale to 1.5xrecommended size on
> low-memory devices (<= 8GB physical RAM) to prevent Out-Of-Memory
> (OOM) crashes on devices such as Quest 2 and 3S.
> - Support `--webxr-max-framebuffer-scale` command-line switch override
> for testing and development.
> - Forward `--webxr-max-framebuffer-scale` switch to utility processes in
> utility_process_host.cc.
> - Add unit tests for OpenXrViewProperties to verify aspect ratio
> logic, low-memory capping, and switch overrides.
>
> TAG=agy
>
> Bug: 530457803
> Change-Id: I2a0bad01689c850305fc265f9f031c2b3ec6ad38
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8102711
> Reviewed-by: Brandon Jones <baj...@chromium.org>
> Reviewed-by: Alex Gough <aj...@chromium.org>
> Commit-Queue: Alexander Cooper <alco...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1664241}
>
Bug: 530457803
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I278c40ac569d27f7236041f58a472ae2c24f51c4
Change diff
Change information
Files:
- M content/browser/service_host/utility_process_host.cc
- M device/BUILD.gn
- M device/vr/BUILD.gn
- M device/vr/openxr/openxr_view_configuration.cc
- M device/vr/openxr/openxr_view_configuration.h
- D device/vr/openxr/openxr_view_configuration_unittest.cc
- M device/vr/public/cpp/switches.cc
- M device/vr/public/cpp/switches.h
- M third_party/openxr/BUILD.gn
Change size: L
Delta: 9 files changed, 36 insertions(+), 296 deletions(-)
Related details
Attention is currently required from:
- Alex Gough
- Alexander Cooper
- Brandon Jones
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jul 17, 2026, 10:39:52 PM (2 days ago) Jul 17
to rubber-...@appspot.gserviceaccount.com, Chromium LUCI CQ, Brandon Jones, Alexander Cooper, Alex Gough, android-bu...@system.gserviceaccount.com, chromium...@chromium.org
Attention needed from Alex Gough, Alexander Cooper and Brandon Jones
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.
Related details
Attention is currently required from:
- Alex Gough
- Alexander Cooper
- Brandon Jones
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Jul 17, 2026, 10:40:17 PM (2 days ago) Jul 17
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Brandon Jones, Alexander Cooper, Alex Gough, android-bu...@system.gserviceaccount.com, chromium...@chromium.org
Attention needed from Alex Gough, Alexander Cooper and Brandon Jones
rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Alex Gough
- Alexander Cooper
- Brandon Jones
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Gough (Gerrit)
Jul 18, 2026, 3:38:57 PM (16 hours ago) Jul 18
to luci-bi...@appspot.gserviceaccount.com, Alex Gough, rubber-...@appspot.gserviceaccount.com, Chromium LUCI CQ, Brandon Jones, Alexander Cooper, android-bu...@system.gserviceaccount.com, chromium...@chromium.org
Attention needed from Alexander Cooper and Brandon Jones
Alex Gough voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Cooper
- Brandon Jones
Reply all
Reply to author
Forward
0 new messages