Ash: Move local auth factors notification to MessageCenter [chromium/src : main]

0 views

Skip to first unread message

unread,

1:47 AM (18 hours ago) 1:47 AM

to Di Wu, Chromium LUCI CQ, chromium...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org

Attention needed from Di Wu

Georg Neis added 3 comments

Patchset-level comments

Georg Neis . unresolved

Same question as in the other CLs: what happens when the user logs out?

File chrome/browser/ash/login/auth_factors_policy/local_auth_factors_policy_controller.cc

Line 134, Patchset 4 (Latest): const user_manager::User& user)

Georg Neis . unresolved

Can we get this from the profile or at least add an assertion that it matches the profile (already in the old code).

File chrome/browser/ash/settings/device_settings_test_helper.cc

Line 43, Patchset 4 (Latest): message_center::MessageCenter::Shutdown();

Georg Neis . unresolved

Consider moving `message_center::MessageCenter::Shutdown();` to `TearDown()` to pair it symmetrically with `Initialize()` in `SetUp()`.

Attention is currently required from:

Submit Requirements:

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages