Add UMA for nis in nsswitch.conf [chromium/src : main]
Tsuyoshi Horo (Gerrit)
Attention is currently required from: David Benjamin.
Patch set 4:Commit-Queue +1
1 comment:
Patchset:
davidben@
Could you please review this?Thank you.
To view, visit change 3809204. To unsubscribe, or for help writing mail filters, visit settings.
David Benjamin (Gerrit)
Attention is currently required from: Tsuyoshi Horo.
Patch set 4:Code-Review +1
3 comments:
Patchset:
Thanks!
File net/dns/dns_config_service_linux.cc:
Optional: I'm not positive if this works, but I think you can actually write:
```
base::Contains(nsswitch_hosts, NsswitchReader::Service::kNis,
&NsswitchReader::ServiceSpecification::service)
```
File tools/metrics/histograms/metadata/net/histograms.xml:
Patch Set #4, Line 630:
BooleanValidNit: This isn't really about validity. Perhaps BooleanIncluded? (Or BooleanFound or BooleanContained or BooleanRegistered or BooleanPresent.)
To view, visit change 3809204. To unsubscribe, or for help writing mail filters, visit settings.
Tsuyoshi Horo (Gerrit)
3 comments:
Patchset:
Thank you.
File net/dns/dns_config_service_linux.cc:
Optional: I'm not positive if this works, but I think you can actually write: […]
Done
File tools/metrics/histograms/metadata/net/histograms.xml:
Patch Set #4, Line 630:
BooleanValid
Nit: This isn't really about validity. […]
BooleanIncluded sounds good.
Done.
To view, visit change 3809204. To unsubscribe, or for help writing mail filters, visit settings.
Tsuyoshi Horo (Gerrit)
Attention is currently required from: Takashi Toyoshima.
1 comment:
Patchset:
toyoshim@
Could you please review histograms.xml?
To view, visit change 3809204. To unsubscribe, or for help writing mail filters, visit settings.
Takashi Toyoshima (Gerrit)
Attention is currently required from: Tsuyoshi Horo.
2 comments:
File net/dns/dns_config_service_linux.cc:
Patch Set #5, Line 479:
UMA_HISTOGRAM_BOOLEANDo you mind if you change macro based UMA calls in this file to use alternatives defined in histogram_functions.h? It costs 130 bytes/macro and function call is fast enough for usual use cases.
At least, we recommend a function call for the new code.
File tools/metrics/histograms/metadata/net/histograms.xml:
Patch Set #5, Line 633:
summaryCan you also add an explanation when this is recorded? E.g. recorded once on parsing nsswitch.conf, or so.
To view, visit change 3809204. To unsubscribe, or for help writing mail filters, visit settings.
Tsuyoshi Horo (Gerrit)
Attention is currently required from: Takashi Toyoshima.
3 comments:
Patchset:
Thank you.
File net/dns/dns_config_service_linux.cc:
Patch Set #5, Line 479:
UMA_HISTOGRAM_BOOLEAN
Do you mind if you change macro based UMA calls in this file to use alternatives defined in histogra […]
Done
File tools/metrics/histograms/metadata/net/histograms.xml:
Patch Set #5, Line 633:
summary
Can you also add an explanation when this is recorded? E.g. recorded once on parsing nsswitch. […]
Done
To view, visit change 3809204. To unsubscribe, or for help writing mail filters, visit settings.
Takashi Toyoshima (Gerrit)
Attention is currently required from: Tsuyoshi Horo.
Patch set 6:Code-Review +1
1 comment:
Patchset:
Thanks a lot!
To view, visit change 3809204. To unsubscribe, or for help writing mail filters, visit settings.
Tsuyoshi Horo (Gerrit)
Patch set 6:Commit-Queue +2
1 comment:
Patchset:
Thank you.
To view, visit change 3809204. To unsubscribe, or for help writing mail filters, visit settings.
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
Add UMA for nis in nsswitch.conf
If the NIS service in nsswitch.conf file's hosts database is still
widely used, we need to handle such case to disable AsyncDNS.
Bug: 1350321
Change-Id: Iddfb1b56e683e8d133c35263f9582ef905c7ecd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3809204
Reviewed-by: David Benjamin <davi...@chromium.org>
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Commit-Queue: Tsuyoshi Horo <ho...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1033323}
---
M net/dns/dns_config_service_linux.cc
M net/dns/dns_config_service_linux_unittest.cc
M tools/metrics/histograms/metadata/net/histograms.xml
3 files changed, 83 insertions(+), 16 deletions(-)