[Watermark 2.0] Refactor WatermarkView to pass color directly [chromium/src : main]
1 view
Skip to first unread message
Nasser Al-shawwa (Gerrit)
Jun 11, 2025, 3:47:10 PM6/11/25
to Adam Kassi Lahlou, Jan Keitel, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, asvitkine...@chromium.org, cbe-cep-eng...@google.com
Attention needed from Adam Kassi Lahlou
Nasser Al-shawwa voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Adam Kassi Lahlou
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Kassi Lahlou (Gerrit)
Jun 11, 2025, 4:04:29 PM6/11/25
to Nasser Al-shawwa, Jan Keitel, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, asvitkine...@chromium.org, cbe-cep-eng...@google.com
Attention needed from Jan Keitel and Nasser Al-shawwa
Adam Kassi Lahlou added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 28 (Latest):
Adam Kassi Lahlou . resolved
This CL has been revised to focus on refactoring the watermark view code.
A follow-up CL (6637796) will soon be ready to review to finish the work and retrieve the opacity values from preferences.
Please review this one, and you'll be added as a reviewer for the next one as well.
Related details
Attention is currently required from:
- Jan Keitel
- Nasser Al-shawwa
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jan Keitel (Gerrit)
Jun 12, 2025, 6:42:36 AM6/12/25
to Adam Kassi Lahlou, Nasser Al-shawwa, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, asvitkine...@chromium.org, cbe-cep-eng...@google.com
Attention needed from Adam Kassi Lahlou
Jan Keitel voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Adam Kassi Lahlou
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Kassi Lahlou (Gerrit)
Jun 12, 2025, 9:18:51 AM6/12/25
to Jan Keitel, Nasser Al-shawwa, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, asvitkine...@chromium.org, cbe-cep-eng...@google.com
Adam Kassi Lahlou voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 12, 2025, 9:23:36 AM6/12/25
to Adam Kassi Lahlou, Jan Keitel, Nasser Al-shawwa, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, asvitkine...@chromium.org, cbe-cep-eng...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Watermark 2.0] Refactor WatermarkView to pass color directly
This CL simplifies the WatermarkView class by removing the explicit
text constructor and the need to pass a PrefService.
Color information is now passed directly to the SetString method.
This gives the caller the responsibility for determining
the watermark color.
The legacy watermark example app is updated to reflect these changes.
Bug: 423936918
Change-Id: I53b227724a4bfbe80ca55be4b2f85b794bd74072
Commit-Queue: Adam Kassi Lahlou <ada...@google.com>
Reviewed-by: Jan Keitel <jke...@google.com>
Reviewed-by: Nasser Al-shawwa <alsh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473003}
Files:
- M chrome/browser/enterprise/watermark/watermark_browsertest.cc
- M chrome/browser/enterprise/watermark/watermark_example.cc
- M chrome/browser/enterprise/watermark/watermark_example.h
- M chrome/browser/enterprise/watermark/watermark_view.cc
- M chrome/browser/enterprise/watermark/watermark_view.h
- M chrome/browser/enterprise/watermark/watermark_view_unittest.cc
- M chrome/browser/ui/views/frame/browser_view.cc
Change size: M
Delta: 7 files changed, 38 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jan Keitel, +1 by Nasser Al-shawwa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rouslan Solomakhin (Gerrit)
Jun 12, 2025, 12:30:45 PM6/12/25
to Adam Kassi Lahlou, Chromium LUCI CQ, Jan Keitel, Nasser Al-shawwa, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, asvitkine...@chromium.org, cbe-cep-eng...@google.com
Rouslan Solomakhin has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages