Propagate FocusType when forwarding Element::Focus. [chromium/src : main]

0 views
Skip to first unread message

David Baron (Gerrit)

unread,
Jul 17, 2026, 2:23:04 PM (2 days ago) Jul 17
to David Baron, Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed

David Baron voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib44c0ea96a127ccbf5236449c96a0c77e59771e7
Gerrit-Change-Number: 8116087
Gerrit-PatchSet: 1
Gerrit-Owner: David Baron <dba...@chromium.org>
Gerrit-Reviewer: David Baron <dba...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Jul 2026 18:22:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Jul 17, 2026, 7:01:06 PM (2 days ago) Jul 17
to David Baron, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from David Baron

Mason Freed voted and added 2 comments

Votes added by Mason Freed

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mason Freed . resolved

This LGTM, but does it need a test?

File-level comment, Patchset 1 (Latest):
Mason Freed . unresolved

This LGTM, but does it need a test?

Open in Gerrit

Related details

Attention is currently required from:
  • David Baron
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib44c0ea96a127ccbf5236449c96a0c77e59771e7
    Gerrit-Change-Number: 8116087
    Gerrit-PatchSet: 1
    Gerrit-Owner: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: David Baron <dba...@chromium.org>
    Gerrit-Comment-Date: Fri, 17 Jul 2026 23:00:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Baron (Gerrit)

    unread,
    Jul 18, 2026, 3:17:54 PM (16 hours ago) Jul 18
    to David Baron, Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
    Attention needed from Mason Freed

    David Baron added 1 comment

    Patchset-level comments
    Mason Freed . resolved

    This LGTM, but does it need a test?

    David Baron

    Indeed, I had an AI-written test sitting in a tab but not committed and uploaded yet. Added now.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mason Freed
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib44c0ea96a127ccbf5236449c96a0c77e59771e7
      Gerrit-Change-Number: 8116087
      Gerrit-PatchSet: 2
      Gerrit-Owner: David Baron <dba...@chromium.org>
      Gerrit-Reviewer: David Baron <dba...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Attention: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Sat, 18 Jul 2026 19:17:38 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Mason Freed <mas...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages