[contextual_tasks] Implement click action for images and files [chromium/src : main]

0 views
Skip to first unread message

Shakti Sahu (Gerrit)

unread,
Jan 16, 2026, 11:16:10 PM (15 hours ago) Jan 16
to Min Qin, Alex Gough, chromium...@chromium.org, Sophie Chang
Attention needed from Min Qin

Shakti Sahu added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Shakti Sahu . resolved

qinmin@ - PTAL
ajgo@ - cc on the c++ side of mojo implementation

Open in Gerrit

Related details

Attention is currently required from:
  • Min Qin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9eebdcabf6631f145a80017d51087c4eee2bb25a
Gerrit-Change-Number: 7489545
Gerrit-PatchSet: 2
Gerrit-Owner: Shakti Sahu <shakt...@chromium.org>
Gerrit-Reviewer: Min Qin <qin...@chromium.org>
Gerrit-CC: Alex Gough <aj...@chromium.org>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-Attention: Min Qin <qin...@chromium.org>
Gerrit-Comment-Date: Sat, 17 Jan 2026 04:15:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Min Qin (Gerrit)

unread,
12:41 AM (14 hours ago) 12:41 AM
to Shakti Sahu, Chromium LUCI CQ, Alex Gough, chromium...@chromium.org, Sophie Chang
Attention needed from Shakti Sahu

Min Qin added 1 comment

File chrome/browser/contextual_tasks/contextual_tasks_ui_service.cc
Line 1024, Patchset 3 (Latest): if (!url.SchemeIsHTTPOrHTTPS()) {
Min Qin . unresolved

can file have file URLs?

Open in Gerrit

Related details

Attention is currently required from:
  • Shakti Sahu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9eebdcabf6631f145a80017d51087c4eee2bb25a
    Gerrit-Change-Number: 7489545
    Gerrit-PatchSet: 3
    Gerrit-Owner: Shakti Sahu <shakt...@chromium.org>
    Gerrit-Reviewer: Min Qin <qin...@chromium.org>
    Gerrit-Reviewer: Shakti Sahu <shakt...@chromium.org>
    Gerrit-CC: Alex Gough <aj...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Shakti Sahu <shakt...@chromium.org>
    Gerrit-Comment-Date: Sat, 17 Jan 2026 05:41:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Shakti Sahu (Gerrit)

    unread,
    11:32 AM (3 hours ago) 11:32 AM
    to Chromium LUCI CQ, Min Qin, Alex Gough, chromium...@chromium.org, Sophie Chang

    Shakti Sahu added 1 comment

    File chrome/browser/contextual_tasks/contextual_tasks_ui_service.cc
    Line 1024, Patchset 3 (Latest): if (!url.SchemeIsHTTPOrHTTPS()) {
    Shakti Sahu . unresolved

    Sorry, these are files uploaded by the user and now hosted in the server. They will be http/https URLs.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9eebdcabf6631f145a80017d51087c4eee2bb25a
    Gerrit-Change-Number: 7489545
    Gerrit-PatchSet: 3
    Gerrit-Owner: Shakti Sahu <shakt...@chromium.org>
    Gerrit-Reviewer: Min Qin <qin...@chromium.org>
    Gerrit-Reviewer: Shakti Sahu <shakt...@chromium.org>
    Gerrit-CC: Alex Gough <aj...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Comment-Date: Sat, 17 Jan 2026 16:32:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages