[contextual_tasks] Implement click action for images and files [chromium/src : main]
0 views
Skip to first unread message
Shakti Sahu (Gerrit)
Jan 16, 2026, 11:16:10 PM (15 hours ago) Jan 16
to Min Qin, Alex Gough, chromium...@chromium.org, Sophie Chang
Attention needed from Min Qin
Shakti Sahu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Shakti Sahu . resolved
qinmin@ - PTAL
ajgo@ - cc on the c++ side of mojo implementation
Related details
Attention is currently required from:
- Min Qin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Min Qin (Gerrit)
12:41 AM (14 hours ago) 12:41 AM
to Shakti Sahu, Chromium LUCI CQ, Alex Gough, chromium...@chromium.org, Sophie Chang
Attention needed from Shakti Sahu
Min Qin added 1 comment![]( "Open in Gerrit")
File chrome/browser/contextual_tasks/contextual_tasks_ui_service.cc
Line 1024, Patchset 3 (Latest):
if (!url.SchemeIsHTTPOrHTTPS()) {Min Qin . unresolved
can file have file URLs?
Related details
Attention is currently required from:
- Shakti Sahu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shakti Sahu (Gerrit)
11:32 AM (3 hours ago) 11:32 AM
to Chromium LUCI CQ, Min Qin, Alex Gough, chromium...@chromium.org, Sophie Chang
Shakti Sahu added 1 comment![]( "Open in Gerrit")
File chrome/browser/contextual_tasks/contextual_tasks_ui_service.cc
Line 1024, Patchset 3 (Latest):
if (!url.SchemeIsHTTPOrHTTPS()) {Shakti Sahu . unresolved
Sorry, these are files uploaded by the user and now hosted in the server. They will be http/https URLs.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages