[a11y][Android] Make AllPasswords titles focusable for screen readers [chromium/src : main]

0 views
Skip to first unread message

Josef Raska (Gerrit)

unread,
8:26 AM (2 hours ago) 8:26 AM
to Piotr Kotynia, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Piotr Kotynia

Josef Raska added 1 comment

File chrome/browser/keyboard_accessory/android/internal/java/res/layout/all_passwords_bottom_sheet.xml
Line 20, Patchset 3 (Latest): android:importantForAccessibility="yes"
Josef Raska . unresolved

Consider: Such a bug is very likely to repeat since we use raw `TextView` and not a common component.

Isn't there a common style or not sure if we should consider this as part of `textAppearance`. Or perhaps just a knowledge sharing in any form.

Basically any idea how to prevent this from happening again?

Open in Gerrit

Related details

Attention is currently required from:
  • Piotr Kotynia
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3db67253f8e2a08f2caea199077ef3655af37a3e
Gerrit-Change-Number: 8063896
Gerrit-PatchSet: 3
Gerrit-Owner: Piotr Kotynia <piotrk...@google.com>
Gerrit-Reviewer: Josef Raska <josef...@google.com>
Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>
Gerrit-Attention: Piotr Kotynia <piotrk...@google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 12:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Josef Raska (Gerrit)

unread,
8:27 AM (2 hours ago) 8:27 AM
to Piotr Kotynia, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Piotr Kotynia

Josef Raska voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Piotr Kotynia
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3db67253f8e2a08f2caea199077ef3655af37a3e
    Gerrit-Change-Number: 8063896
    Gerrit-PatchSet: 3
    Gerrit-Owner: Piotr Kotynia <piotrk...@google.com>
    Gerrit-Reviewer: Josef Raska <josef...@google.com>
    Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>
    Gerrit-Attention: Piotr Kotynia <piotrk...@google.com>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 12:26:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Piotr Kotynia (Gerrit)

    unread,
    8:39 AM (2 hours ago) 8:39 AM
    to Josef Raska, Chromium LUCI CQ, chromium...@chromium.org

    Piotr Kotynia added 1 comment

    File chrome/browser/keyboard_accessory/android/internal/java/res/layout/all_passwords_bottom_sheet.xml
    Line 20, Patchset 3 (Latest): android:importantForAccessibility="yes"
    Josef Raska . resolved

    Consider: Such a bug is very likely to repeat since we use raw `TextView` and not a common component.

    Isn't there a common style or not sure if we should consider this as part of `textAppearance`. Or perhaps just a knowledge sharing in any form.

    Basically any idea how to prevent this from happening again?

    Piotr Kotynia

    I think that this is usually prevented by defining green lines for the project and aligning with them. Older projects like this probably didn't have it or something was omitted. AFAIK we don't have any common Chromium style to enforce this and implementing such could be a big effort to do. Probably up to Accessibility team to define it.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3db67253f8e2a08f2caea199077ef3655af37a3e
      Gerrit-Change-Number: 8063896
      Gerrit-PatchSet: 3
      Gerrit-Owner: Piotr Kotynia <piotrk...@google.com>
      Gerrit-Reviewer: Josef Raska <josef...@google.com>
      Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>
      Gerrit-Comment-Date: Thu, 09 Jul 2026 12:39:02 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Josef Raska <josef...@google.com>
      satisfied_requirement
      open
      diffy

      Piotr Kotynia (Gerrit)

      unread,
      8:39 AM (2 hours ago) 8:39 AM
      to Josef Raska, Chromium LUCI CQ, chromium...@chromium.org

      Piotr Kotynia voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3db67253f8e2a08f2caea199077ef3655af37a3e
      Gerrit-Change-Number: 8063896
      Gerrit-PatchSet: 3
      Gerrit-Owner: Piotr Kotynia <piotrk...@google.com>
      Gerrit-Reviewer: Josef Raska <josef...@google.com>
      Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>
      Gerrit-Comment-Date: Thu, 09 Jul 2026 12:39:06 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      9:15 AM (1 hour ago) 9:15 AM
      to Piotr Kotynia, Josef Raska, chromium...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [a11y][Android] Make AllPasswords titles focusable for screen readers

      The "Select password" title and the origin warning subtitle in the All
      Passwords bottom sheet were not focusable or read by TalkBack. This CL
      fixes the issue by marking both TextViews as screen reader focusable and
      important for accessibility, and setting the title as an accessibility
      heading.
      Bug: 503880137
      Change-Id: I3db67253f8e2a08f2caea199077ef3655af37a3e
      Reviewed-by: Josef Raska <josef...@google.com>
      Commit-Queue: Piotr Kotynia <piotrk...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1659508}
      Files:
      • M chrome/browser/keyboard_accessory/android/internal/java/res/layout/all_passwords_bottom_sheet.xml
      Change size: XS
      Delta: 1 file changed, 5 insertions(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Josef Raska
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3db67253f8e2a08f2caea199077ef3655af37a3e
      Gerrit-Change-Number: 8063896
      Gerrit-PatchSet: 4
      Gerrit-Owner: Piotr Kotynia <piotrk...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Josef Raska <josef...@google.com>
      Gerrit-Reviewer: Piotr Kotynia <piotrk...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages