[Autofill AI] Record metrics for Autofill AI settings link-out dialog [chromium/src : main]

0 views
Skip to first unread message

Timofey Chudakov (Gerrit)

unread,
Jul 20, 2026, 10:36:51 AM (yesterday) Jul 20
to Cathy Chen, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, browser-comp...@chromium.org, asvitkine...@chromium.org
Attention needed from Cathy Chen

Timofey Chudakov voted and added 3 comments

Votes added by Timofey Chudakov

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Timofey Chudakov . resolved

LGTM

File chrome/browser/autofill/android/java/src/org/chromium/chrome/browser/autofill/autofill_ai/AutofillAiMetricsRecorder.java
Line 13, Patchset 6 (Latest):public class AutofillAiMetricsRecorder {
Timofey Chudakov . unresolved

No need to create a separate file once you use the metrics string from the `EntityType`.

File chrome/browser/keyboard_accessory/android/internal/java/src/org/chromium/chrome/browser/keyboard_accessory/bar_component/KeyboardAccessoryMediator.java
Line 416, Patchset 6 (Latest): entityInstance.getEntityType().getTypeName(),
Timofey Chudakov . unresolved

It wasn't very obvious, but you need to pass the `entityInstance.getEntityType().getTypeNameAsMetricsString()` as an additional parameter and then record the metric using it.

Open in Gerrit

Related details

Attention is currently required from:
  • Cathy Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0ec50a2eafcbe7702ebef93a096aeb5172272d92
Gerrit-Change-Number: 8124515
Gerrit-PatchSet: 6
Gerrit-Owner: Cathy Chen <yungy...@google.com>
Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Cathy Chen <yungy...@google.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 14:36:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Timofey Chudakov (Gerrit)

unread,
Jul 20, 2026, 10:36:56 AM (yesterday) Jul 20
to Cathy Chen, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, browser-comp...@chromium.org, asvitkine...@chromium.org
Attention needed from Cathy Chen

Timofey Chudakov voted Code-Review+0

Code-Review+0
Open in Gerrit

Related details

Attention is currently required from:
  • Cathy Chen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0ec50a2eafcbe7702ebef93a096aeb5172272d92
    Gerrit-Change-Number: 8124515
    Gerrit-PatchSet: 6
    Gerrit-Owner: Cathy Chen <yungy...@google.com>
    Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Cathy Chen <yungy...@google.com>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 14:36:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Cathy Chen (Gerrit)

    unread,
    Jul 20, 2026, 1:05:12 PM (yesterday) Jul 20
    to Chromium LUCI CQ, Timofey Chudakov, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, browser-comp...@chromium.org, asvitkine...@chromium.org
    Attention needed from Timofey Chudakov

    Cathy Chen voted and added 2 comments

    Votes added by Cathy Chen

    Commit-Queue+1

    2 comments

    File chrome/browser/autofill/android/java/src/org/chromium/chrome/browser/autofill/autofill_ai/AutofillAiMetricsRecorder.java
    Line 13, Patchset 6:public class AutofillAiMetricsRecorder {
    Timofey Chudakov . resolved

    No need to create a separate file once you use the metrics string from the `EntityType`.

    Cathy Chen

    Done

    File chrome/browser/keyboard_accessory/android/internal/java/src/org/chromium/chrome/browser/keyboard_accessory/bar_component/KeyboardAccessoryMediator.java
    Line 416, Patchset 6: entityInstance.getEntityType().getTypeName(),
    Timofey Chudakov . resolved

    It wasn't very obvious, but you need to pass the `entityInstance.getEntityType().getTypeNameAsMetricsString()` as an additional parameter and then record the metric using it.

    Cathy Chen

    I pass entityInstance.getEntityType() instead of having 2 parameters. Please feel free to correct.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Timofey Chudakov
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0ec50a2eafcbe7702ebef93a096aeb5172272d92
      Gerrit-Change-Number: 8124515
      Gerrit-PatchSet: 10
      Gerrit-Owner: Cathy Chen <yungy...@google.com>
      Gerrit-Reviewer: Cathy Chen <yungy...@google.com>
      Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
      Gerrit-Attention: Timofey Chudakov <tchu...@google.com>
      Gerrit-Comment-Date: Mon, 20 Jul 2026 17:04:55 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Timofey Chudakov <tchu...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Timofey Chudakov (Gerrit)

      unread,
      5:49 AM (14 hours ago) 5:49 AM
      to Cathy Chen, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, browser-comp...@chromium.org, asvitkine...@chromium.org
      Attention needed from Cathy Chen

      Timofey Chudakov voted and added 2 comments

      Votes added by Timofey Chudakov

      Code-Review+1

      2 comments

      Patchset-level comments
      File-level comment, Patchset 10 (Latest):
      Timofey Chudakov . resolved

      LGTM, very nice!

      File tools/metrics/histograms/metadata/autofill/histograms.xml
      Line 2014, Patchset 10 (Latest): <owner>bruno...@google.com</owner>
      Timofey Chudakov . unresolved

      Please change to `tchudakov`

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Cathy Chen
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I0ec50a2eafcbe7702ebef93a096aeb5172272d92
        Gerrit-Change-Number: 8124515
        Gerrit-PatchSet: 10
        Gerrit-Owner: Cathy Chen <yungy...@google.com>
        Gerrit-Reviewer: Cathy Chen <yungy...@google.com>
        Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-Attention: Cathy Chen <yungy...@google.com>
        Gerrit-Comment-Date: Tue, 21 Jul 2026 09:49:06 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Cathy Chen (Gerrit)

        unread,
        6:10 AM (14 hours ago) 6:10 AM
        to Timofey Chudakov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, browser-comp...@chromium.org, asvitkine...@chromium.org
        Attention needed from Timofey Chudakov

        Cathy Chen added 1 comment

        File tools/metrics/histograms/metadata/autofill/histograms.xml
        Line 2014, Patchset 11 (Latest): <owner>tchu...@google.com</owner>
        Cathy Chen . resolved

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Timofey Chudakov
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I0ec50a2eafcbe7702ebef93a096aeb5172272d92
          Gerrit-Change-Number: 8124515
          Gerrit-PatchSet: 11
          Gerrit-Owner: Cathy Chen <yungy...@google.com>
          Gerrit-Reviewer: Cathy Chen <yungy...@google.com>
          Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-Attention: Timofey Chudakov <tchu...@google.com>
          Gerrit-Comment-Date: Tue, 21 Jul 2026 10:10:33 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Timofey Chudakov (Gerrit)

          unread,
          6:12 AM (14 hours ago) 6:12 AM
          to Cathy Chen, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, browser-comp...@chromium.org, asvitkine...@chromium.org
          Attention needed from Cathy Chen

          Timofey Chudakov voted and added 1 comment

          Votes added by Timofey Chudakov

          Code-Review+1

          1 comment

          Patchset-level comments
          Timofey Chudakov . resolved

          LGTM

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Cathy Chen
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I0ec50a2eafcbe7702ebef93a096aeb5172272d92
            Gerrit-Change-Number: 8124515
            Gerrit-PatchSet: 11
            Gerrit-Owner: Cathy Chen <yungy...@google.com>
            Gerrit-Reviewer: Cathy Chen <yungy...@google.com>
            Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
            Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
            Gerrit-Attention: Cathy Chen <yungy...@google.com>
            Gerrit-Comment-Date: Tue, 21 Jul 2026 10:11:50 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy
            Reply all
            Reply to author
            Forward
            0 new messages