Revert "[soft navs] CHECK(!TimeOrigin().is_null()) for any SoftNavigationContext" [chromium/src : main]
luci-bisection@appspot.gserviceaccount.com (Gerrit)
luci-bi...@appspot.gserviceaccount.com has uploaded the change for review![]( "Open in Gerrit")
luci-bi...@appspot.gserviceaccount.com would like Johannes Henkel, Scott Haseley, Chromium LUCI CQ, Stefan Zager and Michal Mocny to review this change.
Commit message
Revert "[soft navs] CHECK(!TimeOrigin().is_null()) for any SoftNavigationContext"
This reverts commit 10898274ef3d9ec9364f65731634a211021761b7.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5733269195718656
Sample build with failed test: https://ci.chromium.org/b/8676640291144971329
Affected test(s):
[://android_webview/test\:webview_cts_tests!junit:android.webkit.cts:WebViewRenderProcessClientTest#testWebViewRenderProcessClientWithExecutor](https://ci.chromium.org/ui/test/chromium/:%2F%2Fandroid_webview%2Ftest%5C:webview_cts_tests%21junit:android.webkit.cts:WebViewRenderProcessClientTest%23testWebViewRenderProcessClientWithExecutor?q=VHash%3A372157ef91cf067b)
[://android_webview/test\:webview_cts_tests!junit:android.webkit.cts:WebViewRenderProcessClientTest#testWebViewRenderProcessClientWithoutExecutor](https://ci.chromium.org/ui/test/chromium/:%2F%2Fandroid_webview%2Ftest%5C:webview_cts_tests%21junit:android.webkit.cts:WebViewRenderProcessClientTest%23testWebViewRenderProcessClientWithoutExecutor?q=VHash%3A372157ef91cf067b)
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5733269195718656&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8072864&type=BUG
Original change's description:
> [soft navs] CHECK(!TimeOrigin().is_null()) for any SoftNavigationContext
>
> This fixes the remaining tests that create input events that don't
> have a timestamp by calling SetTimeStamp(base::TimeTicks::Now()), and
> adds a CHECK statement to the constructor of SoftNavigationContext.
>
> Change-Id: I6b390ea920235d60e2ddf6787efacf1dcfe3f827
> Bug: 490814752
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8072864
> Reviewed-by: Scott Haseley <shas...@chromium.org>
> Commit-Queue: Johannes Henkel <joha...@chromium.org>
> Reviewed-by: Stefan Zager <sza...@chromium.org>
> Reviewed-by: Michal Mocny <mmo...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1660393}
>
Change diff
Change information
- M content/renderer/render_view_browsertest_mac.mm
- M third_party/blink/renderer/core/input/event_handler_test.cc
- M third_party/blink/renderer/core/layout/layout_shift_tracker_test.cc
- M third_party/blink/renderer/core/timing/soft_navigation_context.cc
Related details
- Johannes Henkel
- Michal Mocny
- Scott Haseley
- Stefan Zager
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.
Related details
- Johannes Henkel
- Michal Mocny
- Scott Haseley
- Stefan Zager
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
- Johannes Henkel
- Michal Mocny
- Scott Haseley
- Stefan Zager
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chrome Crash (Prod) (Gerrit)
Chrome Crash (Prod) has uploaded the change for review![]( "Open in Gerrit")
Chrome Crash (Prod) would like Johannes Henkel, Scott Haseley, Chromium LUCI CQ, Stefan Zager and Michal Mocny to review this change.
Commit message
Revert "[soft navs] CHECK(!TimeOrigin().is_null()) for any SoftNavigationContext"
This reverts commit 10898274ef3d9ec9364f65731634a211021761b7.
Reason for revert:
The Suspect CL https://chromium-review.googlesource.com/q/I6b390ea920235d60e2ddf6787efacf1dcfe3f827 is highly likely the cause of the crash. Please see the crash report http://crash/7519a9554b2dc36e.
Rebase the Revert CL on top of main branch with conflicts allowed option to prevent false positive merge conflicts.
If you agree with the revert CL, please approve it and mark as Commit-Queue +2 to submit it.
More details can be found in the go/crash-revert-cls-creation.
Original change's description:
> [soft navs] CHECK(!TimeOrigin().is_null()) for any SoftNavigationContext
>
> This fixes the remaining tests that create input events that don't
> have a timestamp by calling SetTimeStamp(base::TimeTicks::Now()), and
> adds a CHECK statement to the constructor of SoftNavigationContext.
>
> Change-Id: I6b390ea920235d60e2ddf6787efacf1dcfe3f827
> Bug: 490814752
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8072864
> Reviewed-by: Scott Haseley <shas...@chromium.org>
> Commit-Queue: Johannes Henkel <joha...@chromium.org>
> Reviewed-by: Stefan Zager <sza...@chromium.org>
> Reviewed-by: Michal Mocny <mmo...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1660393}
>
Change diff
Change information
- M content/renderer/render_view_browsertest_mac.mm
- M third_party/blink/renderer/core/input/event_handler_test.cc
- M third_party/blink/renderer/core/layout/layout_shift_tracker_test.cc
- M third_party/blink/renderer/core/timing/soft_navigation_context.cc
Related details
- Johannes Henkel
- Michal Mocny
- Scott Haseley
- Stefan Zager
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chrome Crash (Prod) (Gerrit)
Chrome Crash (Prod) voted Commit-Queue+1![]( "Open in Gerrit")
Trigger the CQ Dryrun through the Set Review API to save waiting time.
| Commit-Queue | +1 |
Related details
- Johannes Henkel
- Michal Mocny
- Scott Haseley
- Stefan Zager
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
- Johannes Henkel
- Michal Mocny
- Scott Haseley
- Stefan Zager
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection recommends submitting this revert because it has confirmed the target of this revert is the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5869013381939200
Sample build with failed test: https://ci.chromium.org/b/8676640512859583345
Affected test(s):
[://android_webview/test\:webview_64_cts_tests!junit:android.webkit.cts:WebViewRenderProcessClientTest#testWebViewRenderProcessClientWithExecutor](https://ci.chromium.org/ui/test/chromium/:%2F%2Fandroid_webview%2Ftest%5C:webview_64_cts_tests%21junit:android.webkit.cts:WebViewRenderProcessClientTest%23testWebViewRenderProcessClientWithExecutor?q=VHash%3A1f24aac67b28053a)
[://android_webview/test\:webview_64_cts_tests!junit:android.webkit.cts:WebViewRenderProcessClientTest#testWebViewRenderProcessClientWithExecutor](https://ci.chromium.org/ui/test/chromium/:%2F%2Fandroid_webview%2Ftest%5C:webview_64_cts_tests%21junit:android.webkit.cts:WebViewRenderProcessClientTest%23testWebViewRenderProcessClientWithExecutor?q=VHash%3Aedb29883f5b697e4)
[://android_webview/test\:webview_64_cts_tests!junit:android.webkit.cts:WebViewRenderProcessClientTest#testWebViewRenderProcessClientWithoutExecutor](https://ci.chromium.org/ui/test/chromium/:%2F%2Fandroid_webview%2Ftest%5C:webview_64_cts_tests%21junit:android.webkit.cts:WebViewRenderProcessClientTest%23testWebViewRenderProcessClientWithoutExecutor?q=VHash%3A1f24aac67b28053a)
[://android_webview/test\:webview_64_cts_tests!junit:android.webkit.cts:WebViewRenderProcessClientTest#testWebViewRenderProcessClientWithoutExecutor](https://ci.chromium.org/ui/test/chromium/:%2F%2Fandroid_webview%2Ftest%5C:webview_64_cts_tests%21junit:android.webkit.cts:WebViewRenderProcessClientTest%23testWebViewRenderProcessClientWithoutExecutor?q=VHash%3Aedb29883f5b697e4)
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5869013381939200&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8072864&type=BUG