Remove expressions section type and search source. [chromium/src : main]
0 views
Skip to first unread message
Darren Shen (Gerrit)
3:56 AM (20 hours ago) 3:56 AM
to Michael Cui, chromium...@chromium.org
Attention needed from Michael Cui
Darren Shen voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Michael Cui
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Cui (Gerrit)
8:22 PM (3 hours ago) 8:22 PM
to Darren Shen, Michael Cui, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Darren Shen
Michael Cui voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Darren Shen
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:11 PM (3 hours ago) 9:11 PM
to Darren Shen, Michael Cui, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove expressions section type and search source.
Emoji search is part of a separate search pipeline and does not
involve request or aggregator.
Bug: b:345303965
Change-Id: Ic0ac31a31ffd36bfe83fb23513a44276d7af103e
Reviewed-by: Michael Cui <ml...@google.com>
Commit-Queue: Darren Shen <sh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322509}
Files:
- M ash/picker/model/picker_search_results_section.h
- M ash/picker/search/picker_search_aggregator.cc
- M ash/picker/search/picker_search_aggregator_unittest.cc
- M ash/picker/search/picker_search_request.cc
- M ash/picker/search/picker_search_source.h
- M ash/picker/views/picker_strings.cc
- M ash/picker/views/picker_view.cc
Change size: M
Delta: 7 files changed, 1 insertion(+), 52 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Cui
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages